github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add error checking around std::getenv for KeyVault tests (#2019)

Browse Source 
* Add error checking around std::getenv for KeyVault tests

* Revert unrelated change.
This commit is contained in:
Ahson Khan 2021-03-31 20:43:16 -07:00 committed by GitHub
parent cd4ea9966d
commit 0a68af6c1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_base_test.hpp
View File

@ -20,6 +20,18 @@
namespace Azure { namespace Security { namespace KeyVault { namespace Keys { namespace Test {
class KeyVaultClientTest : public ::testing::Test {
private:
std::string GetEnv(const std::string& name)
{
const char* ret = std::getenv(name.data());
if (!ret)
{
throw std::runtime_error(
name + " is required to run the tests but not set as an environment variable.");
}
return std::string(ret);
}
protected:
std::shared_ptr<Azure::Identity::ClientSecretCredential> m_credential;
std::string m_keyVaultUrl;
@ -29,14 +41,14 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { nam
// Create
virtual void SetUp() override
{
std::string tenantId = std::getenv("AZURE_TENANT_ID");
std::string clientId = std::getenv("AZURE_CLIENT_ID");
std::string secretId = std::getenv("AZURE_CLIENT_SECRET");
std::string tenantId = GetEnv("AZURE_TENANT_ID");
std::string clientId = GetEnv("AZURE_CLIENT_ID");
std::string secretId = GetEnv("AZURE_CLIENT_SECRET");
m_credential
= std::make_shared<Azure::Identity::ClientSecretCredential>(tenantId, clientId, secretId);
m_keyVaultUrl = std::getenv("AZURE_KEYVAULT_URL");
m_keyVaultHsmUrl = std::getenv("AZURE_KEYVAULT_HSM_URL");
m_keyVaultUrl = GetEnv("AZURE_KEYVAULT_URL");
m_keyVaultHsmUrl = GetEnv("AZURE_KEYVAULT_HSM_URL");
}
public: