github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix pollInternal implementation (#1892)

Browse Source
This commit is contained in:
Victor Vazquez 2021-03-12 16:22:34 -08:00 committed by GitHub
parent 42a67b1349
commit 6c5e487f6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/keyvault/azure-security-keyvault-keys/src/delete_key_operation.cpp
View File

@ -35,7 +35,7 @@ Azure::Security::KeyVault::Keys::DeleteKeyOperation::PollInternal(Azure::Core::C
{
rawResponse = m_pipeline->GetResponse(
context, Azure::Core::Http::HttpMethod::Get, {_detail::DeletedKeysPath, m_value.Name()});
m_status = CheckCompleted(*m_rawResponse);
m_status = CheckCompleted(*rawResponse);
}
// To ensure the success of calling Poll multiple times, even after operation is completed, a

7
sdk/keyvault/azure-security-keyvault-keys/test/ut/CMakeLists.txt
View File

@ -27,8 +27,11 @@ target_link_libraries(azure-security-keyvault-keys-test PRIVATE azure-security-k
# gtest_add_tests will scan the test from azure-core-test and call add_test
# for each test to ctest. This enables `ctest -r` to run specific tests directly.
gtest_add_tests(TARGET azure-security-keyvault-keys-test
TEST_PREFIX azure-security-keyvault-keys-unittest.)
gtest_discover_tests(azure-security-keyvault-keys-test
TEST_PREFIX azure-security-keyvault-keys-unittest.
NO_PRETTY_TYPES
NO_PRETTY_VALUES
)
################## Live Tests ##########################

6
sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_base_test.hpp
View File

@ -44,7 +44,11 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { nam
Azure::Core::Http::HttpStatusCode expectedCode = Azure::Core::Http::HttpStatusCode::Ok)
{
auto rawResponse = response.ExtractRawResponse();
EXPECT_EQ(rawResponse->GetStatusCode(), expectedCode);
EXPECT_EQ(
static_cast<typename std::underlying_type<Azure::Core::Http::HttpStatusCode>::type>(
rawResponse->GetStatusCode()),
static_cast<typename std::underlying_type<Azure::Core::Http::HttpStatusCode>::type>(
expectedCode));
}
};