* Add argument validation to public APIs.
* Add exception to spell check.
* Revert "Add exception to spell check."
This reverts commit be54b614cc1427ddb2f154f5927f4e612a4a1e28.
* Turn invalid arg excetion to a precondition assert for bodystream read.
* User assert in more places within body_stream.
* Update valiation for hashing and bodystream and update tests.
* Update precondition test for size_t and add null ptr check
* Fix clang formatting.
* Update changelog and fix up the message for size_t validation in hash.
* Address PR feedback.
* More PR feedback.
* Remove unnecessary comment from test.
* Fix clang format.
* Use size_t for buffers representing data in memory rather than int64_t.
* add a cast from size_t to int64_t
* Address feedback - OnRead return size_t.
* Change Read and ReadToCount to return size_t instead of int64_t.
* Update curl usage and ReadFromSocket.
* Missed one signature.
* Update changelog.
* Update transport layer to use the right size_t size.
* Fix curl use of MBS.
* Cast to size_t since that's all memory stream supprts.
* Add static casts to size_t as temporary workarounds.
* update storage tests.
* More test fixes.
* copy constructor for RequestFailedException
* Apply suggestions from code review
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Avoid using WinHttpQueryDataAvailable, and use WinHttpReadData directly for better throughput.
* Add back new line at end of file.
* Reorder some lines for readability.
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.
Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.
> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`
CSpell: Files checked: 188, Issues found: 0 in 0 files
> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`
CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)
> `cspell lint --config .vscode/cspell.json *.md */**/*.md`
CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)
> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`
CSpell: Files checked: 44, Issues found: 0 in 0 files
> `cspell lint --config .vscode/cspell.json *.* */**/*`
CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)
Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
* Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not used anywhere.
* Add back the unit tests by making them friends.
* Add back line at end of file.
* Check for context cancellation in more places within the winhttp transport layer before each I/O call.
* Update cspell to add exceptions to false positives.
* Address PR feedback.
* Do not check for context cancellation before querying the response headers.
Posix platforms do not generate secure random bytes with random_device().
On posix platforms use the openSSL random byte generator which generates cryptographically secure random bytes
**NOTE**: Once the assert work is done this abort() will be switched over to assert.
* Update vcpkg ports to use a manifest json file instead of a CONTROL file.
* Update vcpkg ports to use a manifest json file instead of a CONTROL file
for remaining packages.
* Add the new vcpkg manifet json files and also update the template
package.
* Update paths in the cmake and eng scripts to find the right file now
that CONTROL is gone.
