* Doc Updates and Revisions for External Use
The focus of these changes is to revise the script to better support use
by external contributors and others outside of the Azure SDK ecosystem and
without access to the Microsoft AAD Tenant.
Changes include:
- Creation of a new Test Application service principal is now possible
from a non-Microsoft AAD tenant.
- When a new Test Application principal is created, the principle of least
privilege is now applied; the new Test Application is granted ownership
of the resource group associated with the test resources and no longer
has access to any other resources in the subscription.
- If an existing Test Application principal is specified, it will be
assigned ownership of the resource group created. This supports using
a Test Application principal without privileges at the subscription-level.
- When no provisioner is specified, the script is now executed in the
context of the caller rather than the Test Application principal.
This supports using a Test Application principal that has restricted
privileges and better aligns to the purpose of the Test Application
principal.
- The `$TestApplicationOid` is now explicitly bound at the time a new Test
Application principal is created rather than having to query for it later.
- Common error scenarios resulting from lack of permissions now provide
messaging with more context of why the failure occurred and suggest
remediation.
- Added new examples to illustrate the common call patterns needed by
external contributors running the script, outside of the Microsoft tenant
and Azure SDK ecosystem.
- Documentation has been enhanced with additional context to detail the
permissions and roles assigned by the script.
- Added documentation details for Bicep template use.
* Add the provisioner OID to the deployment params
Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.
* Fixing typos and spelling mistakes
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* final
* ytryrt
* Update .devcontainer/devcontainer.json
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* Attempt tagging of @danieljurek in PRBody
* Attempt to assign reviewers
* Use codeowners, filter out groups, use a default owner, add comments to issue.
* Move variables to right level of config
* Set PrOwners variable
* Remove PR owners, requires admin permissions
* Escape DevOps variable to expand into string
* Add AuthToken
* Tweak portfile and codeowners to validate multiple artifact scenario
* Revert "Tweak portfile and codeowners to validate multiple artifact scenario"
This reverts commit bcc7a36119c7f399f1b079f51889d6ff0d499142.
* Review feedback
* Validate fallback logic
* Deal with empty list of owners
* Revert "Validate fallback logic"
This reverts commit ade2dff5a7d9cac9bb61fdc0f92cd50412b7c31c.
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Increment package version after release of azure-storage-queues
* Improvement: Create only necessary threads when there isn't enough data to transfer
* Update sdk/storage/azure-storage-common/inc/azure/storage/common/internal/concurrent_transfer.hpp
* CL
# Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/main/CONTRIBUTING.md#pull-requests).
- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
- [x] PR is single purpose
- [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [] Any breaking changes?
* add support for non public scope for secret client credential
* improve function comments
* update tests with good url
* update secret url tests
* update logic to no-throw
* use class
* Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* format
* fix
* remove default scope
* move patch out of Core to use package-per-client patch
* update includes
* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* update patch
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* playback tests
* two running tests
* more tests and some redaction
* formatting
* formatting
* fix bb and remove unused includes
* macos
* annoying issues
* offline client
* format
* pr comment
* reset the env to original after the client is gone.
* oops
* testing
* formats
* remove default resource for secrets, not needed
* code coverage
* build issue
* first set of changes
* another set
* add new constructor
* format files, remove pedantinc ;
* factory
* format
* expect_death not behaving as expected
Trying to reduce the noise to signal ratio and manage GitHub notifications to when I am explicitly tagged for relevant reviews and conversations, rather than during day-to-day keyvault code churn and features.
