Commit Graph

1202 Commits

Author SHA1 Message Date
Victor Vazquez
3596685e80
disable warning from Functional header (#2352)
* update the correct warning
2021-05-26 22:50:58 +00:00
Azure SDK Bot
97ba448859
Sync eng/common directory with azure-sdk-tools for PR 1635 (#2353)
* Update common engineering system for docs onboarding

* Add updates from review feedback

* Space nit

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-05-26 18:15:25 -04:00
JinmingHu
8257ce32da
Fix the grammar of storage docs (#2348) 2021-05-26 08:30:37 -07:00
JinmingHu
2787785d0f
use EXPECT_EQ(x, y) instead of EXPECT_TRUE or EXPECT_FALSE (#2347) 2021-05-26 08:29:39 -07:00
Azure SDK Bot
55cd432693
Add Get-ChangeLogEntriesFromContent (#2345)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-05-25 20:03:58 -04:00
Victor Vazquez
73d5ba0d2d
Doc changes for HTTP and removing the "More" link (#2332)
* update docs from classes

* remove more link from classes part II

* http docs

* Update sdk/core/azure-core/inc/azure/core/http/http.hpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update cmake-modules/AzureDoxygen.cmake

* doc updates

* update RFC

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-05-25 14:02:14 -07:00
Azure SDK Bot
0feac90f09
Sync eng/common directory with azure-sdk-tools for PR 1627 (#2344)
* Refactor sparse checkout template: idempotency and no yaml loops

* Add logging, re-organize sparse checkout script

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-05-25 16:53:57 -04:00
Victor Vazquez
88dc1ac8cf
adding Test file sufix to all tests (#2337)
* azure core

* perf

* identity

* keyvault

* storage
2021-05-25 11:15:30 -07:00
JinmingHu
0876ff4fd5
Add samples (#2342) 2021-05-25 11:08:17 -07:00
Victor Vazquez
fcf75f80d1
update storage download perf test - Take connection string from env (#2247)
* update storage download perf test

* format

* allow getEnv() for msvc

* Add size option

* format

* Download to buffer

* Apply suggestions from code review

* use member for the buffer

Co-authored-by: Mike Harder <mharder@microsoft.com>
2021-05-21 17:00:38 -07:00
Azure SDK Bot
6012511293
Increment package version after release of azure-core (#2322) 2021-05-21 13:38:07 -07:00
Azure SDK Bot
31c5e7cb72
Increment package version after release of azure-identity (#2323) 2021-05-21 13:37:58 -07:00
Azure SDK Bot
069f753464
Increment version for keyvault releases (#2324)
* Increment package version after release of azure-security-keyvault-common

* Increment package version after release of azure-security-keyvault-keys
2021-05-21 13:37:48 -07:00
Kan Tang
e5a589beec
Fix changelog (#2339)
# Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests).

- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
  - [x] PR is single purpose
  - [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [x] Any breaking changes?
2021-05-21 07:47:08 +00:00
Kan Tang
be29d332c2
Change ContentLength to FileSize. (#2338)
Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/2334

# Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests).

- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
  - [x] PR is single purpose
  - [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [x] Any breaking changes?
2021-05-21 07:08:23 +00:00
JinmingHu
ce30cca1cb
use size_t in storage sdk (#2320)
* use size_t instead of std::size_t

* use size_t for file write length

* fix build error

* fix build errors

* fix build error
2021-05-21 13:58:57 +08:00
JinmingHu
f2c0546386
Add explicit assignment and desctructor for RawResponse and RequestFailedException (#2312) 2021-05-21 09:44:34 +08:00
Daniel Jurek
26f43fd359
Narrow $packagePattern to exclude vcpkg.json files which are now part of the publishing process (#2330) 2021-05-20 17:19:18 -07:00
Azure SDK Bot
bb0d1287bc
Sync eng/common directory with azure-sdk-tools for PR 1615 (#2335)
* Move docindex.yml from steps -> jobs

* Add docindex.yml

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-05-20 17:20:46 -04:00
Azure SDK Bot
11a36c98f6
Increment version for storage releases (#2331)
* Increment package version after release of azure-storage-common

* Increment package version after release of azure-storage-blobs

* Increment package version after release of azure-storage-files-datalake

* Increment package version after release of azure-storage-files-shares
2021-05-20 11:59:38 +08:00
JinmingHu
d99fcbc9f8
mint storage beta 11 (#2326) 2021-05-20 09:23:39 +08:00
Anton Kolesnyk
dcb2506862
Docs: 'base 64' => Base64 (#2327)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-19 11:08:14 -07:00
JinmingHu
7b3f5d3c96
Changed type of CommitBlockCount to int32_t (#2318) 2021-05-18 23:36:13 -07:00
Ahson Khan
0a0bd6fbc2
Update changelog for the upcoming beta release. (#2309)
Holding off to do a review of the commits.

Area owners, please review yourself as well, and fix what might be missing or needs updating.
2021-05-19 04:31:36 +00:00
Ahson Khan
2a4dfd2f0d
Incorrect use of hashing Final/Append APIs now have an assert failure. (#2317)
Follow up from https://github.com/Azure/azure-sdk-for-cpp/pull/2189
2021-05-19 04:18:16 +00:00
Ahson Khan
75d17550f2
Add argument validation to public APIs. Throw or Precondition/assert failure? (#2189)
* Add argument validation to public APIs.

* Add exception to spell check.

* Revert "Add exception to spell check."

This reverts commit be54b614cc1427ddb2f154f5927f4e612a4a1e28.

* Turn invalid arg excetion to a precondition assert for bodystream read.

* User assert in more places within body_stream.

* Update valiation for hashing and bodystream and update tests.

* Update  precondition test for size_t and add null ptr check

* Fix clang formatting.

* Update changelog and fix up the message for size_t validation in hash.

* Address PR feedback.

* More PR feedback.

* Remove unnecessary comment from test.

* Fix clang format.
2021-05-18 20:10:14 -07:00
Anton Kolesnyk
e5763720d4
Vcpkg fixes (#2311)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-18 19:33:59 -07:00
Ahson Khan
65821ec115
Use size_t for buffers representing data in memory rather than int64_t. (#2285)
* Use size_t for buffers representing data in memory rather than int64_t.

* add a cast from size_t to int64_t

* Address feedback - OnRead return size_t.

* Change Read and ReadToCount to return size_t instead of int64_t.

* Update curl usage and ReadFromSocket.

* Missed one signature.

* Update changelog.

* Update transport layer to use the right size_t size.

* Fix curl use of MBS.

* Cast to size_t since that's all memory stream supprts.

* Add static casts to size_t as temporary workarounds.

* update storage tests.

* More test fixes.
2021-05-18 18:51:20 -07:00
Azure SDK Bot
d6d5120931
Sync eng/common directory with azure-sdk-tools for PR 1585 (#2308)
* Sparse checkout docs repository in release step

* Detect default branch for custom sparse checkout repository

* Use sparse checkout paths parameter in docs metadata release

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-05-18 19:43:29 -04:00
JinmingHu
9261e9ddae
copy constructor for RequestFailedException (#2291)
* copy constructor for RequestFailedException

* Apply suggestions from code review

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-05-18 22:58:11 +00:00
Ahson Khan
ff126f1eb7
Explore removing use of int within header files to align with guidelines. (#2276)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/2226

Trying to focus mainly on headers, depending on the conclusion, we'd want to make cpp file changes as well, but that can be done later.

Assuming this is the guideline we want:
https://azure.github.io/azure-sdk/cpp_implementation.html#integer-sizes

![image](https://user-images.githubusercontent.com/6527137/118341184-00d52580-b4d3-11eb-8e96-937cb5899c92.png)

Some places that we still use `int` is for things like unix file desriptor or where APIs like BIO_read from OpenSSL returns an int. Are those exceptions OK?
0b64ab3845/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp (L166)
308e5363ad/sdk/core/azure-core/src/base64.cpp (L87)
2021-05-18 20:49:53 +00:00
Anton Kolesnyk
898a8aee84
Remove Azure::Core::Diagnostics::Logger::Listener typedef (#2282) 2021-05-18 11:43:11 -07:00
JinmingHu
d8214af143
int -> int32_t (#2290) 2021-05-17 22:32:36 -07:00
Anton Kolesnyk
00dfcc2beb
Doxygen comment updates (#2280) 2021-05-17 17:05:06 -07:00
Rick Winter
8c5a885299
Documentation updates (#2277) 2021-05-17 23:59:47 +00:00
Victor Vazquez
e4a18b5eb3
Fault injection test (#2265)
* missing line for single docs

* format

* fault injection test

* winHttp

* storage blobs client with fault injector
2021-05-17 10:34:50 -07:00
JinmingHu
af936e052f
use AZURE_ASSERT in storage code (#2262)
* use AZURE_ASSERT in storage code

* fix build

* clang-format

* fix
2021-05-17 10:06:26 +08:00
Rick Winter
92839dcc56
A few spot fixes in docs (#2275) 2021-05-14 23:42:25 +00:00
Ahson Khan
0b64ab3845
Fix the casing of WinHttp and use WinHTTP (#2274)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/2260
2021-05-14 23:34:39 +00:00
Anton Kolesnyk
efe4772acb
Update upper/lower/other casing (#2267)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:54:16 -07:00
Anton Kolesnyk
00c47e8ec3
Delete vcpkg readme (#2268)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:53:59 -07:00
Azure SDK Bot
ea072fff4d
allow multiple invocations of archetype-sdk-tests-generate (#2269)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
2021-05-14 18:23:12 +00:00
JinmingHu
8cc98320d5
- BlobServiceClient::UndeleteBlobContainer doesn't support restoring a deleted container under a different name anymore. (#2263) 2021-05-14 09:31:49 +08:00
Victor Vazquez
f4febae12c
missing line for single docs (#2264)
* missing line for single docs

* format
2021-05-13 17:41:48 -07:00
Ahson Khan
743399eca4
Disable BlobServiceClientTest::UndeleteBlobContainer to keep CI and live tests green (#2259) 2021-05-12 13:40:34 -07:00
Ahson Khan
579a58b250
Fix typo in share_responses docs (#2258) 2021-05-12 19:26:13 +00:00
Azure SDK Bot
5d46edbe65
Sync eng/common directory with azure-sdk-tools for PR 1594 (#2243)
* Update sparse checkout create directory step name

* plumb BaseBranchName to create pull request

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-05-12 14:44:10 -04:00
Anton Kolesnyk
530e49b217
Document final/virtual destructor changes (#2256) 2021-05-12 11:38:17 -07:00
JinmingHu
b4fa6b835a
Fix stream leak issue (#2257)
* Fix stream leak issue

* cl
2021-05-12 09:05:03 +00:00
Ahson Khan
ffd0860e00
Avoid using WinHttpQueryDataAvailable, and use WinHttpReadData directly for better throughput. (#2245)
* Avoid using WinHttpQueryDataAvailable, and use WinHttpReadData directly for better throughput.

* Add back new line at end of file.

* Reorder some lines for readability.
2021-05-11 20:03:14 -07:00