* URL: avoid double slash at the start of the path
* Remove unnecessary change
* More test coverage
* Changelog
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Incapsulate all the defaults for options values such as authority host
in a helper class and add authority host url validation.
* Address PR feedback.
* Try to see what happens without coverage exclusions
* Reset coverage limits
* Mark ThrowParseError as [[noreturn]] to ensure compiler knows that code after it is dead code
* Added tests for the Azure assert macro
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in
libcurl.
* Revert unit test change that caused an intentional error.
* Remove the openssl header.
There are two significant parts to this fix. The first is that the Connection object now has a method EnableAsyncOperation which registers the connection with a background thread which polls the connection. The EnableAsyncOperation needs to be callable from outside the connection because in normal client operation, the calls to open the connection are all internal to uAMQP. That means that the message sender and receiver need to call it when they're opened (and closed).
The other major part of this change is that the AsyncOperationQueue now has a WaitForRequest API which does not normally poll (there is a test hook which enables polling but that is not normally used in most scenarios).
The other part of this change fixes some concurrency issues associated with the Log::Stream functionality.
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/src/logger.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/test/ut/CMakeLists.txt
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/test/ut/logging_test.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Added ASAN as an option, converted transports to be bases to ensure consistancy
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* bahavior -> behavior
* Update transport_adapter_base_test.hpp to fix the typo
* Update blob_base_test.hpp to fix the typo
* Update cspell.json to exclude bahavior is a valid word in the dictionary
---------
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
* Disable libcurl globalCleanUp test until it has been investigated
* Update curl_connection_pool_private.hpp friend class name for the disabled test
* Update curl_session_private.hpp friend class name for the disabled test
* doxygen fixes
* enable doxygen errors now that doxygen is updated.
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Switched management implementation to use message sender and receiver instead of uAMQP implementation.
* Made value conversion to AmqpValue explicit to work around what appears to be a gcc9 bug
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* pull request feedback
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Fixes#4696 - Added support to Log::Write to use insertion operators for logging
* EnvironmentLogger writes to stderr on errors, stdout for non-errors; Also don't double insert crlf in messages
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Standardized header ordering for C++ repo
* Reordered categories to move private headers above public headers; added space between categories to enable future flexibility
* add test helper
* constructible from Args
* restucture ClassTraits to ensure portability of static constexpr
* fix Etags tests and format
* clang format
* Minor tweak to event-processor.yml to trigger cspell checks
* Cosmetic change to context_test.cpp in azure-core to trigger CI pipelines
* Update cspell.json to include OIDC
* Fix potentially high CPU usage on Windows
* Undo unnecessary formatting
* Undo unnecessary changelog
* Undo unnecessary formatting
* Undo unnecessary formatting
* Uninclude locale
* Add issue link to changelog
* EXPECT_TRUE(a == b) => EXPECT_EQ(a, b)
* Update second changelog with link as well
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Tests: replace most `EXPECT_TRUE(a OP b)` with `EXPECT_OP(a, b)`
* Undo unnecessary change
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* FIrst cut at removing proxy tests
Changed the proxy tests from opt-out to opt-in so they're disabled by default. Removed lines enabling proxy from ci.yml file.
* Modify files by adding an extra space to trigger spell check on all.
* Modify newer files.
* Modify new files that got added.
* Modify all markdown files to trigger spell check on those.
* Fix spelling errors and update cspell to remove out-dated exceptions.
* Add back mypgrogram exception for the readme from azure-core.
* Revert test edits to markdown files.
* Revert test changes to source and header files.
* Remove modification to leftover source files.
* Added deprecated constructors for attestation service
* Disable deprecation warnings for clang; improved documentation to reflect deprecated functions
* Use doxygen @deprecated on deprecated functions
*
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Policies do not overwrite HTTP headers if they are already set
* Use static constant UserAgent
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add CI pipeline step and script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM
* Update platform-matrix.json to turn on CHECK_ASCII_CHARACTERS
* Fix missing comma in json.
* Update indentation in the ci.test.yml for the bash script
* Exclude the .github folder and test recording json files.
* Remove "recordings" exclusion since it doesn't exist anymore.
* Fixed UTF-8 with BOM and other non-ASCII character issues within the
files in the repo.
* Exclude nlohmann json tests from ASCII validation check.
* Log an intro to the CI console for the validation step.
* Remove codecoverage.cmake exclusion.
* Remove exclusion for docs and tools directories.
- Made Context immutable (including marking the static ApplicationContext as const
- Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
- Changed Az.Namespace value from being the package name to being the service name.
- Change test SpanExporter to fully capture exported values rather than keeping references to the values.
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>