Commit Graph

331 Commits

Author SHA1 Message Date
Anton Kolesnyk
24ecd16308
Fix some spelling errors (for some PRs that are currently in review) (#5202)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 10:49:58 -08:00
Anton Kolesnyk
fbf58139f7
Nullable::Emplace() to set HasValue() (#5178)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 08:10:52 +00:00
Anton Kolesnyk
ee4be19b3f
URL: avoid double slash at the start of the path (#5187)
* URL: avoid double slash at the start of the path

* Remove unnecessary change

* More test coverage

* Changelog

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-27 23:03:27 -08:00
Anton Kolesnyk
6da4d9649d
FIx typos (#5185)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-27 13:55:27 -08:00
Ahson Khan
f2bd22794d
Incapsulate all the defaults for options values such as authority host in a helper class and add authority host url validation. (#5155)
* Incapsulate all the defaults for options values such as authority host
in a helper class and add authority host url validation.

* Address PR feedback.
2023-11-11 05:00:14 +00:00
Anton Kolesnyk
50c18516df
Ensure CMakeLists don't miss any files (#5065)
* Ensure CMakeLists don't miss any files

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-10-26 18:15:03 -07:00
Larry Osterman
a6de66df02
Remove code coverage exclusions from Azure SDK for C++ (#5055)
* Try to see what happens without coverage exclusions

* Reset coverage limits

* Mark ThrowParseError as [[noreturn]] to ensure compiler knows that code after it is dead code

* Added tests for the Azure assert macro

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-10-25 10:30:02 -07:00
Ahson Khan
9a2c2e1257
Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in libcurl (#5009)
* Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in
libcurl.

* Revert unit test change that caused an intentional error.

* Remove the openssl header.
2023-10-05 20:30:46 +00:00
Phoebus Mak
bf652dcd47
Add support of setting CAPath and relevant test (#4982)
* Add support of setting CAPath and relevant test

* Renaming macro and update when will it get define
2023-09-29 09:32:47 -07:00
Larry Osterman
f561b97ddb
Disable dockerfile scanning in CI (#4967) 2023-09-19 16:53:34 -07:00
Larry Osterman
165eace629
AMQP Stack polls for operations in a background thread. (#4914)
There are two significant parts to this fix. The first is that the Connection object now has a method EnableAsyncOperation which registers the connection with a background thread which polls the connection. The EnableAsyncOperation needs to be callable from outside the connection because in normal client operation, the calls to open the connection are all internal to uAMQP. That means that the message sender and receiver need to call it when they're opened (and closed).

The other major part of this change is that the AsyncOperationQueue now has a WaitForRequest API which does not normally poll (there is a test hook which enables polling but that is not normally used in most scenarios).

The other part of this change fixes some concurrency issues associated with the Log::Stream functionality.

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/core/azure-core/src/logger.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/core/azure-core/test/ut/CMakeLists.txt

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/core/azure-core/test/ut/logging_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Added ASAN as an option, converted transports to be bases to ensure consistancy

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-09-13 11:12:46 -07:00
Richard Park
3e5af5508f
Readme spelling mistake: bahavior -> behavior (#4863)
* bahavior -> behavior

* Update transport_adapter_base_test.hpp to fix the typo

* Update blob_base_test.hpp to fix the typo

* Update cspell.json to exclude bahavior is a valid word in the dictionary

---------

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
2023-08-09 15:36:13 -07:00
Ahson Khan
c85e9bd11f
Disable libcurl globalCleanUp test until it has been investigated (#4797)
* Disable libcurl globalCleanUp test until it has been investigated

* Update curl_connection_pool_private.hpp friend class name for the disabled test

* Update curl_session_private.hpp friend class name for the disabled test
2023-07-17 16:04:11 -07:00
Ahson Khan
5ea89474e7
Verify that the nlohmann json library gracefully handles UTF-8 BOM at the start of the payload (#4775) 2023-07-13 11:46:18 -07:00
Rick Winter
b54d509c72
Use standard syntax for MIT license (#4786)
* Use standard syntax for MIT license

* Stop appending "All rights reserved"
2023-07-12 22:37:36 -07:00
Ahson Khan
cf1c01e089
Codifying the behavior of json.contains with nested properties, in the unit test. (#4763) 2023-07-10 11:48:09 -07:00
Larry Osterman
fba91e34c9
Enabled doxygen validation in CI pipeline. (#4715)
* doxygen fixes

* enable doxygen errors now that doxygen is updated.

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2023-06-22 18:26:07 -07:00
Larry Osterman
5a9106f2a5
Convert AMQP Management APIs to use MessageSender and MessageReceiver instead of uAMQP version. (#4706)
* Switched management implementation to use message sender and receiver instead of uAMQP implementation.

* Made value conversion to AmqpValue explicit to work around what appears to be a gcc9 bug

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* pull request feedback

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-06-12 13:57:54 -07:00
Rick Winter
fb1b439ddc
Remove a private internal method that is not used. (#4667) 2023-06-09 13:55:32 -07:00
George Arama
c45dff4c9f
Fix for the flaky curl test (#4670)
* Fix for the flaky curl test

* Larry's comment

* clang format applied

* updated comment

* clang-format-11 -i
2023-06-08 11:47:08 -07:00
Larry Osterman
9bc784050e
Moved logger back to cerr (#4702)
* Moved logger back to cerr

* Simplified stream logger experience; removed need for std::endl
2023-06-07 20:41:24 +00:00
Larry Osterman
0dd8882462
Add the ability to log diagnostics using an ostream. Fixes #4696 (#4700)
* Fixes #4696 - Added support to Log::Write to use insertion operators for logging

* EnvironmentLogger writes to stderr on errors, stdout for non-errors; Also don't double insert crlf in messages

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-06-06 22:20:20 +00:00
Ahson Khan
10c37ab035
Fix clang format issue with multiple gtest includes in etag_test due to (#4673)
merge conflict resolution.
2023-05-31 15:55:28 +08:00
Anton Kolesnyk
b4236bd0f3
Acknowledge community contribution in changelog (#4656)
* Acknowledge community contribution in changelog

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-05-30 11:41:37 -07:00
Larry Osterman
fb240a4b25
Define a standardized header ordering for Azure SDK for C++ (#4632)
* Standardized header ordering for C++ repo

* Reordered categories to move private headers above public headers; added space between categories to enable future flexibility
2023-05-26 14:32:45 -07:00
Jennifer Chukwu
5499eee608
added a test helper to test each type for having the expected default operations. (#4627)
* add test helper

* constructible from Args

* restucture ClassTraits to ensure portability of static constexpr

* fix Etags tests and format

* clang format
2023-05-25 23:03:12 -07:00
Ben Broderick Phillips
d4839e1a8e
Remove -Login and -PushImages parameters from stress helper (#4615) 2023-05-16 16:32:14 -04:00
Larry Osterman
2cce17d691
Added checks to help diagnose intermittent globalCleanUp test failure (#4593)
* Added checks to help diagnose intermittent globalCleanUp test failure
2023-04-28 11:13:02 -07:00
Ahson Khan
f166699120
Fixed the UUID generation logic so that the variant digit is RFC 4122 (#4554)
conforming.
2023-04-17 18:37:51 -07:00
Ahson Khan
1c15232a63
Update cspell.json to include OIDC to fix spell check error in event-processor.yml (#4544)
* Minor tweak to event-processor.yml to trigger cspell checks

* Cosmetic change to context_test.cpp in azure-core to trigger CI pipelines

* Update cspell.json to include OIDC
2023-04-11 15:55:01 -07:00
Larry Osterman
f318a00dcf
Transparent Uuid part 2. (#4540)
* Created transparent form of Azure::Core::Uuid

* clang-format

* clang-format

* Made constructor and operator std::array explicit

* Pull request feedback

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>

* Update sdk/core/azure-core/inc/azure/core/uuid.hpp

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>

* Renamed methods as per Anton's suggestion

* Renamed FromArray to CreateFromArray as per Ahson's suggestion

---------

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
2023-04-11 12:54:16 -07:00
Larry Osterman
99a17a8263
Created transparent form of Azure::Core::Uuid (#4534)
* Created transparent form of Azure::Core::Uuid

* Pull request feedback

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>

* Update sdk/core/azure-core/inc/azure/core/uuid.hpp

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>

---------

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
2023-04-11 01:03:37 +00:00
Anton Kolesnyk
93c3a62986
Remove duplicated comment (#4524)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-04-06 13:48:26 -07:00
Larry Osterman
b4be76fec8
Fixed AV in attestation tests (#4480)
* Fixed AV in attestation tests

* Fixed another test AV
2023-04-06 18:03:39 +00:00
Anton Kolesnyk
fd687c32fa
Add support for challenge-based and multi-tenant authentication (#4506)
* Add support for challenge-based and multi-tenant authentication

* Clang-format

* cspell

* clang-format

* gcc warning

* clang warning

* Remove debug message

* clang-format

* update version>= in vcpkg manifests

* unpublic copy ctor in polymorphic class

* KeyVault::_internal::ChallengeBasedAuthenticationPolicy => KeyVault::_internal::KeyVaultChallengeBasedAuthenticationPolicy

* keyvault/shared/challenge_based_authentication_policy.hpp => keyvault/shared/keyvault_challenge_based_authentication_policy.hpp

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-04-04 11:00:05 -07:00
Victor Vazquez
3d17447cce
update doctest lib to 2.4.11 (#4501) 2023-03-31 11:59:08 -07:00
Larry Osterman
6e810750be
First attempt at fixing nlohmann doctest compilation error (#4499)
* First attempt at fixing nlohmann doctest compilation error

* fixed compilation issue

* Fixed ApiView generation for azure core
2023-03-31 09:36:06 -07:00
Anton Kolesnyk
ba086576be
Fix potentially high CPU usage on Windows (#4448)
* Fix potentially high CPU usage on Windows

* Undo unnecessary formatting

* Undo unnecessary changelog

* Undo unnecessary formatting

* Undo unnecessary formatting

* Uninclude locale

* Add issue link to changelog

* EXPECT_TRUE(a == b) => EXPECT_EQ(a, b)

* Update second changelog with link as well

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-03-20 13:06:11 -07:00
Anton Kolesnyk
43632ebce8
Tests: replace most EXPECT_TRUE(a OP b) with EXPECT_OP(a, b) (#4457)
* Tests: replace most `EXPECT_TRUE(a OP b)` with `EXPECT_OP(a, b)`

* Undo unnecessary change

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-03-17 03:55:14 -07:00
George Arama
14677e92be
fix cspell for readme.ms in libcurl sterss test (#4441)
* fix cspell

* capitalize Valgrind and ubuntu

* sdada

* fix2
2023-03-16 11:03:09 -07:00
Anton Kolesnyk
ef24dfda2e
Add GetCredentialName() (#4428)
* Add GetCredentialName()

* Update

* Undo accidental change

* Clang-format

* Call GetCredentialName() instead of using constant; Return in-place constructed name; Explicit tests for GetCredentialName()

* PR feedback

* constructor parameter + non-virtual GetCredentialName()

* Update sdk/core/azure-core/CMakeLists.txt

* Update sdk/identity/azure-identity/test/ut/client_secret_credential_test.cpp

* Update sdk/identity/azure-identity/test/ut/client_certificate_credential_test.cpp

* GCC and Clang warnings

* Promote ThrowIfNotSafeCmdLineInput() to private member; avoid copies when calling GetCredentialName()

* Spelling

* Fix deprecated usage

* Fix iteration

* Clang-format

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-03-14 16:46:10 -07:00
Larry Osterman
d8f6aa9d27
First cut at removing proxy tests (#4416)
* FIrst cut at removing proxy tests

Changed the proxy tests from opt-out to opt-in so they're disabled by default. Removed lines enabling proxy from ci.yml file.
2023-03-07 23:46:25 +00:00
George Arama
9572608a5d
Docker comment (#4375)
* update comment

* add comment about vcpkg

* dsfs
2023-02-21 19:50:55 +00:00
George Arama
30afd1eb89
reworked docker file (#4344)
* reworked docker file

* removed unnecessary su

* update docker file

* qwq

* Update sdk/core/azure-core/test/libcurl-stress-test/Dockerfile

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

* url

---------

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
2023-02-17 11:40:54 -08:00
Ahson Khan
1abebf9661
Fix cspell flagged typos across the repo by triggering it on all files.
* Modify files by adding an extra space to trigger spell check on all.

* Modify newer files.

* Modify new files that got added.

* Modify all markdown files to trigger spell check on those.

* Fix spelling errors and update cspell to remove out-dated exceptions.

* Add back mypgrogram exception for the readme from azure-core.

* Revert test edits to markdown files.

* Revert test changes to source and header files.

* Remove modification to leftover source files.
2023-02-06 11:30:20 -08:00
Larry Osterman
5d6b6f72c1
Added deprecated constructors for attestation service (#4313)
* Added deprecated constructors for attestation service

* Disable deprecation warnings for clang; improved documentation to reflect deprecated functions

* Use doxygen @deprecated on deprecated functions

*
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-02-01 13:05:20 -08:00
Ahson Khan
696d138105
Move cspell exceptions in markdown file to metadata that isn't visible using html comment syntax (#4311) 2023-01-31 21:25:44 -08:00
Anton Kolesnyk
05040409d9
Policies do not overwrite HTTP headers if they are already set (#4303)
* Policies do not overwrite HTTP headers if they are already set

* Use static constant UserAgent

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-31 17:58:48 -08:00
Ahson Khan
876a7baaa5
Add CI pipeline step and script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM (#4134)
* Add CI pipeline step and script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM

* Update platform-matrix.json to turn on CHECK_ASCII_CHARACTERS

* Fix missing comma in json.

* Update indentation in the ci.test.yml for the bash script

* Exclude the .github folder and test recording json files.

* Remove "recordings" exclusion since it doesn't exist anymore.

* Fixed UTF-8 with BOM and other non-ASCII character issues within the
files in the repo.

* Exclude nlohmann json tests from ASCII validation check.

* Log an intro to the CI console for the validation step.

* Remove codecoverage.cmake exclusion.

* Remove exclusion for docs and tools directories.
2023-01-25 17:33:26 -08:00
Larry Osterman
f757bb06e7
Clean up tracing logic - prepare for new tracing functionality. (#4263)
- Made Context immutable (including marking the static ApplicationContext as const
- Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
- Changed Az.Namespace value from being the package name to being the service name.
- Change test SpanExporter to fully capture exported values rather than keeping references to the values.


Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-01-25 19:07:25 +00:00