Commit Graph

852 Commits

Author SHA1 Message Date
Ahson Khan
0dfe2f498d
Throw a logic error when calling Rewind on unsupported BodyStreams and update the exception message to be actionable. (#1713)
* Throw a runtime error when calling Rewind on unsupported BodyStreams and update the exception message.

* Add rewind test for bodystream.

* Change exception type from runtime to logic.

* Add necessary platform specific headers.
2021-02-22 12:26:51 -08:00
Ahson Khan
97b0ccf79b
Make sure to rewind the body stream at the start of each request retry attempt. (#1712)
* Make sure to rewind the body stream at the start of each request retry attempt.

* Add change log entry

* Add request start try unit test
2021-02-22 12:18:34 -08:00
Rick Winter
50efbdb4c0
Add holder for registry handle to ensure cleanup of native resources. (#1711)
Add a holder for the registry key to ensure it is always cleaned up when it goes out of scope.
Exceptions should be caught as const.
2021-02-22 17:48:28 +00:00
JinmingHu
249327a3fa
Refactor pipeline building logic, add support for customized application id and API version (#1703)
* refactor pipeline build code

* Changelog

* fix build error

* fix bug

* fix ut

* changelog
2021-02-20 09:13:20 +08:00
Azure SDK Bot
b8af41f79a
Update pipeline generator version to include weekly convention name fix (#1710)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-02-19 15:27:28 -08:00
Azure SDK Bot
5a1fedd0d5
Sync eng/common directory with azure-sdk-tools for PR 1429 (#1705)
* Add job matrix generation scripts

* Add working job matrix example pipeline and common matrix generation pipeline.

* Update job matrix tests path

* Parameterize matrix generation job path

* Add global variable to override nuget security checks to sample matrix pipeline

* Update readme matrix pipeline example to match sample file

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-02-19 14:45:31 -08:00
Azure SDK Bot
5e97c8f67f
Sync eng/common directory with azure-sdk-tools for PR 1425 (#1698)
* Trim off the target branch

* Update eng/common/scripts/get-markdown-files-from-changed-files.ps1

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Update get-markdown-files-from-changed-files.ps1

* Update get-markdown-files-from-changed-files.ps1

* Trim the slash

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-19 12:02:01 -08:00
Azure SDK Bot
6e4306dc93
Only run eng/common check when target branch is master (#1688)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-19 11:06:36 -08:00
JinmingHu
5c2d0fba17
remove unused stuff (#1701) 2021-02-19 14:53:04 +08:00
Anton Kolesnyk
bf347d24c2
Disable compiler extensions, fix Clang options to have effect, fix warnings (#1615)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-02-18 19:15:11 -08:00
Victor Vazquez
e9cf40505b
Performance projects for services (#1655)
* add test metadata to the tests for the perf fw
2021-02-18 21:05:22 +00:00
Azure SDK Bot
ebe169bc96
Sync eng/common directory with azure-sdk-tools for PR 1396 (#1695)
* Change other version to all versions

* Exclude the packages which already show up in latest GA and preview

* Update main.js

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
2021-02-18 11:55:16 -08:00
Victor Vazquez
cea5e03a17
Keyvault adding delete key (#1675)
Adding delete key operation
2021-02-18 09:36:13 +00:00
Victor Vazquez
5f523f7030
update noRevoke (#1678)
* update noRevoke

* use EnableCertificateRevocationListCheck instead of Disable
2021-02-18 02:16:22 +00:00
Anton Kolesnyk
bc83b64098
Remove copyright headers from produced VcPkg port files (#1682)
* Remove copyright headers from produced VcPkg port files

* PR feedback

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-02-16 13:56:07 -08:00
Azure SDK Bot
f929894274
Sync eng/common directory with azure-sdk-tools for PR 1374 (#1686)
* Create package property file using artifact name

* Add option to pass config file dir

* Set default config file directory to avoid script execution failure

Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
2021-02-16 11:57:56 -08:00
Mitch Denny
b68a20e3d2
Re-enable agent OS verification (#1624)
* Re-enable agent OS verification
2021-02-16 15:53:56 +11:00
Azure SDK Bot
74bfafcb52
Sync eng/common directory with azure-sdk-tools for PR 1371 (#1634)
* Rework verify agent OS step.

* Address feedback

* Justing string matching instead.

* ! instead of -not

Co-authored-by: Mitch Denny <midenn@microsoft.com>
2021-02-14 15:56:25 -08:00
Azure SDK Bot
ab0a92ce62
Sync eng/common directory with azure-sdk-tools for PR 1408 (#1683)
* Improve TestResources docs and logging

Resolves #1388
Resolves #1407

Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.

* Add ADP test sub to look-up

Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-02-12 19:08:11 -08:00
Victor Vazquez
b41c53509b
Update GetString to ToString (#1677)
* Update GetString to ToString
2021-02-12 22:25:01 +00:00
Azure SDK Bot
d76cdf4c6d
Allow logging into specific subscription (#1681)
Resolves #1404

Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-02-12 12:29:16 -08:00
Azure SDK Bot
65453834ae
Update eng-common-workflow-enforcer (#1674)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-12 11:40:11 -08:00
Azure SDK Bot
87210648ff
Increment version for storage releases (#1673)
* Increment package version after release of azure-storage-common

* Increment package version after release of azure-storage-blobs

* Increment package version after release of azure-storage-files-datalake

* Increment package version after release of azure-storage-files-shares
2021-02-12 13:37:00 +08:00
Azure SDK Bot
9e0494674f
Change script parameters to boolean (#1672)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-11 13:43:16 -08:00
Azure SDK Bot
e99c6df201
Enable passing devops pat for work item scripts (#1670)
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
2021-02-11 11:12:18 -08:00
Azure SDK Bot
3282a05d49
Sync eng/common directory with azure-sdk-tools for PR 1358 (#1669)
* Extend Get-GitHubPullRequest to return only files

* Add check to prevent eng/common changes that are not proper syncs

* Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-11 10:12:13 -08:00
Victor Vazquez
a02d8a2693
Moving HttpPipeline to Internal layer (#1642)
Partial work from #1342 

Moving the Http Pipeline to the internal layer.

The HTTP pipeline is yet exposed through the Storage protocol layer headers which only use it from its Details namespace but still expose it. Fixing that would require re-doing its protocol layer, which is not ideal, so the expectation is to just leave it as Internal to be enough to be considered as non-for-end-users
2021-02-11 02:43:58 +00:00
Azure SDK Bot
2741ad4762
Sync eng/common directory with azure-sdk-tools for PR 1303 (#1667)
* Add PrepareRelease Script

* Update Package-Properties.ps1

* Update Collect-ChangeLog Script

* Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1

* Update GeneralReleaseNotesParser.ps1 script

* Change GeneralReleaseNotesParser logic

* Change GeneralReleaseNotesParser.ps1 logic

* Remoce GeneralReleaseNotesParsercopy

* Update collect changelog and generalreleasenotes parser logic

* Refine CollectChangelog Logic

* Add logic for filtering collected changelog

* Add Filter-ReleaseHighlights function

* Update General ReleasNotes Logic

* Delete GeneralReleaseNotesLogic.ps1

* Update Collect ChangeLogLogic

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-02-10 18:43:01 -08:00
Victor Vazquez
e423265180
Make keyvault to expose telemetry options (#1661)
fixes: #1566
2021-02-11 02:16:54 +00:00
Victor Vazquez
e141ad6de4
update context paramenter for keyvault APIs (#1663)
* update context paramenter for keyvault APIs

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2021-02-10 17:53:17 -08:00
Ahson Khan
8f75082fd6
Remove the TransportKind enum from the SDK since it is not used. (#1653)
* Remove the TransportKind enum from the SDK since it is not used.

* Add a CL entry.
2021-02-10 13:42:01 -08:00
Azure SDK Bot
66e66aa83b
Sync eng/common directory with azure-sdk-tools for PR 1393 (#1666)
* Hide the package which set to true instead of putting to Other page

* Hide the package not showing in csv

* Added logging message

* fix the variable

* leave an extra space

* Update eng/common/docgeneration/Generate-DocIndex.ps1

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-10 13:36:40 -08:00
Ahson Khan
9015bfe399
Address implementation level feedback for Md5Hash and delete ctors. (#1647)
* Address implementation level feedback for Md5Hash and delete ctors.

* Address docs feedback.

* Address PR feedback

* Move the copy ctor deletion from Md5Hash to the base class.

* Remove re-assignment of Crc64Hash in tests.
2021-02-10 12:09:40 -08:00
Rick Winter
fcd64f7bd2
Split RequestConditions into MatchCondtions and ModifiedConditions (#1644)
* Split the inheritance on the RequestConditions
Rename RequestConditions to ModifiedConditions
2021-02-10 11:24:15 -08:00
Ahson Khan
9edae4f792
Add Operation<T>, OperationStatus, Exception, and Platform headers to (#1659)
the simplified core header.
2021-02-10 11:06:26 -08:00
JinmingHu
572208baac
update release date (#1660) 2021-02-10 17:49:29 +08:00
JinmingHu
66ce129f80
move context out of options bag (#1658)
* move context out of options bag for blob service

* Changelog

* fix build warnings

* datalake

* file service

* small bug fix, I'll just put it in this PR hopefully no one will ever find out
2021-02-10 17:48:07 +08:00
Azure SDK Bot
c478f175ed
Increment package version after release of azure-core (#1657) 2021-02-10 00:17:04 -08:00
Ahson Khan
b40603dc40
Renamed Crc64 to Crc64Hash and change it to derive from the Azure::Core::Cryptography::Hash class. (#1646)
* Renamed `Crc64` to `Crc64Hash` and change it to derive from the `Azure::Core::Cryptography::Hash` class.

* Add default dtor
2021-02-09 22:06:11 -08:00
Daniel Jurek
2d4d766c6d
Publishing automation for vcpkg x-add-version (#1649)
* Add azure-template2 to validate publishing multiple packages to vcpkg

* Update versions to avoid release conflict

* Add custom port naming logic

* fix changelogs

* compute path

* Add azure-core-cpp dependency back in

* package name in control file

* Add changes to support vcpkg x-add-version

* Add azure-sdk identity to commit

* Remove old conditions/comments and use -am for commit

* remove -c parameters

* Use --author

* git config local

* space

* work around HasChanges=false

* Bump versions for verification

* Bump versions, update portfile to use azure-template2-cpp ref

* Add PackageVersion

* Revert template2

* Finish reverting template2

* Revert "Finish reverting template2"

This reverts commit aa1461facbdb7ebd1e0ad2d90f8fe5a7c9db9473.

* Revert "Revert template2"

This reverts commit 3a91e82e01e2d1610da0747c2c84e24f52105625.

* Commit without setting user.name and user.email

* bump version

* git commands on same line

* Revert "Revert "Revert template2""

This reverts commit 1721a626e3c2e2b8c43dfe4a2fedf5a891c58793.

* Revert "Revert "Finish reverting template2""

This reverts commit 461a57c14aee97c9b6f83c79fe3a74122c890fb2.

* Finish reverting template2
2021-02-09 14:56:00 -08:00
Ahson Khan
cda5d62b83
Add details to the Azure Core beta 6 changelog (#1645)
Reviewed the commits since the last release: 9b7849c155...3e543f9a73
2021-02-09 19:44:41 +00:00
Victor Vazquez
3e543f9a73
changelog (#1635) 2021-02-09 10:39:55 -08:00
Anton Kolesnyk
84ffcd7168
Simplify logging (#1568)
Closes #1180.
2021-02-09 04:37:08 +00:00
Ahson Khan
5359e2793a
Remove Storage::Md5 and replace it with the one from Azure::Core. (#1618)
* Add MD5 hashing APIs to Azure::Core available from azure/core/md5.hpp.

* Add simplified header test for md5 and base64.

* Add changelog entry.

* Remove unnecessary include.

* Remove Storage::Md5 and replace it with the one from Azure::Core.

* Fix clang formatting.

* Add required cstdint include directive.

* Update storage based on recent changes to Md5 hash APIs.
2021-02-08 20:04:25 -08:00
Kan Tang
306913ff1b
Refined DataLake APIs (#1627) 2021-02-09 10:58:11 +08:00
Kan Tang
19ea155f45
Refined File service. (#1629) 2021-02-09 10:57:55 +08:00
Ahson Khan
b3497f8c16
Add a Hash base class to Azure::Core and redesign Md5 to derive from it. (#1632)
* Add MD5 hashing APIs to Azure::Core available from azure/core/md5.hpp.

* Add simplified header test for md5 and base64.

* Add changelog entry.

* Remove unnecessary include.

* Address feedback - add back ptr, length APIs.

* Address PR feedback - docs and typo fixes.

* Add a Hash base class and redesign Md5 to derive from it.

* Add test for call to final on empty instance.

* Remove old file which got renamed to hash.hpp.

* Remove md5.hpp file references.

* Address PR feedback - move to crypto, remove virtual, and misc.
2021-02-08 18:31:12 -08:00
Victor Vazquez
1f849ec384
fix docs (#1633) 2021-02-08 17:13:30 -08:00
Ahson Khan
4d3ecf39e7
Use the port defined in the URL when setting up the transport adapter usage. (#1611)
* Use the port defined in the URL when setting up the transport adapter usage.

* Fix typo when getting the request object.
2021-02-08 16:51:27 -08:00
Ahson Khan
568d4bcc4e
Add MD5 hashing APIs to Azure::Core available from azure/core/md5.hpp. (#1617)
* Add MD5 hashing APIs to Azure::Core available from azure/core/md5.hpp.

* Add simplified header test for md5 and base64.

* Add changelog entry.

* Remove unnecessary include.

* Address feedback - add back ptr, length APIs.

* Address PR feedback - docs and typo fixes.
2021-02-08 15:34:41 -08:00