github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

update context paramenter for keyvault APIs (#1663)

Browse Source 
* update context paramenter for keyvault APIs

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
This commit is contained in:
Victor Vazquez 2021-02-10 17:53:17 -08:00 committed by GitHub
parent 8f75082fd6
commit e141ad6de4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client.hpp
View File

@ -72,14 +72,16 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
*
* @param name The name of the key.
* @param options Optional parameters for this operation.
* @param context The context for the operation can be used for request cancellation.
* @return The Key wrapped in the Response.
*/
Azure::Core::Response<KeyVaultKey> GetKey(
std::string const& name,
GetKeyOptions const& options = GetKeyOptions()) const
GetKeyOptions const& options = GetKeyOptions(),
Azure::Core::Context const& context = Azure::Core::Context()) const
{
return m_pipeline->SendRequest<KeyVaultKey>(
options.Context,
context,
Azure::Core::Http::HttpMethod::Get,
[name](Azure::Core::Http::RawResponse const& rawResponse) {
return Details::KeyVaultKeyDeserialize(name, rawResponse);
@ -96,15 +98,17 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
* @param keyType The type of key to create. See #Azure::Security::KeyVault::Keys::KeyTypeEnum.
* @param options Optional parameters for this operation. See
* #Azure::Security::KeyVault::Keys::CreateKeyOptions.
* @param context The context for the operation can be used for request cancellation.
* @return The Key wrapped in the Response.
*/
Azure::Core::Response<KeyVaultKey> CreateKey(
std::string const& name,
KeyTypeEnum keyType,
CreateKeyOptions const& options = CreateKeyOptions()) const
CreateKeyOptions const& options = CreateKeyOptions(),
Azure::Core::Context const& context = Azure::Core::Context()) const
{
return m_pipeline->SendRequest<KeyVaultKey>(
options.Context,
context,
Azure::Core::Http::HttpMethod::Post,
Details::KeyRequestParameters(keyType, options),
[name](Azure::Core::Http::RawResponse const& rawResponse) {
@ -113,5 +117,4 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
{Details::KeysPath, name, "create"});
}
};
}}}} // namespace Azure::Security::KeyVault::Keys

5
sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_create_options.hpp
View File

@ -22,11 +22,6 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
struct CreateKeyOptions
{
/**
* @brief Context for cancelling long running operations.
*/
Azure::Core::Context Context;
std::list<KeyOperation> KeyOperations;
Azure::Core::Nullable<Azure::Core::DateTime> NotBefore;