- Remove BuildType parameter as we can default it from package properties
- Stop passing BuildType and GroupId and instead defaul them from package properties
- Enable StrictMode to help identify potential errors
- Start passing sdktype and isnewsdk properties to devops script
- Sync latest changes with devops work item to fix a couple bugs
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Add CaseInsensitiveMap<T>
* Drop unneccessary namespace qualification
* Comment working: more accurate description
* GCC and Clang fix (typename specification) + doxy comments for template parameters
* Remove Allocator template parameter - we can add it later if we need it, currently no need to commit to having it there
* Drop <T> template parameter. We can add it later with default value of std::string without breaking change
* Unit test
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Things left to do (out-of-scope for this PR):
- Add FAQ section for common errors and potential solutions when trying to build via vcpkg
- Structure the doc with the following groups, if there is not a lot of overlap:
- Windows
- Visual Studio
- VS Code
- Command Line
- Linux/Posix/Mac
- VS Code
- Command Line
- Another dimension is `Vcpkg` vs `fetch content from GitHub` vs `build the SDK from source`.
* Defend public headers against inclusion of Windows.h
... which defines some nasty function-like macros `min` and `max` when `_NOMINMAX` isn't defined. We prevent expansion as a function-like macro by inserting some token(s) between `min`/`max` and the following `(`. Most commonly that means wrapping the entire qualified-name in `()` a la `(std::min)(x, y)`, but an explicit template argument list (`std::min<int>(x, y)`) works as well.
* clang-format all the things
* Test coverage
I assume that the `azure-meow-common` headers are fully covered by the tests for the `azure-meow-woof` SDKs.
* Get static/dynamic CRT link options in sync
* Update docs
* PR feedback
* en-us
* Another 'en-us' in a link
* MSVC_USE_STATIC_CRT
* Update README.md
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add common tools for spell check
* Updates from further iteration
* Review feedback: Add check for git as well
* Review feedback * Use common approach to resolving base branch name * Eliminate default base branch "master" as this will be changed later, providing no default and using a mandatory parameter means a dev must provide the value * Check for existence of $CspellConfigPath * No need to Set-Location if run from the root of the repo (most common scenario) * -join
* Review feedback: Rename TargetRef -> TargetBranch, add SourceBranch, Add reference to spelling docs, exit 0, Rename to check-spelling-in-changed-files.ps1,
* Review feedback: Remove ValidateNotNullOrEmpty (we do more definitive validation farther down that will also catch these errors), Update comments and script name
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Throw a runtime error when calling Rewind on unsupported BodyStreams and update the exception message.
* Add rewind test for bodystream.
* Change exception type from runtime to logic.
* Add necessary platform specific headers.
* Change other version to all versions
* Exclude the packages which already show up in latest GA and preview
* Update main.js
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* Create package property file using artifact name
* Add option to pass config file dir
* Set default config file directory to avoid script execution failure
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Improve TestResources docs and logging
Resolves#1388Resolves#1407
Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.
* Add ADP test sub to look-up
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
Partial work from #1342
Moving the Http Pipeline to the internal layer.
The HTTP pipeline is yet exposed through the Storage protocol layer headers which only use it from its Details namespace but still expose it. Fixing that would require re-doing its protocol layer, which is not ideal, so the expectation is to just leave it as Internal to be enough to be considered as non-for-end-users
* Hide the package which set to true instead of putting to Other page
* Hide the package not showing in csv
* Added logging message
* fix the variable
* leave an extra space
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Address implementation level feedback for Md5Hash and delete ctors.
* Address docs feedback.
* Address PR feedback
* Move the copy ctor deletion from Md5Hash to the base class.
* Remove re-assignment of Crc64Hash in tests.
