weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
4,958 Commits 45 Branches 0 Tags 96 MiB
efdb73b446
Commit Graph

2081 Commits

Author SHA1 Message Date
joshvanl
efdb73b446 Adds ObservedGeneration int64 field to Certificate Conditions 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-04 17:03:26 +00:00
jetstack-bot
28fc97699e
Merge pull request #3692 from irbekrm/3666_tests_for_readiness_controller 
unit tests for readiness controller
 2021-03-04 10:41:17 +00:00
irbekrm
17b7749621 Add extra test case + better naming and comments 
joshvanl <vleeuwenjoshua@gmail.com>

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-03-03 18:39:01 +00:00
jetstack-bot
4a99b15f5a
Merge pull request #3710 from johejo/fix_build_on_go116 
Fix build on go1.16
 2021-03-02 11:20:43 +00:00
jetstack-bot
a9c672e900
Merge pull request #3699 from maelvls/ocsp-unit-test 
Add unit tests around the new ocspServers field
 2021-03-01 19:12:49 +00:00
Maël Valais
e7b3e6c4e5 PR comment: no more "return" in test code 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
 2021-03-01 14:12:02 +01:00
Mitsuo Heijo
ffa79f6b8d
Fix build on go1.16 
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
 2021-02-26 22:47:56 +09:00
irbekrm
ff2e2f6d87 Fixes typo + runs ./hack/update-all.sh 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-25 10:05:08 +00:00
irbekrm
9ac9a6039c Adds unit tests for readiness controller 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-25 09:45:55 +00:00
irbekrm
5dc63bb2e6 Refactor readiness controller for easier testing 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-25 09:45:04 +00:00
irbekrm
9a306e73e1 Move certificate test util functions to common location so they can be reused 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-25 09:40:50 +00:00
irbekrm
ad53be3138 Small refactor around policies 
Make reason values constants, rename some functions for clarity

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-25 09:38:17 +00:00
Maël Valais
dc4f0a34e9 PR comment: compare time.Time instead of strings 
Also removed the unused "givenNamespace"

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
 2021-02-25 10:28:56 +01:00
Maël Valais
e50f26fc97 PR comment: fix notAfter test case using time.Truncate 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
 2021-02-24 15:07:54 +01:00
Maël Valais
c9dcae2313 ocspServers field: add unit test 
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-02-24 11:05:59 +01:00
Lars Lehtonen
0270377f6c
pkg/controller/certificaterequests/acme: fix dropped test error 
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
 2021-02-23 18:13:37 -08:00
irbekrm
b852e97ffb Removes the deprecated renew-before-expiry flag 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-21 10:22:25 +00:00
irbekrm
959e581368 Removes implementation-specific comment from api 
Co-authored-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-10 13:29:05 +00:00
irbekrm
59f52139dc Finishes sentences with a full stop 
Co-authored-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-10 09:43:34 +00:00
irbekrm
863c709a19 Removes minimum and maximum fields from Certificate CRD 
This was done to fix Helm data type conversion problem- see issue #3644 for more context

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-09 17:08:29 +00:00
jetstack-bot
35febb1717
Merge pull request #3505 from hugoboos/ocsp-server 
Add option to specify OCSP server #3497
 2021-02-05 11:27:37 +00:00
Maël Valais
95f8410194 remove the unit test, see reason in the commit message 
The reason I had to withdraw from writing this unit test is that the
ca.CA type in pkg/issuer/ca does not implement the Sign function, which
means I cannot test the Sign feature.

I then tried to implement the same unit test to
pkg/controller/certificaterequests/ca, but the existing unit test do not
check the fields inside the produced certificate, which means I cannot
ensure that the ocspServers fields has properly been applied to the
certificate.

I will write a proper unit test... a bit later.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
 2021-02-05 10:21:27 +01:00
Maël Valais
11b9d71708 ca issuer: add a unit test with the ocsp servers field 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
 2021-02-05 10:20:55 +01:00
joshvanl
15536801f0 Revert ingress key usage annotation to default the same as Certificate 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-02-04 16:08:30 +00:00
Maartje Eyskens
577c039220 Implement feedback 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-02-04 15:11:00 +00:00
Maartje Eyskens
bfce24fd59 Fix sync tests 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-02-04 15:11:00 +00:00
Maartje Eyskens
8ec816814f update bazel 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-02-04 15:11:00 +00:00
Maartje Eyskens
bbb75ee52f Allow ingress-shim to specify key usages + add server-auth to default 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-02-04 15:11:00 +00:00
jetstack-bot
4fe609156b
Merge pull request #3538 from chulkilee/patch-1 
Fix comments for docs on types_certificate.go
 2021-02-03 15:09:11 +00:00
Maël Valais
ba22785445 Rename ocspServer to oscpServers 
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
 2021-02-03 11:13:32 +01:00
Maël Valais
d5c485970d issuer's ocsp server: add an example URL to the API 
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-02-03 09:42:34 +01:00
Maël Valais
9fb0876d21 issuer's ocsp server: add validation of the URL 
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-02-03 09:42:01 +01:00
Hugo Stijns
5f18cce622 add option to specify OCSP server 
Signed-off-by: Hugo Stijns <hugo@boosboos.net>
Signed-off-by: Maël Valais <mael@vls.dev>
 2021-02-03 09:09:03 +01:00
irbekrm
be5ba022a9 Improves error checking in TestSync function 
Also corrects some expected error values in test cases

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-02 11:23:42 +00:00
irbekrm
bb99260365 Skips an invalid Ingress.spec.tls entry instead of invalidating the whole Ingress 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-01 19:32:36 +00:00
Maartje Eyskens
33f1881190
Merge pull request #3532 from meyskens/recursive-cname 
Make CNAME resolver recursive
 2021-01-27 16:28:40 +01:00
jetstack-bot
26afeceb2b
Merge pull request #3457 from meyskens/inspect-secret 
Add `inspect secret` command
 2021-01-22 16:19:03 +01:00
Maartje Eyskens
e081410d29 rename a function call 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-22 16:00:34 +01:00
Maartje Eyskens
d4f2934609 actually rename function 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-22 15:54:30 +01:00
Maartje Eyskens
910cba9538
Update pkg/issuer/acme/dns/util/wait.go 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>

Co-authored-by: Maël Valais <mael@vls.dev>
 2021-01-22 15:46:06 +01:00
Chulki Lee
e90b494da6 Fix go comments for API docs 
- Use backticks, not single/double quotes for enum values
- Fix allowed values
- Remove unnecessary quote

Signed-off-by: Chulki Lee <chulki.lee@gmail.com>
 2021-01-22 20:21:19 +09:00
Maartje Eyskens
d0b13b6c8a Update code structure of cname following 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-20 17:11:40 +01:00
Maartje Eyskens
f9d34991bc Revert one too many rename 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-20 17:10:52 +01:00
Maartje Eyskens
7591304af8 update fn name 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-20 17:08:35 +01:00
Maartje Eyskens
985c8b6e30
Apply suggestions from code review 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>

Co-authored-by: Maël Valais <mael@vls.dev>
 2021-01-20 17:05:45 +01:00
Richard Wall
50a388a8a1 Fix unit tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-01-20 14:26:43 +00:00
Richard Wall
95d26b7c60 Extract the CA from Venafi response 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-01-20 14:14:48 +00:00
jetstack-bot
89cff72df2
Merge pull request #3552 from mt-inside/clarify-cert-ref-namespace 
Minor log message clarification
 2021-01-15 11:54:55 +01:00
Maartje Eyskens
be205c04e6 Run a codegen update 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-08 15:05:32 +01:00
Matt Turner
44f69ce015 Minor log message clarification 
Supplying just a name, rather than a namespace/name, for a cainjector
source reference, results in the generic error message "invalid
certificate name". This condition is detected on its own branch so we
can be more specific.

Signed-off-by: Matt Turner <matturner@gmail.com>
 2021-01-07 19:21:11 +00:00