Commit Graph

5909 Commits

Author SHA1 Message Date
jetstack-bot
be8079b504
Merge pull request #4293 from maelvls/fix-nil-pointer
Nil pointer exception: certificateRef and TLS can now be left empty
2021-08-03 16:04:49 +01:00
Maël Valais
30af205777 nil pointer: the Gateway API is full of pointers
Signed-off-by: Maël Valais <mael@vls.dev>
2021-08-03 15:43:16 +02:00
jetstack-bot
56b1374b41
Merge pull request #4161 from irbekrm/update_makefile
Update makefile
2021-08-03 14:10:40 +01:00
irbekrm
03e6002e1f Create a single variable for Bazel image flags.
Signed-off-by: irbekrm <irbekrm@gmail.com>

Co-authored-by: Ashley Davis <ashley.davis@jetstack.io>
2021-08-03 13:31:05 +01:00
jetstack-bot
d0f4c82baf
Merge pull request #4226 from inteon/simple_kubectl_check_version
add 'kubectl cert-manager version'
2021-08-03 12:36:19 +01:00
jetstack-bot
c333ace179
Merge pull request #4072 from Marfeel/master
Add a name to Prometheus scraping service port for Istio compatibillity
2021-08-03 11:43:19 +01:00
Fran Sanjuán
21bbdaced6 Set fixed port name
Signed-off-by: Fran Sanjuán <francesc.sanjuan@marfeel.com>
2021-08-03 11:55:38 +02:00
jetstack-bot
61081709e4
Merge pull request #3828 from jonathansp/master
feat: add support to secretTemplates
2021-08-03 10:53:20 +01:00
Jonathan Prates
50bb91a032 feat: update object description explaning the current behaviour
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 09:26:23 +01:00
Jonathan Prates
aed1d7137e feat: add validation to block annotations containing cert-manager.io/ prefix
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
12363f91e2 fix: move secretTemplate validations to validation package
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
6e8f74b4f8 tests: add Labels map to the expected secret
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
e1034c219e feat: add validation for annotations and labels
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
c5e81b13f6 fix: labels cannot be shown if no labels were changed
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
d8be463426 fix: update autogenerated converison code
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
811069cac7 fix: do not create secret labels if template is empty
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
9f36f8984b feat: copy SecretTemplate api to v1alpha2 v1alpha3 and v1beta1
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
1f87c098a1 fix: update autogenerated code
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
0569997ede feat: update crds
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
ababc24670 fix: add SetCertificateSecretTemplate function comment
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Simon Prates
91cecb65e1 fix: add optional annotation to secretTemplate field
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
Co-authored-by: Josh Van Leeuwen <joshua.vanleeuwen@jetstack.io>
2021-08-03 01:19:11 +01:00
Jonathan Simon Prates
82f1828857 fix: typo in function's comment
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
d29e89c948 chore: update function documentation and fix typo
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
936ad33539 fix: ensure secret annotations and labels will be copied if updated in the cert
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Jonathan Prates
47bc03e7c4 feat: add support to secretTemplates
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
jetstack-bot
94d854c525
Merge pull request #4244 from RinkiyaKeDad/new_featureset
adding a new feature set for Public ACME servers
2021-08-02 12:57:06 +01:00
Arsh Sharma
89bf0022d6 changes from pair programming sesh
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
2021-08-02 16:22:51 +05:30
jetstack-bot
52e505a1ef
Merge pull request #4283 from irbekrm/bump_base_images
Bump base image versions
2021-07-30 17:28:49 +01:00
Inteon
85710579dd
Apply suggestions from code review
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-30 17:00:27 +02:00
jetstack-bot
b04e42c437
Merge pull request #4253 from JoshVanL/apiextensions-v1beta1-v1
Conversion: Apiextensions v1beta1 -> v1
2021-07-30 15:49:49 +01:00
jetstack-bot
edf76f14cf
Merge pull request #4282 from JoshVanL/kube-kind-digest-v1.22.0-rc.0
Updates the kind cluster for v1.22 to v1.22.0-rc.0
2021-07-30 14:40:15 +01:00
Arsh Sharma
58410f5deb added comment for skip
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
2021-07-30 18:21:58 +05:30
irbekrm
439d664e86 Bump base image versions
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-07-30 12:52:05 +01:00
Arsh Sharma
8ce7ca8d63 testing: seeing if skip option fixes the failing tests
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
2021-07-30 17:00:56 +05:30
joshvanl
d3f3f458ed Updates the kind cluster for v1.22 to v1.22.0-rc.0
https://console.cloud.google.com/gcr/images/jetstack-build-infra-images/EU/kind@sha256:fa600aa4b8234235e141fab085126e2a72c3d8f05eed44d38bf343091c51d192/details?tab=info

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-30 12:06:22 +01:00
jetstack-bot
5543772de0
Merge pull request #4254 from JoshVanL/admission-v1beta1-v1
Remove v1beta1 from admission review
2021-07-30 10:57:54 +01:00
jetstack-bot
25320ceaa8
Merge pull request #4252 from JoshVanL/admissionregistration-v1beta1-v1
Change admissionregistration.k8s.io v1beta1 to v1 in integration tests
2021-07-29 20:44:41 +01:00
joshvanl
1d926e8e50 Adds UserInfo fields to conversion webhook tests
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 17:35:13 +01:00
jetstack-bot
6d13f910ef
Merge pull request #4271 from maelvls/forget-scheduler-item-deletedfunc
Revert the `Forget` call that was happening on every Certificates and Orders sync
2021-07-29 17:02:41 +01:00
joshvanl
d261e2eadb Defined AdmissionReviewVersions:[]string{"v1"} in API webhook
configuration integration tests

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 14:54:17 +01:00
joshvanl
a09c93f885 Set integration apiserver webhook configuration to use AdmissionReviewVersions=[]string{"v1"}
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 14:11:46 +01:00
Inteon
644db10b92
don't early-stop, instead return all versions
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-07-29 15:06:31 +02:00
joshvanl
29514ff09d Adds v1beta1 as a supported admissionReviewVersion with a note as to
why it is listed even though we don't support it

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 11:10:25 +01:00
joshvanl
fbfe48cad8 Change webhook manifests for mutation and validation to only accept v1
in admissionReviewVersions

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 11:10:25 +01:00
joshvanl
bd95b3779c Change integration test apiserver to only be configured with v1
admission configuration

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 11:10:25 +01:00
joshvanl
8470ba96f0 Change webhook admission/mutation to no longer understand and reject anything which is not
v1 (remove v1beta1)

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-29 11:10:24 +01:00
jetstack-bot
b92fc91208
Merge pull request #4267 from JoshVanL/ctl-remove-pkg-util
Move exported cmd util func to package where it is used
2021-07-29 11:02:12 +01:00
Maël Valais
e4f981da66 Revert "memory leak: clean up scheduler goroutine on cert deletion"
This reverts commit 641960b6. The reason we decided to revert this is
that we are unsure about the implications of adding the
scheduledWorkQueue.Forget call. The new Forget call is left untested,
and it makes us nervous not to know exactly if it works as intended.

The "Forget" memory leak that we are reverting now is the cause of a
tiny fraction of the overall memory leakage that was fixed in the PR
in the scheduler itself.  Reverting this means that some goroutines will
be leaked, but only when a Certificate gets removed and never recreated
with the same name.

Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-28 19:19:39 +02:00
jetstack-bot
8ae179b8f5
Merge pull request #4261 from SgtCoDFish/tsuru-ca-chain-without-root
CA chain fix without root
2021-07-28 17:18:41 +01:00
joshvanl
6c5a4897b6 Adds note as to why v1beta1 is still an accepted
`conversionReviewVersion`

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-28 15:49:50 +01:00