Commit Graph

5323 Commits

Author SHA1 Message Date
Jake Sanders
a91b4e81fc
deadcode: maxRetries is unused
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:28:16 +01:00
Jake Sanders
7b06785012
deadcode: Highlight missing test
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:24:41 +01:00
Jake Sanders
e7219a155f
gosimple: S1004
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:21:38 +01:00
Jake Sanders
aca56a7168
errcheck
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:19:46 +01:00
Jake Sanders
04ee9acd46
gosimple: S1019
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:17:06 +01:00
Jake Sanders
77d8021d3b
gosimple: S1011
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:16:17 +01:00
Jake Sanders
0625249fc7
errcheck: Error return value of controller.Register is not checked
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:14:48 +01:00
jetstack-bot
c7514d9262
Merge pull request #3946 from inteon/fix_kubectl_apply
remove podTemplate field from ACMEChallengeSolverHTTP01Istio
2021-04-30 14:57:13 +01:00
Inteon
421ea2c867 add/ remove '// +optional' tags & cleanup other annotations
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-30 15:08:08 +02:00
Inteon
b44e347ce1 remove podTemplate field from ACMEChallengeSolverHTTP01Istio
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-30 13:15:01 +02:00
jetstack-bot
49cbedf262
Merge pull request #3940 from wallrj/upgrade-staticcheck-tool
Upgrade to Staticcheck 2020.2.3 (v0.1.3)
2021-04-29 16:30:29 +01:00
Richard Wall
b7c813575e Upgrade to Staticcheck 2020.2.3 (v0.1.3)
See https://github.com/dominikh/go-tools/releases/tag/2020.2.3

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-29 15:54:46 +01:00
jetstack-bot
f2a74ade5e
Merge pull request #3939 from JoshVanL/istio-api-to-internal-apis
Istio api to internal package. Move istio utils to /pkg/utils/istio
2021-04-29 13:26:29 +01:00
joshvanl
c5e2184a4a Moves /pkg/internal/apis/istio to /pkg/internal/istio
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 12:31:57 +01:00
joshvanl
01716e2907 Fixes stutter: istio.IsIstioInstalled -> istio.IsInstalled
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:42:21 +01:00
joshvanl
00ceff3421 Update bazel
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:36:49 +01:00
joshvanl
3af22cf6c6 Move istio util duncs to pkg/util/istio
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:35:41 +01:00
joshvanl
e8a585f740 Move internal istio apis from pkg/issuer to pkg/internal/apis
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:35:20 +01:00
jetstack-bot
7ff54e61e9
Merge pull request #3794 from JoshVanL/dont-log-optimistic-logging
Log Info when a re-queue happens due to optimistic locking
2021-04-28 17:30:07 +01:00
joshvanl
b543d103d5 Change optimistic logging to be Info, rather than debug
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-28 14:19:15 +01:00
joshvanl
8da0e25ced Don't log on default log level when an error occurs in optimistic
locking

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-28 14:16:37 +01:00
jetstack-bot
8d794c6bcf
Merge pull request #3932 from anton-johansson/also-handle-conversion-webhook-from-outside-the-cluster
Add support to allow CRD conversion webhooks from outside of the cluster
2021-04-28 13:24:06 +01:00
jetstack-bot
fca9322c58
Merge pull request #3906 from clatour/more_descriptive
Add a more descriptive FindZoneByFqdn error message
2021-04-28 12:53:06 +01:00
jetstack-bot
bc5c5e1a37
Merge pull request #3921 from vshn/fix/helm-values
Include HTTPS proxy variable in Helm values
2021-04-28 12:24:06 +01:00
Anton Johansson
96a0859ac7
Add support to allow CRD conversion webhooks from outside of the cluster
Related to #3876

Signed-off-by: Anton Johansson <hello@anton-johansson.com>
2021-04-28 12:49:10 +02:00
jetstack-bot
27d916edfa
Merge pull request #3876 from anton-johansson/add-support-for-accessing-the-webhook-from-outside-of-the-cluster
Add support for accessing the webhook from outside of the cluster
2021-04-28 11:15:07 +01:00
jetstack-bot
80f27739b5
Merge pull request #3724 from inteon/istio-virtualservice-for-http01
Istio VirtualService for HTTP01 solving (rebased)
2021-04-28 09:58:06 +01:00
Inteon
2d7dfcb462 start DynamicSharedInformerFactory unconditionally; only listen for VirtualServices conditionally
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:49 +02:00
Inteon
4d7d08b0bc Update pkg/apis/acme/v1alpha2/types_issuer.go
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:49 +02:00
Inteon
2299e8d8a6 Apply suggestions from code review
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:49 +02:00
Inteon
30634f154c improve Certificate is Ready test
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:47 +02:00
Inteon
624e2b9e69 add ACME HTTP01 Istio support
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:19:53 +02:00
jetstack-bot
96604d02a3
Merge pull request #3917 from wallrj/3152-sample-external-issuer-release
Simplify the installation of sample-external-issuer
2021-04-27 14:55:21 +01:00
Richard Wall
4944619f80 Simplify the installation of sample-external-issuer
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-27 11:44:20 +01:00
jetstack-bot
a06ff28ac3
Merge pull request #3865 from erikgb/fix/3619
Handle CA issuer working as intermediate correctly
2021-04-26 13:55:06 +01:00
Tobias Nehrlich
6d6d69a5e5
Include HTTPS proxy variable in Helm values
The `http_proxy` key was defined twice and is therefore replaced once with the `https_proxy` key.

Signed-off-by: Tobias Nehrlich <tobias.nehrlich@vshn.ch>
2021-04-26 12:04:04 +02:00
Erik Godding Boye
5d21410156 Add new unsupported feature to exclude root CA assert in Vault issuer e2e-tests
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-23 15:14:33 +02:00
Erik Godding Boye
1919e4cb3f Add root CA certificate assert to e2e tests
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-23 15:14:33 +02:00
Erik Godding Boye
249ec4fe8b Add unit tests for pki.SignCSRTemplate
Signed-off-by: Erik Godding Boye <egboye@gmail.com>

Co-authored-by: Maël Valais <mael@vls.dev>
2021-04-23 15:14:33 +02:00
Erik Godding Boye
b514a74d0a fix #3619: Handle CA issuer working as intermediate correctly
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-22 18:43:33 +02:00
Erik Godding Boye
b221f7b7cf Add IntelliJ IDEA module files (*.iml) to .gitignore
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-22 18:43:33 +02:00
jetstack-bot
1d761f3e93
Merge pull request #3914 from SgtCoDFish/pubkeycomparison
Fix incorrect comparison function for public keys
2021-04-22 16:35:37 +01:00
Ashley Davis
3df1173a22
fix incorrect comparison function for public keys
also adds/improves doc comments on related functions, and adds tests of
comparisons RSA keys and ECDSA keys. these tests failed as expected
before the function was changed, e.g.:

```text
Executing tests from //pkg/util/pki:go_default_test
---------------------------------------------------
--- FAIL: TestPublicKeysEqualECDSA (0.00s)
  generate_test.go:492: got an incorrect match from different curves:
    pub1 type: "P-256"
    pub2 type: "P-521"
--- FAIL: TestPublicKeysEqualRSA (0.00s)
  generate_test.go:560: got an incorrect match from different RSA keys:
    pub1: &rsa.PublicKey{N:2293...<snip>...8869, E:65537}
    pub2: &rsa.PublicKey{N:2293...<snip>...8869, E:3}
```

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-04-22 16:07:18 +01:00
clatour
440da719a9 fixup! Add a more descriptive FindZoneByFqdn error message
Signed-off-by: clatour <chandler.latour@gmail.com>
2021-04-21 17:47:48 +00:00
clatour
40a6c2bb3c fixup! Add a more descriptive FindZoneByFqdn error message
Signed-off-by: clatour <chandler.latour@gmail.com>
2021-04-21 17:03:31 +00:00
clatour
2c2fbd483b Add a more descriptive FindZoneByFqdn error message
Spent a couple of days tracking down bad `SERVFAIL` for some of our
domains, and had a hard time finding where this was coming from. Make
the error slightly more descriptive to help locate it, and more inline
with the terminal error of the function.

Signed-off-by: clatour <chandler.latour@gmail.com>
2021-04-20 22:06:24 +00:00
jetstack-bot
17bf228fbb
Merge pull request #3902 from SgtCoDFish/modcompatguarantee
Add note about module compat and code style
2021-04-20 13:57:57 +01:00
Ashley Davis
4b000dd05a
Add note about module compat and code style
Also includes some minor changes to language and title casing

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-04-20 13:20:04 +01:00
jetstack-bot
384c356f27
Merge pull request #3903 from irbekrm/temp_disable_venafi_cloud_e2e_tests
Temporarily revert "Enable the Venafi Cloud E2E tests"
2021-04-20 12:44:00 +01:00
irbekrm
70f3d0b8c2 Temporarily revert "Enable the Venafi Cloud E2E tests"
This reverts commit 4ddfcbf96b.

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-20 12:19:43 +01:00