weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
6,371 Commits 45 Branches 0 Tags 96 MiB
7f8641dd94
Commit Graph

6371 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Thierry Sallé
7f8641dd94 [additionalOutputFormats] Update comments and add more tests 
Signed-off-by: Thierry Sallé <seuf76@gmail.com>
 2022-01-14 11:10:32 +01:00
Thierry
81f308221b Add certifcate additionalOutputFormats parameter 
DER Format to create key.der binary format of the private key.

CombinedPEM Format to create tls-combined.pem containing tls.key + tls.crt.

Added Unit and e2e tests for secret with Additional output format.

Feature flag AdditionalCertificateOutputFormats to enable feature.

Signed-off-by: Thierry Sallé <seuf76@gmail.com>
 2022-01-14 11:10:32 +01:00
jetstack-bot
f1813d0368
Merge pull request #4730 from SgtCoDFish/movednstest 
move RFC2136 DNS01 tests to test/integration
 2022-01-13 11:10:04 +00:00
jetstack-bot
4d5058a92e
Merge pull request #4728 from SgtCoDFish/moveversionchecker 
Move versionchecker tests to test/integration
 2022-01-13 10:18:36 +00:00
Ashley Davis
92f78e8f8d
move RFC2136 DNS01 tests to test/integration 
Since this test requires setup before it can successfully run,
we define it as an integration test and move it here so that on a
fresh checkout a user can always run `go test ./pkg/...` and expect that
it would succeed.

Also:

- tweaks some comments
- adds methods for getting nameserver / tsig algorithm from DNSProvider

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-12 16:00:10 +00:00
Ashley Davis
93f868b3bc
move versionchecker tests to test/integration 
Since this test requires setup before it can successfully run,
we define it as an integration test and move it here so that on a
fresh checkout a user can always run `go test ./pkg/...` and expect that
it would succeed.

Also involves:

- Exporting the VersionChecker and adding NewWithConfig to enable
  testing
- Some comment changes
- A change to the type returned by New(); see
  https://github.com/golang/go/wiki/CodeReviewComments#interfaces

Ideally I'd not add `NewFromClient` but I think it's the most minimal
change and is preferable to publicly exporting `VersionChecker.client`.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-12 14:21:53 +00:00
jetstack-bot
778be75841
Merge pull request #4697 from irbekrm/valid_orders_update 
Don't fail an order that has been finalized, but the status has not been synced to Order CR
 2022-01-12 08:10:03 +00:00
irbekrm
e7cc37ef71 Code review feedback 
Signed-off-by: irbekrm <irbekrm@gmail.com>

Co-authored-by: Maël Valais <mael@vls.dev>
 2022-01-11 18:09:44 +00:00
jetstack-bot
fa321b6a4b
Merge pull request #4287 from linka-cloud/acme-http-challenge-cutomer-dns 
Acme http challenge custom dns
 2022-01-11 11:24:03 +00:00
irbekrm
24866544b8 Ensures that if alternate cert chain is specified, it is retrieved 
Ensures that if the cert is retrieved in a reconcile following the one that finalized the ACME order, the alternate cert chain is still respected, if specified by user

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2022-01-11 10:51:14 +00:00
irbekrm
de8aa2583e Ensures that ACME orders controller does not create new order if it failed to update old order's status to valid 
Check the status of the ACME order if finalizing order failed to catch edge cases where the order is already finalized, but the updating of Order CR's status has failed

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2022-01-11 10:51:14 +00:00
jetstack-bot
2e465fbf34
Merge pull request #4628 from irbekrm/sync_cleanup 
Order sync cleanup
 2022-01-10 20:27:04 +00:00
jetstack-bot
20c08e6c3d
Merge pull request #4723 from SgtCoDFish/verifychart 
Allow helm chart verification in both bazel + make
 2022-01-10 19:15:03 +00:00
Ashley Davis
72027ce622
bump chart-testing image version to v3.5.0 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-10 18:02:25 +00:00
Ashley Davis
ad998b35f8
Allow helm chart verification in both bazel + make 
This slightly modifies our existing helm chart verification script to
accept the location of a tarball containing the chart we're verifying.

That in turn allows us to more generally use the script for both
validating the chart we build using make and the chart we build using
bazel.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-10 18:02:14 +00:00
jetstack-bot
c68e78c510
Merge pull request #4702 from devholic/fix-multiple-dns-provider 
Install APIGroup once for multiple DNS providers
 2022-01-10 11:25:04 +00:00
Sunghoon Kang
47d07e85de
Add test for creating ChallengeServer with solvers 
Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
 2022-01-08 22:55:21 +09:00
Adphi
a131eda198
acme-http: add reachability tests 
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
 2022-01-08 12:37:41 +01:00
jetstack-bot
7f9fceef90
Merge pull request #4670 from munnerz/features 
Re-organise featuregates & add webhook-specific gates
 2022-01-07 13:25:16 +00:00
James Munnelly
9a0a395c05 Re-order imports 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-07 12:49:51 +00:00
James Munnelly
df250307c2 Fix test failures 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-07 12:20:31 +00:00
James Munnelly
ea2d04e2c0 Add webhook-specific 'feature' package and wire it up through config 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-07 12:17:38 +00:00
James Munnelly
9c04a04c7c Move feature package into internal/controller 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-07 12:17:36 +00:00
Adphi
0f9b47b4f0
acme-http: use Go built-in resolver 
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
 2022-01-06 22:34:05 +01:00
Adphi
c9bc776b49
acme-http: fix tests 
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
 2022-01-06 21:37:04 +01:00
Adphi
498c496053
acme-http: fix bazel 
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
 2022-01-06 21:02:51 +01:00
Adphi
3375fa0609
http01: add custom nameservers support (#4286) 
Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
 2022-01-06 21:02:46 +01:00
jetstack-bot
2ebfdd29ec
Merge pull request #4716 from munnerz/allow-integration-with-delve 
Re-organise and extend path loading logic to make it easier to run integration tests using Delve/GoLand
 2022-01-06 19:25:23 +00:00
jetstack-bot
65c41b3356
Merge pull request #4717 from SgtCoDFish/ginkgofromgomod 
Install ginkgo version from go.mod rather than specifying an explicit version
 2022-01-06 18:42:22 +00:00
jetstack-bot
523e0c817a
Merge pull request #4711 from munnerz/upgrade-migrate-tool 
Add 'cmctl upgrade migrate' tool to assist in v1.7 upgrade
 2022-01-06 17:24:22 +00:00
Ashley Davis
168b47f1b0
install ginkgo version from go.mod, rather than explicit ver 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-06 16:53:36 +00:00
James Munnelly
29f793aca8 Prefer RUNFILES_DIR if it is set 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 16:50:44 +00:00
James Munnelly
c841d01d68 Allow specify --qps and --burst 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 16:47:43 +00:00
James Munnelly
b3f14ef51d Expand example usage text 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 16:42:39 +00:00
James Munnelly
4b257c1d72 Only mention upgrading to 1.0-1.6 once 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 16:39:07 +00:00
jetstack-bot
a29cf92ae4
Merge pull request #4715 from SgtCoDFish/gobuildboilerplate 
Match upstream boilerplate verification for files w/ go:build
 2022-01-06 16:01:22 +00:00
James Munnelly
8ff84e8b70 Re-organise and extend path loading logic to make it easier to run integration tests using Delve/GoLand 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:22:39 +00:00
James Munnelly
35a96362a7 Rename command to 'migrate-api-version' 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:21:47 +00:00
James Munnelly
0f199173ba Add missing copyright headers 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:08:48 +00:00
James Munnelly
1ae8fedc2d Add additional test cases 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:08:15 +00:00
James Munnelly
22b2b3687a Don't assume we are targetting 'v1' 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:07:27 +00:00
James Munnelly
c4d97e1f53 Indicate whether a migration was actually performed in Run 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:07:10 +00:00
James Munnelly
f6e3458837 Rename --force to --skip-stored-version-check 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 15:06:26 +00:00
Ashley Davis
5a5c94a3f1
match upstream boilerplate verification for files w/ go:build 
the regex being replaced doesn't match files which only contain go:build
although as of go 1.17 (which we require for cert-manager) that's
totally valid.

this commit updates the regex to match upstream k8s, which is the
original source of the boilerplate verification script in any case

upstream:
47ff335d4c/hack/boilerplate/boilerplate.py (L219-L223)

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-06 14:57:21 +00:00
jetstack-bot
7021be7a1f
Merge pull request #4714 from SgtCoDFish/install-ginkgo 
Add install for ginkgo which is used for e2e tests
 2022-01-06 14:50:23 +00:00
James Munnelly
5b50412d1e Fix bug causing error to always be returned 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 14:07:58 +00:00
Ashley Davis
80648321f8
add install for ginkgo, used for e2e tests 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2022-01-06 14:06:29 +00:00
jetstack-bot
25b6728825
Merge pull request #4710 from SgtCoDFish/goimports 
Add goimports verification and skeleton ci presubmit check
 2022-01-06 14:02:22 +00:00
James Munnelly
b7b1baf565 Fix call to NewTestLogger after logr upgrade 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 13:18:57 +00:00
James Munnelly
8fa378fe01 Check to ensure the storage version or storedVersions have not unexpectedly changed before patching storedVersions 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-01-06 13:18:31 +00:00