weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
7,177 Commits 45 Branches 0 Tags 96 MiB
5d17098322
Commit Graph

7177 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim Ramlot
5d17098322 fix broken test 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-28 21:17:08 +02:00
Renato Costa
162777aab2 Fix incorrect uses of loop variable 
This fixes two instances where loop variables were being incorrectly
used:

- using a loop variable in a closure passed to `ginkgo.It()` is
incorrect, as the capture happens by reference and only the last test
case will be executed (multiple times).
- a similar issue happens in the context of a goroutine; specifically,
we need to create a copy of the `runDurationFunc` before calling it in
a goroutine as done by the controller's `Run` function.

With regards to the second issue, I believe it never came to the
surface because, in production code, only one `runDurationFunc` is
passed; tests don't exercise the multiple funcs path either.

Issues were automatically found with the `loopvarcapture` linter.

Signed-off-by: Renato Costa <renato@cockroachlabs.com>
 2022-08-26 15:08:30 -04:00
jetstack-bot
2821157f69
Merge pull request #5401 from sathieu/servicemonitor_annotations 
Add annotations for ServiceMonitor in helm chart
 2022-08-26 17:50:19 +01:00
jetstack-bot
b1d96755f2
Merge pull request #5395 from stek29/fix-5149 
Add topologySpreadConstraints to helm chart
 2022-08-26 16:13:20 +01:00
Mathieu Parent
ffd802d750 Add annotations for ServiceMonitor in helm chart 
Signed-off-by: Mathieu Parent <mathieu.parent@insee.fr>
 2022-08-26 16:46:31 +02:00
jetstack-bot
62d08c2e60
Merge pull request #5398 from inteon/automate_tools 
Generate Makefile build targets dynamically for tools
 2022-08-26 13:14:19 +01:00
Tim Ramlot
36b55c1561 improve tools.mk docs 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-26 12:55:53 +02:00
Tim Ramlot
5802b3a963 use variables for binaries 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-26 07:43:17 +00:00
Tim Ramlot
0e8eb38d5c generate build targets dynamically 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-26 07:23:44 +00:00
jetstack-bot
12f98dbc7e
Merge pull request #5376 from inteon/upgrade_gateway_api 
Upgrade gateway api to v0.5.0
 2022-08-25 16:08:10 +01:00
jetstack-bot
db928e59a0
Merge pull request #5402 from JoshVanL/test-e2e-csr-selfsigned-require-feature-gate-enabled 
Adds `ExperimentalCertificateSigningRequestControllers` to CSR e2e tests.
 2022-08-25 11:19:10 +01:00
joshvanl
e16baf4706 Updates CertificateSigningRequest SelfSigned e2e tests to require 
needing the CertificateSigningRequest Feature Gate to be enabled.

Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-25 10:41:31 +01:00
jetstack-bot
d1a8f7f52d
Merge pull request #5336 from JoshVanL/controllers-certificaterequests-secrets-informer 
CertificateRequest: re-sync SelfSigned CertificateRequest when target Secret is informed.
 2022-08-23 16:46:23 +01:00
Viktor Oreshkin
de24b860ae Add topologySpreadConstraints to helm chart (fix #5149) 
Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
 2022-08-22 06:24:16 +03:00
jetstack-bot
10c4b7cde9
Merge pull request #5379 from JoshVanL/controllers-certificatesigningrequests-secrets-informer 
CertificateSigningRequest: re-sync SelfSigned CertificateSigningRequest when target Secret is informed
 2022-08-19 15:50:12 +01:00
jetstack-bot
96dd8849ca
Merge pull request #5311 from EugenFo/add-port-to-container-spec 
added healthcheck to containers port spec
 2022-08-19 10:58:11 +01:00
Tim Ramlot
37f64ca5a0 partial undo of replace-all for contour-gateway.yaml 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-19 07:36:43 +00:00
jetstack-bot
6947696b12
Merge pull request #5382 from irbekrm/solver_pod_config 
Document that pod template spec should be used instead of flags
 2022-08-10 12:02:51 +01:00
jetstack-bot
34ea128fd3
Merge pull request #5368 from hawksight/pf/lease 
docs: Correct reference to lease not config map
 2022-08-09 17:04:05 +01:00
jetstack-bot
3440786c03
Merge pull request #5377 from jahrlin/cainjector-flaky-test 
Flaky test: add random suffix to webhooks in CA Injector e2e tests
 2022-08-09 16:26:06 +01:00
irbekrm
584147df37 Document that pod template spec should be used instead of flags 
For configuring ACME HTTP-01 solver pod

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2022-08-09 15:26:10 +01:00
Joakim Ahrlin
1501449e3e use GenerateName instead 
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@gmail.com>
 2022-08-09 12:41:31 +02:00
joshvanl
8b2dc2a746 Update ginkgo import path to use /v2 
Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-09 11:25:41 +01:00
joshvanl
52787eabd2 Adds e2e tests for the new SelfSigned CertificateSigningRequest Secret 
informer

Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-09 11:17:44 +01:00
joshvanl
7b168cc059 Updates selfsigned CertificateSigningRequest controller with new Secret 
informer, and no longer mark the request as Failed when the private key
Secret is malformed. This behaviour matches the CertificateRequest
self signed controller.

Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-09 11:16:10 +01:00
joshvanl
fc9554a617 Adds secret handler function for selfsigned CertificateSigningRequest 
controller, which re-syncs requests which reference the Secret via the
`experimental.cert-manager.io/private-key-secret-name` annotation.

Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-09 11:14:22 +01:00
joshvanl
b03e6f11f5 Updates ACME CertificateSigningRequest for new informer registration 
format

Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-09 11:13:29 +01:00
joshvanl
dfd1e512d8 Update CertificateSigningRequest controller to accept a list of 
RegisterExtraInformerFn, which control the extra informers.

Signed-off-by: joshvanl <me@joshvanl.dev>
 2022-08-09 11:12:41 +01:00
joshvanl
0b2cdf5a40 Adds e2e tests for CertificateRequest self signing controller; focussing 
on requests being re-synced when the target Secret is up

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2022-08-09 08:40:05 +01:00
joshvanl
ccf579cf31 Adds extra informer for the CertificateRequest SelfSigned controller, 
so that CertificateRequets will be re-synced on informed Secrets which
are referenced with "cert-manager.io/private-key-secret-name"

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2022-08-09 08:39:50 +01:00
jetstack-bot
58b226e06c
Merge pull request #5163 from james-callahan/webhook-dynamic-serving-dns-names 
Webhook dynamic serving dns names
 2022-08-08 13:57:50 +01:00
Joakim Ahrlin
de0f39e553 add random suffix to webhooks in CA Injector e2e tests 
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@gmail.com>
 2022-08-08 12:52:52 +02:00
Tim Ramlot
836793e7e3 upgrade gateway api to v0.5.0 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-08 08:52:59 +00:00
jetstack-bot
07677c57bc
Merge pull request #5366 from munnerz/privatekey-regen-test 
Ensures CertificateRequests marked as 'InvalidRequest' are properly handled as failures & retried
 2022-08-05 16:23:30 +01:00
James Munnelly
ddc19a1c57 Fix comment 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-05 15:52:52 +01:00
jetstack-bot
88bda66693
Merge pull request #5345 from inteon/ginkgo_v2 
Upgrade to Ginkgo v2
 2022-08-04 21:06:15 +01:00
Peter Fiddes
9b8d279193
docs: Change values.yaml wording to reference correct resource 
Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
 2022-08-04 15:11:32 +01:00
jetstack-bot
f058c815a3
Merge pull request #5364 from inteon/go1.19_fmt 
Apply go fmt for go1.19
 2022-08-04 14:42:14 +01:00
James Munnelly
2de5135e18 Fix test flake 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-04 14:15:49 +01:00
jetstack-bot
b52d116fa4
Merge pull request #5363 from inteon/gotestsum_junit 
Output junit xml using gotestsum
 2022-08-04 12:46:14 +01:00
James Munnelly
7b4d04cdef bugfix: fix issue where CertificateRequests marked InvalidRequest were not properly marked as Failed 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-04 12:21:41 +01:00
James Munnelly
e62bfaf367 Add test to check InvalidRequest handling for certificates 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-04 12:21:41 +01:00
James Munnelly
51014e5752 Add integration test for regenerating private key for each CR upon failure 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-04 12:21:41 +01:00
James Munnelly
099a52ffe3 integration framework: add StartInformersAndControllers 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-04 12:21:41 +01:00
James Munnelly
11ada1d3d3 rename policyEvaluator->BuildReadyConditionFromChain 
Signed-off-by: James Munnelly <jmunnelly@apple.com>
 2022-08-04 12:21:41 +01:00
Tim Ramlot
ba9a6bd5b3 add pruning logic for gotestsum junit xml output 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-04 11:15:18 +00:00
jetstack-bot
b7c47298a0
Merge pull request #5362 from inteon/simplify_manifest 
Simplify static manifest generation
 2022-08-04 11:25:14 +01:00
Tim Ramlot
a8743628a4 only print Helm install output on error 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-04 10:21:27 +00:00
Tim Ramlot
501277bb62 bugfix ginkgo: make tests deterministic, don't use maps to define testCases 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-04 10:16:29 +00:00
Tim Ramlot
9897f2355c upgrade ginkgo to v2 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
 2022-08-04 10:16:29 +00:00