weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
6,038 Commits 45 Branches 0 Tags 96 MiB
563aeb1789
Commit Graph

6038 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
George Moldoveanu
563aeb1789
fixed keystore.go and keystore_test.go modules imports 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-10 13:28:45 +01:00
George Moldoveanu
0463681244
updates go deps and bazel files 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-02 23:45:11 +01:00
George Moldoveanu
d0151f7175
fixed TestEncodeJKSKeystore tests to work with upgraded keystore-go api (v4) 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-02 23:33:45 +01:00
George Moldoveanu
155e90d175
upgraded keystore-go to v4 and fixed code to use v4 api 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-02 23:24:06 +01:00
jetstack-bot
059e52549e
Merge pull request #4416 from charlie-haley/master 
Fix typo in error message
 2021-09-02 07:13:12 +01:00
jetstack-bot
2bdda7210d
Merge pull request #4407 from JoshVanL/ctl-factory 
ctl factory
 2021-09-01 18:30:11 +01:00
jetstack-bot
aae24ba82d
Merge pull request #4338 from irbekrm/ginkgo_skip_focus 
Ginkgo skip/focus can be optionally passed in from CI
 2021-09-01 17:26:11 +01:00
irbekrm
66d8b85be8 Ginkgo skip/focus values can be optionally passed in from CI 
Signed-off-by: irbekrm <irbekrm@gmail.com>

Re-instate Venafi Cloud tests

They are now passing - we can see that for CertificateSigningRequest tests

Signed-off-by: irbekrm <irbekrm@gmail.com>

Don't skip Ginkgo tests marked as feature

We can instead define which tests to skip using GINKGO_FOCUS/GINKGO_SKIP to make skipping/focusing more obvious

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-09-01 13:29:28 +01:00
Charlie Haley
e06e208f9b
fix typo in error message 
Signed-off-by: Charlie Haley <27928201+charlie-haley@users.noreply.github.com>
 2021-08-28 00:15:07 +01:00
jetstack-bot
9cd7d35303
Merge pull request #4414 from irbekrm/startupapicheck_comment 
Adds a warning about sidecar proxy for startup check job
 2021-08-27 12:59:11 +01:00
irbekrm
38ce9fc4b1 Adds a warning about sidecar proxy for startup check job 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-27 12:18:44 +01:00
joshvanl
33621ca333 Use helm settings to define CLI flags for install command 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-08-24 19:11:23 +01:00
joshvanl
4cdbb64003 Update ctl integration tests to use new local factory package 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-08-24 16:37:01 +01:00
joshvanl
80a7bc5412 Update root ctl command to no longer pass a factory to sub commands 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-08-24 16:30:44 +01:00
joshvanl
20c1de7626 Update all commands to no longer receive a factory, and instead use the 
shared local factory package

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-08-24 16:30:44 +01:00
joshvanl
56b29e0f59 Change install command to use Helm to register flags. No longer need to 
copy flag values

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-08-24 16:30:43 +01:00
joshvanl
f6b7bc973b Adds /cmd/ctl/pkg/factory which registers Kube CLI flags, and provides 
clients/config needed

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-08-24 16:29:01 +01:00
jetstack-bot
c25b116fc5
Merge pull request #4406 from SgtCoDFish/removekrewauomation 
Remove krew automation
 2021-08-24 12:10:34 +01:00
Ashley Davis
b2f7aa57ea
remove krew automation 
github actions is pretty flawed in several ways, and it's missing
features which would make it usable for us.

we want to trigger our krew automation when a new stable release of our
latest supported cert-manager release is published. github has all this
information, but it's not easy to _use_ that information when triggering
a github action.

we also only want to trigger the action on the main repo and not on
forks.

if we end up having to write custom code to do this, we might as well
add that code into cmrel and not have to deal with the flaws in gh
actions.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-24 11:24:52 +01:00
jetstack-bot
e5cc0be04b
Merge pull request #4399 from irbekrm/fix_renewal_issue 
Fix renewalTime skew issue
 2021-08-23 16:36:50 +01:00
irbekrm
ec1bdc4983 Adds a test case for renewal time skew and a comment 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-23 15:00:57 +01:00
jetstack-bot
38338bc7c3
Merge pull request #4402 from Juneezee/deprecate-ioutil 
refactor: move from io/ioutil to io and os package
 2021-08-23 13:50:51 +01:00
Eng Zer Jun
54e70d2cc4
refactor: move from io/ioutil to io and os package 
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2021-08-23 19:50:42 +08:00
irbekrm
50e90dfe6e Fix renewalTime skew issue 
Ensure the time returned by RenewalTime function is the same time as that which will be read from Certificate's status

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-20 17:57:35 +01:00
jetstack-bot
38ab6f4bdd
Merge pull request #4365 from jonathansp/master 
fix: flaky test when comparing unordered elements
 2021-08-20 13:02:44 +01:00
jetstack-bot
0ff741c9d2
Merge pull request #4392 from SgtCoDFish/fixversions 
Fix manually specified Certificate and CertificateRequest versions
 2021-08-20 12:16:45 +01:00
jetstack-bot
72f5694659
Merge pull request #4393 from jakexks/solver_serviceType 
Regression: restore the previous service type defaulting behaviour
 2021-08-19 15:36:09 +01:00
Jake Sanders
5df1dd4932
Update Docs on solver type to reflect default service type 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:55:50 +01:00
Jake Sanders
f1ac6efade
Add integration test for ensuring default solver service type is NodePort 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:52:23 +01:00
Jake Sanders
326783ca32
Fix regression in solver service builder - default service type should be NodePort rather than empty 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:51:21 +01:00
Ashley Davis
68f5ceb3b4
Fix manually specified Certificate and CertificateRequest versions 
Basically all modern X.509 certs are version 3, but confusingly to
specify "version 3" in an encoded cert, the version number is actually
2.

For PKCS#10 CSRs, the only valid version is 1, which again
confusingly has the value "0" when encoded.

This was incorrect in many places, including one place in which the
version number on a CSR was used as a certificate's version number,
when the two are entirely unrelated.

Go ignores these values, so there's no functional changes here; still,
it's better to be accurate.

Go ignoring CSR version and specifying 0:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1958

Go ignoring Certificate version and specifying 2:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1534

PKCS#10 CSR specification in RFC 2986 section 4.1:
https://datatracker.ietf.org/doc/html/rfc2986#section-4

X.509 Cert specification in RFC 5280 section 4.1.2.1:
https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.1

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-19 14:48:12 +01:00
jetstack-bot
c24c0889bf
Merge pull request #4390 from irbekrm/verify_crd_status 
Verify crd status
 2021-08-19 10:22:08 +01:00
Irbe Krumina
e43db8a426 Code review feedback. 
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-19 09:43:45 +01:00
irbekrm
04b584e698 verify-crds script now verifies that the CRDs don't contain status field 
This is necessary because some CD tools don't accept resource configs with predefined status fields, but controllergen currently adds this field when a CRD yaml is generated

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-19 06:19:37 +01:00
irbekrm
b8e2846901 Adds a Bazel rule to install yq 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-18 18:36:01 +01:00
jetstack-bot
a608e850de
Merge pull request #4386 from jakexks/gnu-sed 
Fix codegen script on Darwin
 2021-08-18 18:06:29 +01:00
jetstack-bot
c5a4cb9fbf
Merge pull request #4384 from jakexks/en_GB 
finalisers -> finalizers
 2021-08-18 17:23:35 +01:00
jetstack-bot
bea6c20e26
Merge pull request #4369 from irbekrm/improve_owner_not_found_errors 
Improve owner not found errors
 2021-08-18 17:23:29 +01:00
jetstack-bot
ba2e25674a
Merge pull request #4379 from irbekrm/remove_crd_status 
Removes status fields from CRD definitions
 2021-08-18 16:42:29 +01:00
Jake Sanders
682b3f108e
Fix sed command on Darwin 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 16:09:14 +01:00
jetstack-bot
18a15fe385
Merge pull request #4373 from jakexks/ingress_path_type 
Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0
 2021-08-18 15:55:28 +01:00
Jake Sanders
e0ecc9938a
finalisers -> finalizers 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 15:33:27 +01:00
Jake Sanders
38ce03e3ec
Fix regression in Ingress PathType introduced in v1.5.0 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 15:16:23 +01:00
jetstack-bot
00679a557b
Merge pull request #4383 from irbekrm/vcloud_v2 
Explicitly set Venafi Cloud e2e tests to use v2 endpoint
 2021-08-18 15:15:29 +01:00
irbekrm
831b87898f Explicitly set Venafi Cloud e2e tests to use v2 endpoint 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-18 12:52:05 +01:00
irbekrm
7d30a6452c Removes status fields from CRD definitions 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-18 10:17:34 +01:00
irbekrm
904d4e3c15 Don't error if owner not found in cache 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-17 08:31:49 +01:00
jetstack-bot
ff9403aaf2
Merge pull request #4366 from SgtCoDFish/krew_darwin_arm64 
update trigger for gh action, add arm64 darwin for krew
 2021-08-16 19:05:02 +02:00
Ashley Davis
b069056e0a
update trigger for gh action, add arm64 darwin for krew 
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-16 17:21:07 +01:00
Jonathan Prates
1ff50d3dd8 fix: flaky test when comparing unordered elements 
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
 2021-08-16 15:04:01 +01:00