Commit Graph

6844 Commits

Author SHA1 Message Date
lonelyCZ
53d8a07397 Add a unit test for challenges reScheduler
Signed-off-by: lonelyCZ <531187475@qq.com>
2022-04-08 14:35:41 +08:00
jetstack-bot
b4d304f152
Merge pull request #5024 from lonelyCZ/fix-error-reported-null
Fix the error is reported to null when it happens
2022-04-07 16:03:22 +01:00
lonelyCZ
57a6d931a1 Fix the error is reported to null when it happens
Signed-off-by: lonelyCZ <531187475@qq.com>
2022-04-07 16:10:14 +08:00
jetstack-bot
d212165c8d
Merge pull request #5016 from sveba/master
explicitly mount service-account-token in deployment
2022-04-05 22:15:48 +01:00
Svetoslav Batchovski
d843a25202 Explicitly mount service-account-token in deployment
Signed-off-by: Svetoslav Batchovski <svetoslav@batchovski.de>
2022-04-05 19:16:12 +02:00
jetstack-bot
33056f271c
Merge pull request #5017 from jakexks/remove-chart-owners
Remove OWNERS from helm chart
2022-04-05 17:25:48 +01:00
Jake Sanders
0d88032850
Remove OWNERS from helm chart
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-04-05 16:46:57 +01:00
jetstack-bot
f8900ad1d8
Merge pull request #5010 from DiptoChakrabarty/blog
add cert manager blog details in Users
2022-04-04 14:26:45 +01:00
jetstack-bot
e466a521bc
Merge pull request #4808 from JoshVanL/controllers-server-side-apply-challenges
Server Side Apply: Adds support for Challenge controllers to use SSA with Feature Gate
2022-04-01 13:02:26 +01:00
irbekrm
0f74fc10fb Removes unnecesary check for finalizer diff in challenge sync
No changes are made to finalizers in this function

Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-04-01 11:53:44 +01:00
irbekrm
9a9ca2006a Adds a challenge finalizer in challenges controller
This was previously applied in orders controller, which was causing issues when trying to remove it in challenges controller via server side apply

Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-04-01 11:53:44 +01:00
irbekrm
e458b6c813 Sets Challenge managed fields to nil when applying a spec patch
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-04-01 11:53:44 +01:00
joshvanl
aa456b9c3f Adds roundtrip tests to challenge apply serializer
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-04-01 11:53:44 +01:00
joshvanl
8ebedac654 Fix challenge serialization, and add integration tests for apply helpers
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-04-01 11:53:44 +01:00
joshvanl
67afcb2d6c Add patch permissions to challenges/status
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-04-01 11:53:44 +01:00
joshvanl
82c068f0fd Updates ACME challenge controllers to use apply
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-04-01 11:53:44 +01:00
joshvanl
ebcad79cf9 Adds controller challenges apply helpers
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-04-01 11:53:44 +01:00
jetstack-bot
e24677c5a6
Merge pull request #5009 from azusapacificuniversity/apu-to-users
Add APU to USERS.MD
2022-03-31 20:48:23 +01:00
DiptoChakrabarty
408a148a72 add cert manager blog details
Signed-off-by: DiptoChakrabarty <diptochuck123@gmail.com>
2022-03-31 21:04:09 +05:30
Brian Monroe
f3a51df76a Add APU to USERS.MD
Signed-off-by: Brian Monroe <bmonroe@apu.edu>
2022-03-31 08:22:41 -07:00
jetstack-bot
aed1692926
Merge pull request #5008 from SgtCoDFish/servermetadata
Fix target when building containers for release
2022-03-31 14:10:23 +01:00
jetstack-bot
6de05cc65e
Merge pull request #5001 from maelvls/fix-make
make: GOFLAGS missing when building cmctl and kubectl_cert-manager
2022-03-31 13:23:23 +01:00
Ashley Davis
c29f3e4aec
fix target when building containers for release
the bundles target is incorrect in a release since it won't generate
release metadata which we require when publishing a release

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-03-31 12:50:18 +01:00
jetstack-bot
0d61dcc061
Merge pull request #5007 from SgtCoDFish/oldcrds
Gracefully handle 404s when fetching old CRDs
2022-03-30 16:01:34 +01:00
Ashley Davis
7ea4496dcb
Gracefully handle 404s when fetching old CRDs
If we're in the middle of a cert-manager release we'll have a git tag
created for that release, but won't have a GitHub release created yet.
That means that an attempt to download old CRDs for our versionchecker
test will fail for that version, with a 404 error.

An alternative approach would be to use the GitHub API to query for
existing non-draft releases - but that introduces a new point of failure
whereby we can easily hit a rate limit, or else introduces the need for
a GitHub API token.

The GitHub API also has the issue that it doesn't present every release
in one API call, which complicates fetching releases using curl and uses
even more rate-limit capacity.

The approach here is simple; we ignore tags for which the release 404s,
download manifests for which the release gives a 200, and bubble up any
other errors.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-03-30 15:16:17 +01:00
jetstack-bot
86ad9962a3
Merge pull request #4967 from maelvls/gwapi-v1alpha2-optional-labels
Gateway API: with v1alpha2, the labels have become optional
2022-03-30 15:11:33 +01:00
jetstack-bot
00938dfa4c
Merge pull request #3605 from mikebryant/3601-default-nodeselector-linux
fix: Set default nodeSelector to linux
2022-03-30 13:38:33 +01:00
Maël Valais
3b4cd84a86 make: GOFLAGS missing when building cmctl and kubectl_cert-manager
The GOFLAGS make variable was set after "include make/cmctl.mk",
leading to the warning:

    Makefile:34: warning: undefined variable 'RELEASE_VERSION'
    Makefile:34: warning: undefined variable 'GITCOMMIT'

Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-30 14:24:38 +02:00
Jake Sanders
6dfd6d5800
update bazel BUILD
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-03-30 12:58:41 +01:00
Jake Sanders
d8b88f056b
tidy imports
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-03-30 12:54:20 +01:00
Jake Sanders
b72db63761
Change label description for HTTP-01 Gateway API solver and fix tests
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-03-30 12:52:34 +01:00
jetstack-bot
f4f40f689e
Merge pull request #4757 from irbekrm/exponential_backoff_design
Design for exponential backoff
2022-03-30 12:10:33 +01:00
Maël Valais
555544d23b make: avoid the message "warning: undefined variable 'CI'"
Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-30 11:04:10 +02:00
jetstack-bot
e2266d7a8b
Merge pull request #4987 from wikimedia/issue-4956
Add controller_requeue_count metric
2022-03-29 19:53:53 +01:00
jetstack-bot
b78af1ef86
Merge pull request #4888 from JoshVanL/controllers-post-issuance-secret-owner-ref
Post Issuance Check: Owner Ref
2022-03-29 17:12:53 +01:00
jayme-github
63e3b7a0a8 Add controller_sync_error_count metric
Introducing a new metric controller_sync_error_count counting the
number of errors during sync() of a controller.

This adds more visibility to potential issues ranging from things like
connection problems to the API or webhooks to possible hard errors.

For context, please see #4956

Signed-off-by: Janis Meybohm <jmeybohm@wikimedia.org>
2022-03-29 16:02:49 +02:00
joshvanl
fa411f187d Fix golang linting
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-03-29 13:59:10 +01:00
joshvanl
c54451092e Adds integration tests for owner reference post issuance checks
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-03-29 13:54:27 +01:00
joshvanl
6ee59fb9e8 Wires up new post issuance checks for issuing controller
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-03-29 13:54:27 +01:00
joshvanl
a8bfc2fd36 Adds certificates policy checks for owner references
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-03-29 13:54:27 +01:00
jetstack-bot
65d3a1c89e
Merge pull request #4968 from maelvls/make-and-appversion
make: the AppVersion and AppGitCommit weren't set
2022-03-29 13:53:52 +01:00
jetstack-bot
797997c578
Merge pull request #4994 from SgtCoDFish/theactualpath
Use absolute path of cmrel
2022-03-29 12:04:52 +01:00
Ashley Davis
d43a5e8eb8
use absolute path of cmrel
fixes the breakage created by https://github.com/cert-manager/cert-manager/pull/4988

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-03-29 11:26:52 +01:00
jetstack-bot
abed8ba148
Merge pull request #4983 from maelvls/shorter-e2e-time
Speed up the end-to-end tests (from 34 minutes down to 26 minutes) by increasing the ginkgo node count from 10 to 20
2022-03-29 11:17:52 +01:00
Maël Valais
15c19384b7 make: prevent "warning: undefined variable 'CI'"
Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-29 11:26:37 +02:00
Maël Valais
ae0632c1f0 make: add "make e2e-setup-kind-update-images"
I think having a separate file for storing the various kind image
digest isn't necessary. From now on, make/cluster.sh is the "source of
truth" for everything related to kind. If you would like to see the
image that is going to be used for creating the kind cluster, you can
run:

  make/cluster.sh --show-image

To self-update the digests with the latest available digests, run:

  make/cluster.sh --update-images

Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-29 11:26:37 +02:00
Maël Valais
c4e6ebd1a8 make/cluster.sh: remove the fixed clusterIP CIDR 10.0.0.0
The fixed CIDR isn't necessary anymore since the makefile figures the
ClusterIP dynamically. This change also enables you to run
make/cluster.sh with an existing kind cluster.

Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-29 11:26:37 +02:00
Maël Valais
6c57633884 make: remove the not-really-needed system dependency "perl"
Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-29 10:54:26 +02:00
Maël Valais
2205bafef5 e2e: WaitForAllPodsRunningInNamespaceTimeout: %s missing value in logs
Signed-off-by: Maël Valais <mael@vls.dev>
2022-03-29 10:54:26 +02:00
Maël Valais
057ce50ace make/cluster.sh: speedup etcd by using --unsafe-no-fsync
Using --unsafe-no-fsync is OK for development deployments of etcd [1].
etcd relies on fsync for its consensus protocol.

 [1]: https://github.com/etcd-io/etcd/pull/11946
 [2]: https://etcd.io/docs/v3.5/tuning/#disk
 [3]: https://etcd.io/docs/v3.5/faq/

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2022-03-29 10:54:26 +02:00