Commit Graph

55 Commits

Author SHA1 Message Date
James Munnelly
1f3b883cfd Don't overwrite order.status.url if return Order's URI is empty
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
641fe0da7c Switch to using upstream golang.org/x/crypto
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
56b1fdd379 Make ACMEAuthorization.Wildcard a *bool
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:35:11 +01:00
James Munnelly
ef55bd5807 Mark Order & Challenge resources as Errored if 4xx error is received
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 09:30:17 +01:00
James Munnelly
9a807be80a Fix not returning updateErr if updating status failed
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
8bf08237f7 Migrate acmechallenges and acmeorders to use UpdateStatus
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
b6803a2185 Fully update challenge and order in controller sync instead of UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
James Munnelly
2868b4a7b7 Update pkg/controllers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-23 10:07:53 +01:00
James Munnelly
58754abf37 Refactor codebase for v1alpha2
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
20840b552d Remove deprecated code from acmeorders controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-19 13:07:59 +01:00
James Munnelly
ab06335078 Mark Order as failed if invalid data is returned from ACME server
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-10 14:46:55 +01:00
James Munnelly
ace5eebadc Rewrite and improve acmeorders controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-10 14:45:26 +01:00
James Munnelly
1da47b9e68 Add DisableDeprecatedACMECertificates feature gate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 16:17:59 +01:00
jetstack-bot
0b5f963bf9
Merge pull request #1884 from munnerz/order-csr-pem
Encode CSR on Order into PEM format and properly handle decoding
2019-07-12 17:00:38 +01:00
James Munnelly
c6ceea4e81 Encode CSR on Order into PEM format and properly handle decoding
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-12 14:00:46 +01:00
Michael Tsang
b717292090 Rewrite if/else for nil selector
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-07-10 17:09:26 +01:00
Michael Tsang
adfb8703c8 Fix bug where solver with no selector causes nil pointer
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-07-10 15:34:24 +01:00
James Munnelly
ed3efdebe0 orders: fire an Event when no acme solver matches an identifier being validated
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-04 22:14:35 +01:00
James Munnelly
e8c64e46cc Add support for dnsZones in solver selector
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 15:18:30 +02:00
James Munnelly
77d9891650 Rewrite challengeSpecForAuthorization function
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 15:18:30 +02:00
James Munnelly
fc24b9afc9 Add unit tests for challengeSpecForAuthorization function
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 15:17:17 +02:00
James Munnelly
20b1343c88 Remove use of klog from more places
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 14:30:41 +02:00
James Munnelly
442789113a Refactor controllers to not reference BaseController
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-19 15:11:06 +01:00
jetstack-bot
4c199c90ca
Merge pull request #1717 from dobesv/patch-2
Fix solver selection logic to return the selected solver rather than always returning the last one
2019-06-06 13:29:03 +01:00
jetstack-bot
edd2225002
Merge pull request #1692 from cheukwing/issue-1001
Add metric to count number of sync calls
2019-06-05 11:20:39 +01:00
Dobes Vandermeer
bd8cd5441a Fix address to reference array element
The address of a for loop created variable does not change between loops - the variable is over-written with each new variable.  This fixes the code so that `d` references the array element instead of the local variable, which means that when `d` is assigned to `matchAll` or `specificMatch` it will work as intended.

Signed-off-by: Dobes Vandermeer <dobesv@gmail.com>
2019-05-28 09:00:04 +01:00
Dobes Vandermeer
6d28bee388 Update matchAllDomainsNumLabels and numLabelsSpecificMatch
These variables seem like they should be updated when updating the thing they are supposed to be derived from.

Signed-off-by: Dobes Vandermeer <dobesv@gmail.com>
2019-05-24 09:57:53 +01:00
Michael Tsang
7d67ae466e Remove metrics field from controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 11:06:11 +01:00
Michael Tsang
455f6ebab4 Use ControllerName as label value
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 16:49:39 +01:00
Michael Tsang
f2e57a1c95 Add ControllerSyncCallCount metric
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 14:22:16 +01:00
James Munnelly
7945a6b6a8 Remove anonymous function
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 17:14:34 +01:00
James Munnelly
220d39c17d Update acmeorders controller to support both formats
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 14:24:00 +01:00
James Munnelly
2f30258f0e Switch to klog
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-22 12:34:02 +00:00
James Munnelly
c91833f43a Update order status if state changes will retrieving an existing certificate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-17 18:29:55 +00:00
James Munnelly
e88e4f4406 If an Order is already valid, attempt to retrieve existing certificate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-17 13:19:04 +00:00
James Munnelly
b1df71dd66 Retain Challenge resources for debugging if an Order enters an invalid state
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-11 14:04:23 +00:00
Daniel Morsing
cc946c0b45 Populate reason field regardless
If we have an error, then tell people about it.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:54:43 +00:00
Daniel Morsing
1b921b1583 remove more strict validation
Turns out the ACME server can respond with different codes than the ones listed

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:35:30 +00:00
Daniel Morsing
ba240bbe4e Add reason when an order/challenge gets marked invalid
When an ACME server tells us that a challenge or an order is invalid, it's helpful to get some information on why that's the case. Populate the reason field with the error information so that these issues can be more easily debugged.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:05:15 +00:00
James Munnelly
0fcc0c666c Update copyright header year
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-07 15:07:55 +00:00
jetstack-bot
f4e5203f1c
Merge pull request #1116 from munnerz/cleanup-challenges
CleanUp ACME challenges after issuing and on delete using finalizer
2018-11-29 15:07:17 +00:00
James Munnelly
34c3590052 Store a copy of the signed certificate on the Order resource after Finalize
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-29 12:11:42 +00:00
jetstack-bot
8f37cf6c40
Merge pull request #1117 from munnerz/wildcard-challenge-check
Include wildcard field in comparison of challenge specs
2018-11-29 11:26:17 +00:00
James Munnelly
dd8f98768b CleanUp ACME challenges after issuing and on delete using finalizer
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-28 22:05:47 +00:00
James Munnelly
2e066fdc57 Include wildcard field in comparison of challenge specs
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-28 21:31:21 +00:00
James Munnelly
a6b7cade09 Fix up event logging and add an extra event
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-28 19:16:59 +00:00
jetstack-bot
e0691e5827
Merge pull request #1060 from munnerz/orders-events
Add more Events to Orders and Challenges
2018-11-26 17:28:33 +00:00
James Munnelly
315a14ff70 Add more Events to Orders and Challenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-23 14:10:37 +00:00
James Munnelly
690b61fcbe Add Error type and mark order's as errored when creating fails
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-09 10:54:01 +00:00