weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

orders: fire an Event when no acme solver matches an identifier being validated

Browse Source 
Signed-off-by: James Munnelly <james@munnelly.eu>
This commit is contained in:
James Munnelly 2019-07-04 22:14:35 +01:00
parent dd1f8d4d5b
commit ed3efdebe0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/controller/acmeorders/sync.go
View File

@ -402,6 +402,7 @@ func (c *controller) createOrder(ctx context.Context, cl acmecl.Interface, issue
} else {
cs, err = challengeSpecForAuthorization(ctx, cl, issuer, o, authz)
if err != nil {
c.recorder.Eventf(o, corev1.EventTypeWarning, "NoMatchingSolver", "Failed to create challenge for domain %q: %v", authz.Identifier.Value, err)
return fmt.Errorf("error constructing Challenge resource for authorization: %v", err)
}
}
@ -574,7 +575,7 @@ func challengeSpecForAuthorization(ctx context.Context, cl acmecl.Interface, iss
}
if selectedSolver == nil || selectedChallenge == nil {
return nil, fmt.Errorf("failed to find matching challenge solver for challenge")
return nil, fmt.Errorf("no configured challenge solvers can be used for this challenge")
}
key, err := keyForChallenge(cl, selectedChallenge)