weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

e2e: remove annoying "Running with unsupported features: Ed25519"

Browse Source 
The messages "Running test suite with unsupported features: <list>" was
initially meant to remind us, in case of failure, why a given test would
be failing (i.e., it could be failing due to a set of supported features
too wide or too restrictive). This message should only show on failures;
as it is, it is not actionabe since it does not mention which issuer is
being tested. Removing this log line improves the user experience of
running the Ginkgo suite: the green dots, signifying a passing test, are
not interleaved with these messages.

Signed-off-by: Maël Valais <mael@vls.dev>
This commit is contained in:
Maël Valais 2022-03-06 13:35:44 +01:00
parent 5fad0e6de4
commit ebe3b39c65
3 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/e2e/suite/conformance/certificates/suite.go
View File

@ -17,8 +17,6 @@ limitations under the License.
package certificates
import (
"fmt"
. "github.com/onsi/ginkgo"
cmmeta "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"
@ -99,7 +97,6 @@ func (s *Suite) complete(f *framework.Framework) {
// it is called by the tests to in Define() to setup and run the test
func (s *Suite) it(f *framework.Framework, name string, fn func(cmmeta.ObjectReference), requiredFeatures ...featureset.Feature) {
if !s.checkFeatures(requiredFeatures...) {
fmt.Fprintln(GinkgoWriter, "skipping case due to unsupported features")
return
}
It(name, func() {

2
test/e2e/suite/conformance/certificates/tests.go
View File

@ -74,8 +74,6 @@ func (s *Suite) Define() {
}
})
By("Running test suite with the following unsupported features: " + s.UnsupportedFeatures.String())
s.it(f, "should issue a basic, defaulted certificate for a single distinct DNS Name", func(issuerRef cmmeta.ObjectReference) {
testCertificate := &cmapi.Certificate{
ObjectMeta: metav1.ObjectMeta{

2
test/e2e/suite/conformance/certificatesigningrequests/suite.go
View File

@ -18,7 +18,6 @@ package certificatesigningrequests
import (
"crypto"
"fmt"
. "github.com/onsi/ginkgo"
certificatesv1 "k8s.io/api/certificates/v1"
@ -105,7 +104,6 @@ func (s *Suite) complete(f *framework.Framework) {
// it is called by the tests to in Define() to setup and run the test
func (s *Suite) it(f *framework.Framework, name string, fn func(string), requiredFeatures ...featureset.Feature) {
if !s.checkFeatures(requiredFeatures...) {
fmt.Fprintln(GinkgoWriter, "skipping case due to unsupported features")
return
}
It(name, func() {