From ebe3b39c65653c8786eab4a08952266e72ed30a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Valais?= Date: Sun, 6 Mar 2022 13:35:44 +0100 Subject: [PATCH] e2e: remove annoying "Running with unsupported features: Ed25519" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The messages "Running test suite with unsupported features: " was initially meant to remind us, in case of failure, why a given test would be failing (i.e., it could be failing due to a set of supported features too wide or too restrictive). This message should only show on failures; as it is, it is not actionabe since it does not mention which issuer is being tested. Removing this log line improves the user experience of running the Ginkgo suite: the green dots, signifying a passing test, are not interleaved with these messages. Signed-off-by: Maël Valais --- test/e2e/suite/conformance/certificates/suite.go | 3 --- test/e2e/suite/conformance/certificates/tests.go | 2 -- test/e2e/suite/conformance/certificatesigningrequests/suite.go | 2 -- 3 files changed, 7 deletions(-) diff --git a/test/e2e/suite/conformance/certificates/suite.go b/test/e2e/suite/conformance/certificates/suite.go index 10c16b5fc..6b58c9f3e 100644 --- a/test/e2e/suite/conformance/certificates/suite.go +++ b/test/e2e/suite/conformance/certificates/suite.go @@ -17,8 +17,6 @@ limitations under the License. package certificates import ( - "fmt" - . "github.com/onsi/ginkgo" cmmeta "github.com/cert-manager/cert-manager/pkg/apis/meta/v1" @@ -99,7 +97,6 @@ func (s *Suite) complete(f *framework.Framework) { // it is called by the tests to in Define() to setup and run the test func (s *Suite) it(f *framework.Framework, name string, fn func(cmmeta.ObjectReference), requiredFeatures ...featureset.Feature) { if !s.checkFeatures(requiredFeatures...) { - fmt.Fprintln(GinkgoWriter, "skipping case due to unsupported features") return } It(name, func() { diff --git a/test/e2e/suite/conformance/certificates/tests.go b/test/e2e/suite/conformance/certificates/tests.go index 7400043ca..6f106f368 100644 --- a/test/e2e/suite/conformance/certificates/tests.go +++ b/test/e2e/suite/conformance/certificates/tests.go @@ -74,8 +74,6 @@ func (s *Suite) Define() { } }) - By("Running test suite with the following unsupported features: " + s.UnsupportedFeatures.String()) - s.it(f, "should issue a basic, defaulted certificate for a single distinct DNS Name", func(issuerRef cmmeta.ObjectReference) { testCertificate := &cmapi.Certificate{ ObjectMeta: metav1.ObjectMeta{ diff --git a/test/e2e/suite/conformance/certificatesigningrequests/suite.go b/test/e2e/suite/conformance/certificatesigningrequests/suite.go index 3e3f5d078..4fe7fc988 100644 --- a/test/e2e/suite/conformance/certificatesigningrequests/suite.go +++ b/test/e2e/suite/conformance/certificatesigningrequests/suite.go @@ -18,7 +18,6 @@ package certificatesigningrequests import ( "crypto" - "fmt" . "github.com/onsi/ginkgo" certificatesv1 "k8s.io/api/certificates/v1" @@ -105,7 +104,6 @@ func (s *Suite) complete(f *framework.Framework) { // it is called by the tests to in Define() to setup and run the test func (s *Suite) it(f *framework.Framework, name string, fn func(string), requiredFeatures ...featureset.Feature) { if !s.checkFeatures(requiredFeatures...) { - fmt.Fprintln(GinkgoWriter, "skipping case due to unsupported features") return } It(name, func() {