weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Code review feedback- better comment

Browse Source 
Signed-off-by: irbekrm <irbekrm@gmail.com>
This commit is contained in:
irbekrm 2023-01-05 17:42:40 +00:00
parent 8ed0faf228
commit eaf814cffa
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/issuer/acme/dns/rfc2136/provider.go
View File

@ -100,7 +100,11 @@ func (s *Solver) CleanUp(ch *whapi.ChallengeRequest) error {
func (s *Solver) Initialize(kubeClientConfig *restclient.Config, stopCh <-chan struct{}) error { func (s *Solver) Initialize(kubeClientConfig *restclient.Config, stopCh <-chan struct{}) error {
// Only start a secrets informerfactory if it is needed (if the solver // Only start a secrets informerfactory if it is needed (if the solver
// is not already initialized with a secrets lister) // is not already initialized with a secrets lister) This is legacy
// functionality. If you have a secrets watcher already available in the
// caller, you probably want to use that to avoid double caching the
// Secrets
// TODO: refactor and remove this functionality
if s.secretLister == nil { if s.secretLister == nil {
cl, err := kubernetes.NewForConfig(kubeClientConfig) cl, err := kubernetes.NewForConfig(kubeClientConfig)
if err != nil { if err != nil {