From eaf814cffa91bbe80aaa687934cd00bd54226812 Mon Sep 17 00:00:00 2001 From: irbekrm Date: Thu, 5 Jan 2023 17:42:40 +0000 Subject: [PATCH] Code review feedback- better comment Signed-off-by: irbekrm --- pkg/issuer/acme/dns/rfc2136/provider.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/issuer/acme/dns/rfc2136/provider.go b/pkg/issuer/acme/dns/rfc2136/provider.go index c9ef41012..874b8689d 100644 --- a/pkg/issuer/acme/dns/rfc2136/provider.go +++ b/pkg/issuer/acme/dns/rfc2136/provider.go @@ -100,7 +100,11 @@ func (s *Solver) CleanUp(ch *whapi.ChallengeRequest) error { func (s *Solver) Initialize(kubeClientConfig *restclient.Config, stopCh <-chan struct{}) error { // Only start a secrets informerfactory if it is needed (if the solver - // is not already initialized with a secrets lister) + // is not already initialized with a secrets lister) This is legacy + // functionality. If you have a secrets watcher already available in the + // caller, you probably want to use that to avoid double caching the + // Secrets + // TODO: refactor and remove this functionality if s.secretLister == nil { cl, err := kubernetes.NewForConfig(kubeClientConfig) if err != nil {