Merge pull request #382 from whereisaaron/patch-1

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Document common ingressShim.extraArgs use case in chart

**What this PR does / why we need it**:

Lots of new users don't realize:
(a) They need to create a Issuer/ClusterIssuer themselves
(b) They need to tell `ingress-shim` the name via `extra-args`
This PR adds a comment to the helm chart `values.yaml` to address these issues.

(Ideally the `helm` would create an ClusterIssuer for you by default, and set these options, if you specify and email address to use with LE.)

Release note:
```release-note
NONE
```

contrib/charts/cert-manager/Chart.yaml

@@ -1,5 +1,5 @@
 name: cert-manager
-version: 0.2.3
+version: 0.2.4
 appVersion: 0.2.3
 description: A Helm chart for cert-manager
 home: https://github.com/jetstack/cert-manager

contrib/charts/cert-manager/values.yaml

@@ -41,6 +41,10 @@ ingressShim:
 
   # Optional additional arguments for ingress-shim
   extraArgs: []
+    # Use these flags to specify the default Issuer/ClusterIssuer
+    # (IMPORTANT: You need to create this Issuer/ClusterIssuer resource yourself)
+    # - --default-issuer-name=letsencrypt-prod
+    # - --default-issuer-kind=ClusterIssuer
 
   resources: {}
     # requests:
@@ -59,4 +63,4 @@ ingressShim:
 # This is used by the static manifest generator in order to create a static
 # namespace manifest for the namespace that cert-manager is being installed
 # within. It should **not** be used if you are using Helm for deployment.
-createNamespaceResource: false
+createNamespaceResource: false

docs/deploy/rbac/certificate-crd.yaml

@@ -6,7 +6,7 @@ metadata:
   name: certificates.certmanager.k8s.io
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/rbac/clusterissuer-crd.yaml

@@ -6,7 +6,7 @@ metadata:
   name: clusterissuers.certmanager.k8s.io
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/rbac/deployment.yaml

@@ -7,7 +7,7 @@ metadata:
   namespace: "cert-manager"
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/rbac/issuer-crd.yaml

@@ -6,7 +6,7 @@ metadata:
   name: issuers.certmanager.k8s.io
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/rbac/rbac.yaml

@@ -6,7 +6,7 @@ metadata:
   name: cert-manager
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 rules:
@@ -31,7 +31,7 @@ metadata:
   name: cert-manager
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 roleRef:

docs/deploy/rbac/serviceaccount.yaml

@@ -7,6 +7,6 @@ metadata:
   namespace: "cert-manager"
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller

docs/deploy/without-rbac/certificate-crd.yaml

@@ -6,7 +6,7 @@ metadata:
   name: certificates.certmanager.k8s.io
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/without-rbac/clusterissuer-crd.yaml

@@ -6,7 +6,7 @@ metadata:
   name: clusterissuers.certmanager.k8s.io
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/without-rbac/deployment.yaml

@@ -7,7 +7,7 @@ metadata:
   namespace: "cert-manager"
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec:

docs/deploy/without-rbac/issuer-crd.yaml

@@ -6,7 +6,7 @@ metadata:
   name: issuers.certmanager.k8s.io
   labels:
     app: cert-manager
-    chart: cert-manager-0.2.3
+    chart: cert-manager-0.2.4
     release: cert-manager
     heritage: Tiller
 spec: