From 386a0ec54e4fe51fab95b17688e68638d90699f6 Mon Sep 17 00:00:00 2001 From: Aaron Roydhouse Date: Tue, 6 Mar 2018 00:19:05 -0500 Subject: [PATCH 1/4] Document common use case options in values.yaml Lots of new users don't realize: (a) They need to create a Issuer/ClusterIssuer themselves (b) They need to tell `ingress-shim` the name via `extra-args` (Ideally the `helm` would create an ClusterIssuer for you by default, and set these options, if you specify and email address to use with LE.) --- contrib/charts/cert-manager/values.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/charts/cert-manager/values.yaml b/contrib/charts/cert-manager/values.yaml index 300f77cac..6bdd1da10 100644 --- a/contrib/charts/cert-manager/values.yaml +++ b/contrib/charts/cert-manager/values.yaml @@ -41,6 +41,10 @@ ingressShim: # Optional additional arguments for ingress-shim extraArgs: [] + # Use these flags to specify the default Issuer/ClusterIssuer + # (IMPORTANT: You need to create this Issuer/ClusterIssuer resource yourself) + # - --default-issuer-name=letsencrypt-prod + # - --default-issuer-kind=ClusterIssuer resources: {} # requests: @@ -59,4 +63,4 @@ ingressShim: # This is used by the static manifest generator in order to create a static # namespace manifest for the namespace that cert-manager is being installed # within. It should **not** be used if you are using Helm for deployment. -createNamespaceResource: false \ No newline at end of file +createNamespaceResource: false From 0b5042c657da09fdc04a9ffa8ebe3c2eb0094c32 Mon Sep 17 00:00:00 2001 From: Aaron Roydhouse Date: Tue, 6 Mar 2018 00:20:11 -0500 Subject: [PATCH 2/4] Bump chart version for documentation update --- contrib/charts/cert-manager/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/charts/cert-manager/Chart.yaml b/contrib/charts/cert-manager/Chart.yaml index 135149201..1f677a47c 100644 --- a/contrib/charts/cert-manager/Chart.yaml +++ b/contrib/charts/cert-manager/Chart.yaml @@ -1,5 +1,5 @@ name: cert-manager -version: 0.2.2 +version: 0.2.3 appVersion: 0.2.3 description: A Helm chart for cert-manager home: https://github.com/jetstack/cert-manager From 96c4f9e1452c92ed057b11be774ebd113b6bb4cb Mon Sep 17 00:00:00 2001 From: Aaron Roydhouse Date: Fri, 9 Mar 2018 22:18:54 -0500 Subject: [PATCH 3/4] Run ./hack/update-deploy-gen.sh --- docs/deploy/rbac/certificate-crd.yaml | 2 +- docs/deploy/rbac/clusterissuer-crd.yaml | 2 +- docs/deploy/rbac/deployment.yaml | 2 +- docs/deploy/rbac/issuer-crd.yaml | 2 +- docs/deploy/rbac/rbac.yaml | 4 ++-- docs/deploy/rbac/serviceaccount.yaml | 2 +- docs/deploy/without-rbac/certificate-crd.yaml | 2 +- docs/deploy/without-rbac/clusterissuer-crd.yaml | 2 +- docs/deploy/without-rbac/deployment.yaml | 2 +- docs/deploy/without-rbac/issuer-crd.yaml | 2 +- 10 files changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/deploy/rbac/certificate-crd.yaml b/docs/deploy/rbac/certificate-crd.yaml index b997196da..495c8ef58 100644 --- a/docs/deploy/rbac/certificate-crd.yaml +++ b/docs/deploy/rbac/certificate-crd.yaml @@ -6,7 +6,7 @@ metadata: name: certificates.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/clusterissuer-crd.yaml b/docs/deploy/rbac/clusterissuer-crd.yaml index d0b999a5c..d4e00d035 100644 --- a/docs/deploy/rbac/clusterissuer-crd.yaml +++ b/docs/deploy/rbac/clusterissuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: clusterissuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/deployment.yaml b/docs/deploy/rbac/deployment.yaml index 333e77d9e..b90fcf075 100644 --- a/docs/deploy/rbac/deployment.yaml +++ b/docs/deploy/rbac/deployment.yaml @@ -7,7 +7,7 @@ metadata: namespace: "cert-manager" labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/issuer-crd.yaml b/docs/deploy/rbac/issuer-crd.yaml index f1fac860e..7b08030fd 100644 --- a/docs/deploy/rbac/issuer-crd.yaml +++ b/docs/deploy/rbac/issuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: issuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/rbac.yaml b/docs/deploy/rbac/rbac.yaml index 822ffa841..9a4532387 100644 --- a/docs/deploy/rbac/rbac.yaml +++ b/docs/deploy/rbac/rbac.yaml @@ -6,7 +6,7 @@ metadata: name: cert-manager labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller rules: @@ -31,7 +31,7 @@ metadata: name: cert-manager labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller roleRef: diff --git a/docs/deploy/rbac/serviceaccount.yaml b/docs/deploy/rbac/serviceaccount.yaml index 3f17c5cd4..830a573f6 100644 --- a/docs/deploy/rbac/serviceaccount.yaml +++ b/docs/deploy/rbac/serviceaccount.yaml @@ -7,6 +7,6 @@ metadata: namespace: "cert-manager" labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller \ No newline at end of file diff --git a/docs/deploy/without-rbac/certificate-crd.yaml b/docs/deploy/without-rbac/certificate-crd.yaml index b997196da..495c8ef58 100644 --- a/docs/deploy/without-rbac/certificate-crd.yaml +++ b/docs/deploy/without-rbac/certificate-crd.yaml @@ -6,7 +6,7 @@ metadata: name: certificates.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/without-rbac/clusterissuer-crd.yaml b/docs/deploy/without-rbac/clusterissuer-crd.yaml index d0b999a5c..d4e00d035 100644 --- a/docs/deploy/without-rbac/clusterissuer-crd.yaml +++ b/docs/deploy/without-rbac/clusterissuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: clusterissuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/without-rbac/deployment.yaml b/docs/deploy/without-rbac/deployment.yaml index 644fc22c9..97b323bc6 100644 --- a/docs/deploy/without-rbac/deployment.yaml +++ b/docs/deploy/without-rbac/deployment.yaml @@ -7,7 +7,7 @@ metadata: namespace: "cert-manager" labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/without-rbac/issuer-crd.yaml b/docs/deploy/without-rbac/issuer-crd.yaml index f1fac860e..7b08030fd 100644 --- a/docs/deploy/without-rbac/issuer-crd.yaml +++ b/docs/deploy/without-rbac/issuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: issuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.2 + chart: cert-manager-0.2.3 release: cert-manager heritage: Tiller spec: From 57f248ae9438389df26ee3f0a4cc580217701f33 Mon Sep 17 00:00:00 2001 From: Aaron Roydhouse Date: Fri, 9 Mar 2018 22:40:16 -0500 Subject: [PATCH 4/4] Bump chart version and run ./hack/update-deploy-gen.sh again --- contrib/charts/cert-manager/Chart.yaml | 2 +- docs/deploy/rbac/certificate-crd.yaml | 2 +- docs/deploy/rbac/clusterissuer-crd.yaml | 2 +- docs/deploy/rbac/deployment.yaml | 2 +- docs/deploy/rbac/issuer-crd.yaml | 2 +- docs/deploy/rbac/rbac.yaml | 4 ++-- docs/deploy/rbac/serviceaccount.yaml | 2 +- docs/deploy/without-rbac/certificate-crd.yaml | 2 +- docs/deploy/without-rbac/clusterissuer-crd.yaml | 2 +- docs/deploy/without-rbac/deployment.yaml | 2 +- docs/deploy/without-rbac/issuer-crd.yaml | 2 +- 11 files changed, 12 insertions(+), 12 deletions(-) diff --git a/contrib/charts/cert-manager/Chart.yaml b/contrib/charts/cert-manager/Chart.yaml index 1f677a47c..ceadde88f 100644 --- a/contrib/charts/cert-manager/Chart.yaml +++ b/contrib/charts/cert-manager/Chart.yaml @@ -1,5 +1,5 @@ name: cert-manager -version: 0.2.3 +version: 0.2.4 appVersion: 0.2.3 description: A Helm chart for cert-manager home: https://github.com/jetstack/cert-manager diff --git a/docs/deploy/rbac/certificate-crd.yaml b/docs/deploy/rbac/certificate-crd.yaml index 495c8ef58..c73549ef0 100644 --- a/docs/deploy/rbac/certificate-crd.yaml +++ b/docs/deploy/rbac/certificate-crd.yaml @@ -6,7 +6,7 @@ metadata: name: certificates.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/clusterissuer-crd.yaml b/docs/deploy/rbac/clusterissuer-crd.yaml index d4e00d035..86560332b 100644 --- a/docs/deploy/rbac/clusterissuer-crd.yaml +++ b/docs/deploy/rbac/clusterissuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: clusterissuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/deployment.yaml b/docs/deploy/rbac/deployment.yaml index b90fcf075..27721445f 100644 --- a/docs/deploy/rbac/deployment.yaml +++ b/docs/deploy/rbac/deployment.yaml @@ -7,7 +7,7 @@ metadata: namespace: "cert-manager" labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/issuer-crd.yaml b/docs/deploy/rbac/issuer-crd.yaml index 7b08030fd..3a7349ed7 100644 --- a/docs/deploy/rbac/issuer-crd.yaml +++ b/docs/deploy/rbac/issuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: issuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/rbac/rbac.yaml b/docs/deploy/rbac/rbac.yaml index 9a4532387..75ab3cc80 100644 --- a/docs/deploy/rbac/rbac.yaml +++ b/docs/deploy/rbac/rbac.yaml @@ -6,7 +6,7 @@ metadata: name: cert-manager labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller rules: @@ -31,7 +31,7 @@ metadata: name: cert-manager labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller roleRef: diff --git a/docs/deploy/rbac/serviceaccount.yaml b/docs/deploy/rbac/serviceaccount.yaml index 830a573f6..9d913c381 100644 --- a/docs/deploy/rbac/serviceaccount.yaml +++ b/docs/deploy/rbac/serviceaccount.yaml @@ -7,6 +7,6 @@ metadata: namespace: "cert-manager" labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller \ No newline at end of file diff --git a/docs/deploy/without-rbac/certificate-crd.yaml b/docs/deploy/without-rbac/certificate-crd.yaml index 495c8ef58..c73549ef0 100644 --- a/docs/deploy/without-rbac/certificate-crd.yaml +++ b/docs/deploy/without-rbac/certificate-crd.yaml @@ -6,7 +6,7 @@ metadata: name: certificates.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/without-rbac/clusterissuer-crd.yaml b/docs/deploy/without-rbac/clusterissuer-crd.yaml index d4e00d035..86560332b 100644 --- a/docs/deploy/without-rbac/clusterissuer-crd.yaml +++ b/docs/deploy/without-rbac/clusterissuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: clusterissuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/without-rbac/deployment.yaml b/docs/deploy/without-rbac/deployment.yaml index 97b323bc6..cfc5684ba 100644 --- a/docs/deploy/without-rbac/deployment.yaml +++ b/docs/deploy/without-rbac/deployment.yaml @@ -7,7 +7,7 @@ metadata: namespace: "cert-manager" labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: diff --git a/docs/deploy/without-rbac/issuer-crd.yaml b/docs/deploy/without-rbac/issuer-crd.yaml index 7b08030fd..3a7349ed7 100644 --- a/docs/deploy/without-rbac/issuer-crd.yaml +++ b/docs/deploy/without-rbac/issuer-crd.yaml @@ -6,7 +6,7 @@ metadata: name: issuers.certmanager.k8s.io labels: app: cert-manager - chart: cert-manager-0.2.3 + chart: cert-manager-0.2.4 release: cert-manager heritage: Tiller spec: