weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

PR comment: spelling

Browse Source 
Signed-off-by: Maël Valais <mael@vls.dev>
This commit is contained in:
Maël Valais 2021-03-03 15:18:49 +01:00
parent 680c7b75f6
commit ac325bf4e0
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/controller/certificates/trigger/policies/gatherer.go
View File

@ -53,11 +53,11 @@ type Gatherer struct {
//
// We need the "current" certificate request because this CR contains the
// "source of truth" of the current certificate, and getting the "current"
// CR allows is to check whether the current certificate still matches the
// CR allows us to check whether the current certificate still matches the
// already-issued certificate request.
//
// An error is returned when two certificate requests are found for the
// couple (certificate's revision, certificate's uid). This function does
// pair (certificate's revision, certificate's uid). This function does
// not return any apierrors.NewNotFound errors for either the secret or the
// certificate request. Instead, if either the secret or the certificate
// request is not found, the returned secret (respectively, certificate

3
pkg/controller/certificates/trigger/policies/gatherer_test.go
View File

@ -66,7 +66,6 @@ func TestDataForCertificate(t *testing.T) {
gen.AddCertificateRequestOwnerReferences(gen.CertificateRef("cert-1", "uid-9")),
),
},
ExpectedEvents: []string{},
},
givenCert: gen.Certificate("cert-1", gen.SetCertificateNamespace("default-unit-test-ns"),
gen.SetCertificateUID("uid-7"),
@ -146,7 +145,7 @@ func TestDataForCertificate(t *testing.T) {
// namespace instead of the non-empty expected namespace, or
// the lister is called with the right namespace and the fake
// clientset behaved as expected. In order to avoid the
// inconsistancy, we do make sure to have the right input
// inconsistency, we do make sure to have the right input
// argument being called.
//
// The problem with (2) is that not knowing if the call was