From ac325bf4e0b53a7ed0716440f744513adaef8505 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Valais?= Date: Wed, 3 Mar 2021 15:18:49 +0100 Subject: [PATCH] PR comment: spelling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Maël Valais --- pkg/controller/certificates/trigger/policies/gatherer.go | 4 ++-- pkg/controller/certificates/trigger/policies/gatherer_test.go | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/controller/certificates/trigger/policies/gatherer.go b/pkg/controller/certificates/trigger/policies/gatherer.go index 9e206386c..3d5931895 100644 --- a/pkg/controller/certificates/trigger/policies/gatherer.go +++ b/pkg/controller/certificates/trigger/policies/gatherer.go @@ -53,11 +53,11 @@ type Gatherer struct { // // We need the "current" certificate request because this CR contains the // "source of truth" of the current certificate, and getting the "current" -// CR allows is to check whether the current certificate still matches the +// CR allows us to check whether the current certificate still matches the // already-issued certificate request. // // An error is returned when two certificate requests are found for the -// couple (certificate's revision, certificate's uid). This function does +// pair (certificate's revision, certificate's uid). This function does // not return any apierrors.NewNotFound errors for either the secret or the // certificate request. Instead, if either the secret or the certificate // request is not found, the returned secret (respectively, certificate diff --git a/pkg/controller/certificates/trigger/policies/gatherer_test.go b/pkg/controller/certificates/trigger/policies/gatherer_test.go index e8e56d4bf..0eb3f7ed8 100644 --- a/pkg/controller/certificates/trigger/policies/gatherer_test.go +++ b/pkg/controller/certificates/trigger/policies/gatherer_test.go @@ -66,7 +66,6 @@ func TestDataForCertificate(t *testing.T) { gen.AddCertificateRequestOwnerReferences(gen.CertificateRef("cert-1", "uid-9")), ), }, - ExpectedEvents: []string{}, }, givenCert: gen.Certificate("cert-1", gen.SetCertificateNamespace("default-unit-test-ns"), gen.SetCertificateUID("uid-7"), @@ -146,7 +145,7 @@ func TestDataForCertificate(t *testing.T) { // namespace instead of the non-empty expected namespace, or // the lister is called with the right namespace and the fake // clientset behaved as expected. In order to avoid the - // inconsistancy, we do make sure to have the right input + // inconsistency, we do make sure to have the right input // argument being called. // // The problem with (2) is that not knowing if the call was