weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix CA CertificateSigningRequest controller to return potential error

Browse Source 
from updating failed status

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
This commit is contained in:
joshvanl 2021-06-07 17:48:49 +01:00
parent 590e01f3d0
commit abdd1f54fa
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/controller/certificatesigningrequests/ca/ca.go
View File

@ -123,7 +123,7 @@ func (c *CA) Sign(ctx context.Context, csr *certificatesv1.CertificateSigningReq
c.recorder.Event(csr, corev1.EventTypeWarning, "SigningError", message)
util.CertificateSigningRequestSetFailed(csr, "SigningError", message)
_, err = c.certClient.UpdateStatus(ctx, csr, metav1.UpdateOptions{})
return nil
return err
}
template.CRLDistributionPoints = issuerObj.GetSpec().CA.CRLDistributionPoints
@ -134,8 +134,8 @@ func (c *CA) Sign(ctx context.Context, csr *certificatesv1.CertificateSigningReq
message := fmt.Sprintf("Error signing certificate: %s", err)
c.recorder.Event(csr, corev1.EventTypeWarning, "SigningError", message)
util.CertificateSigningRequestSetFailed(csr, "SigningError", message)
_, err = c.certClient.UpdateStatus(ctx, csr, metav1.UpdateOptions{})
return nil
_, err := c.certClient.UpdateStatus(ctx, csr, metav1.UpdateOptions{})
return err
}
csr.Status.Certificate = bundle.ChainPEM