From abdd1f54fa8c59017750c253bee20b6b9adfea3a Mon Sep 17 00:00:00 2001 From: joshvanl Date: Mon, 7 Jun 2021 17:48:49 +0100 Subject: [PATCH] Fix CA CertificateSigningRequest controller to return potential error from updating failed status Signed-off-by: joshvanl --- pkg/controller/certificatesigningrequests/ca/ca.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/controller/certificatesigningrequests/ca/ca.go b/pkg/controller/certificatesigningrequests/ca/ca.go index ed8d9ba4b..b9f3e777a 100644 --- a/pkg/controller/certificatesigningrequests/ca/ca.go +++ b/pkg/controller/certificatesigningrequests/ca/ca.go @@ -123,7 +123,7 @@ func (c *CA) Sign(ctx context.Context, csr *certificatesv1.CertificateSigningReq c.recorder.Event(csr, corev1.EventTypeWarning, "SigningError", message) util.CertificateSigningRequestSetFailed(csr, "SigningError", message) _, err = c.certClient.UpdateStatus(ctx, csr, metav1.UpdateOptions{}) - return nil + return err } template.CRLDistributionPoints = issuerObj.GetSpec().CA.CRLDistributionPoints @@ -134,8 +134,8 @@ func (c *CA) Sign(ctx context.Context, csr *certificatesv1.CertificateSigningReq message := fmt.Sprintf("Error signing certificate: %s", err) c.recorder.Event(csr, corev1.EventTypeWarning, "SigningError", message) util.CertificateSigningRequestSetFailed(csr, "SigningError", message) - _, err = c.certClient.UpdateStatus(ctx, csr, metav1.UpdateOptions{}) - return nil + _, err := c.certClient.UpdateStatus(ctx, csr, metav1.UpdateOptions{}) + return err } csr.Status.Certificate = bundle.ChainPEM