Trim aws credentials for acme dns route53 provider

AWS credentials don't contain whitespace, and it's very easy to
accidentally include spaces or newlines at the end of secrets.
This commit is contained in:
Euan Kemp 2018-02-23 01:41:25 -08:00
parent cfa13a02df
commit 8aefbb1470

View File

@ -3,6 +3,7 @@ package dns
import (
"context"
"fmt"
"strings"
"time"
"github.com/golang/glog"
@ -152,8 +153,8 @@ func (s *Solver) solverFor(crt *v1alpha1.Certificate, domain string) (solver, er
}
impl, err = route53.NewDNSProviderAccessKey(
providerConfig.Route53.AccessKeyID,
string(secretAccessKeyBytes),
strings.TrimSpace(providerConfig.Route53.AccessKeyID),
strings.TrimSpace(string(secretAccessKeyBytes)),
providerConfig.Route53.HostedZoneID,
providerConfig.Route53.Region,
)