From 8aefbb14704de5977db00d2ee6d6dd4fa63de2d2 Mon Sep 17 00:00:00 2001
From: Euan Kemp <euank@euank.com>
Date: Fri, 23 Feb 2018 01:41:25 -0800
Subject: [PATCH] Trim aws credentials for acme dns route53 provider

AWS credentials don't contain whitespace, and it's very easy to
accidentally include spaces or newlines at the end of secrets.
---
 pkg/issuer/acme/dns/dns.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pkg/issuer/acme/dns/dns.go b/pkg/issuer/acme/dns/dns.go
index 644aec6bb..22ec1f71e 100644
--- a/pkg/issuer/acme/dns/dns.go
+++ b/pkg/issuer/acme/dns/dns.go
@@ -3,6 +3,7 @@ package dns
 import (
 	"context"
 	"fmt"
+	"strings"
 	"time"
 
 	"github.com/golang/glog"
@@ -152,8 +153,8 @@ func (s *Solver) solverFor(crt *v1alpha1.Certificate, domain string) (solver, er
 		}
 
 		impl, err = route53.NewDNSProviderAccessKey(
-			providerConfig.Route53.AccessKeyID,
-			string(secretAccessKeyBytes),
+			strings.TrimSpace(providerConfig.Route53.AccessKeyID),
+			strings.TrimSpace(string(secretAccessKeyBytes)),
 			providerConfig.Route53.HostedZoneID,
 			providerConfig.Route53.Region,
 		)