weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

link: BuildHTTPClient

Browse Source 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This commit is contained in:
Josh Soref 2025-02-04 13:37:18 -05:00
parent 97b99dbeca
commit 38ae9211fc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
design/20220614-timeouts.md
View File

@ -152,7 +152,7 @@ We propose to update the overall timeout for our HTTP clients for ACME requests
**not** to make this configurable by users.
As mentioned above, we already have HTTP timeouts on the HTTP clients we build for use with ACME clients, as seen
[here](https://github.com/cert-manager/cert-manager/blob/e116d416f3b14863d05753739cbdf72d66923357/pkg/acme/accounts/client.go#L58-L75).
in [`BuildHTTPClient`](https://github.com/cert-manager/cert-manager/blob/e116d416f3b14863d05753739cbdf72d66923357/pkg/acme/accounts/client.go#L58-L75).
The dialer and TLS handshake timeouts are set to 30 and 10 seconds respectively, and both are likely fine to keep as
they are and in any case unlikely to be a problem for people experiencing the issues detailed in [#5080](https://github.com/cert-manager/cert-manager/issues/5080).