From 38ae9211fc3e30a51341a6cc6468154e2bfb40df Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Tue, 4 Feb 2025 13:37:18 -0500 Subject: [PATCH] link: BuildHTTPClient Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- design/20220614-timeouts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/design/20220614-timeouts.md b/design/20220614-timeouts.md index ee28f2faa..9fe454fe3 100644 --- a/design/20220614-timeouts.md +++ b/design/20220614-timeouts.md @@ -152,7 +152,7 @@ We propose to update the overall timeout for our HTTP clients for ACME requests **not** to make this configurable by users. As mentioned above, we already have HTTP timeouts on the HTTP clients we build for use with ACME clients, as seen -[here](https://github.com/cert-manager/cert-manager/blob/e116d416f3b14863d05753739cbdf72d66923357/pkg/acme/accounts/client.go#L58-L75). +in [`BuildHTTPClient`](https://github.com/cert-manager/cert-manager/blob/e116d416f3b14863d05753739cbdf72d66923357/pkg/acme/accounts/client.go#L58-L75). The dialer and TLS handshake timeouts are set to 30 and 10 seconds respectively, and both are likely fine to keep as they are and in any case unlikely to be a problem for people experiencing the issues detailed in [#5080](https://github.com/cert-manager/cert-manager/issues/5080).