weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #543 from munnerz/fix-panic

Browse Source 
Fix panic in shouldAttemptValidation
This commit is contained in:
jetstack-bot 2018-05-09 13:11:19 +01:00 committed by GitHub
commit 28d8085d36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/issuer/acme/prepare.go
View File

@ -444,7 +444,11 @@ func (a *Acme) shouldAttemptValidation(ctx context.Context, cl client.Interface,
Type: v1alpha1.CertificateConditionValidationFailed,
Status: v1alpha1.ConditionTrue,
}) {
crt.UpdateStatusCondition(v1alpha1.CertificateConditionValidationFailed, v1alpha1.ConditionTrue, "OrderFailed", fmt.Sprintf("Order failed: %v", order.Error.Error()), true)
var extraText = ""
if order.Error != nil {
extraText = fmt.Sprintf(": %v", order.Error.Error())
}
crt.UpdateStatusCondition(v1alpha1.CertificateConditionValidationFailed, v1alpha1.ConditionTrue, "OrderFailed", "Order status is invalid"+extraText, true)
}
// we know that we'll be able to find the appropriate condition because