From a597c02701c837ac1ec86de76df1153159cd1bcf Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Wed, 9 May 2018 12:11:41 +0100 Subject: [PATCH] Fix panic in shouldAttemptValidation --- pkg/issuer/acme/prepare.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/issuer/acme/prepare.go b/pkg/issuer/acme/prepare.go index f6d85a3a4..fed36c5f4 100644 --- a/pkg/issuer/acme/prepare.go +++ b/pkg/issuer/acme/prepare.go @@ -444,7 +444,11 @@ func (a *Acme) shouldAttemptValidation(ctx context.Context, cl client.Interface, Type: v1alpha1.CertificateConditionValidationFailed, Status: v1alpha1.ConditionTrue, }) { - crt.UpdateStatusCondition(v1alpha1.CertificateConditionValidationFailed, v1alpha1.ConditionTrue, "OrderFailed", fmt.Sprintf("Order failed: %v", order.Error.Error()), true) + var extraText = "" + if order.Error != nil { + extraText = fmt.Sprintf(": %v", order.Error.Error()) + } + crt.UpdateStatusCondition(v1alpha1.CertificateConditionValidationFailed, v1alpha1.ConditionTrue, "OrderFailed", "Order status is invalid"+extraText, true) } // we know that we'll be able to find the appropriate condition because