weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Updates code comment

Browse Source 
Signed-off-by: irbekrm <irbekrm@gmail.com>
This commit is contained in:
irbekrm 2023-03-29 14:01:28 +01:00
parent 0964d6d03d
commit 202d75ffe6
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/controller/acmeorders/sync.go
View File

@ -189,9 +189,14 @@ func (c *controller) Sync(ctx context.Context, o *cmacme.Order) (err error) {
switch {
case anyChallengesFailed(challenges):
// TODO (@munnerz): instead of waiting for the ACME server to mark this
// Order as failed, we could just mark the Order as failed as there is
// no way that we will attempt and continue the order anyway.
// TODO (@munnerz): instead of waiting for the ACME server to
// mark this Order as failed, we could just mark the Order as
// failed as there is no way that we will attempt and continue
// the order anyway. This might, however, be a breaking change
// in edge cases where the status of the order resource in ACME
// server cannot be determined from challenge resource statuses
// correctly. Do not change this unless there is a real need for
// it.
log.V(logf.DebugLevel).Info("Update Order status as at least one Challenge has failed")
_, err := c.updateOrderStatusFromACMEOrder(ctx, cl, o, acmeOrder)
if acmeErr, ok := err.(*acmeapi.Error); ok {