From 202d75ffe6221ead6deec1b2bbb4bda0a67e2ce3 Mon Sep 17 00:00:00 2001 From: irbekrm Date: Wed, 29 Mar 2023 14:01:28 +0100 Subject: [PATCH] Updates code comment Signed-off-by: irbekrm --- pkg/controller/acmeorders/sync.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/pkg/controller/acmeorders/sync.go b/pkg/controller/acmeorders/sync.go index 57fa872bd..afb5fa7b6 100644 --- a/pkg/controller/acmeorders/sync.go +++ b/pkg/controller/acmeorders/sync.go @@ -189,9 +189,14 @@ func (c *controller) Sync(ctx context.Context, o *cmacme.Order) (err error) { switch { case anyChallengesFailed(challenges): - // TODO (@munnerz): instead of waiting for the ACME server to mark this - // Order as failed, we could just mark the Order as failed as there is - // no way that we will attempt and continue the order anyway. + // TODO (@munnerz): instead of waiting for the ACME server to + // mark this Order as failed, we could just mark the Order as + // failed as there is no way that we will attempt and continue + // the order anyway. This might, however, be a breaking change + // in edge cases where the status of the order resource in ACME + // server cannot be determined from challenge resource statuses + // correctly. Do not change this unless there is a real need for + // it. log.V(logf.DebugLevel).Info("Update Order status as at least one Challenge has failed") _, err := c.updateOrderStatusFromACMEOrder(ctx, cl, o, acmeOrder) if acmeErr, ok := err.(*acmeapi.Error); ok {