github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#13335] Fix new overloads

Browse Source 
Some new aliasing overloads must not be overridden, but delegate to the version that has ubiquitous overrides: as(Name) and as(Name, Name...). Otherwise, there might be missing parentheses and other rendering errors in derived tables, etc.
This commit is contained in:
Lukas Eder 2022-03-24 15:06:31 +01:00
parent ec55af2b81
commit d2e6fda89c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jOOQ/src/main/java/org/jooq/impl/AbstractTable.java
View File

@ -367,12 +367,12 @@ abstract class AbstractTable<R extends Record> extends AbstractNamed implements
}
@Override
public /* non-final for covariant overriding */ Table<R> as(String alias, String... fieldAliases) {
public final Table<R> as(String alias, String... fieldAliases) {
return as(DSL.name(alias), Tools.names(fieldAliases));
}
@Override
public /* non-final for covariant overriding */ Table<R> as(String alias, Collection<? extends String> fieldAliases) {
public final Table<R> as(String alias, Collection<? extends String> fieldAliases) {
return as(DSL.name(alias), Tools.names(fieldAliases));
}
@ -397,8 +397,8 @@ abstract class AbstractTable<R extends Record> extends AbstractNamed implements
}
@Override
public /* non-final for covariant overriding */ Table<R> as(Name alias, Collection<? extends Name> fieldAliases) {
return new TableAlias<>(this, alias, fieldAliases == null ? null : fieldAliases.toArray(EMPTY_NAME));
public final Table<R> as(Name alias, Collection<? extends Name> fieldAliases) {
return as(alias, fieldAliases == null ? null : fieldAliases.toArray(EMPTY_NAME));
}
@Override