From d2e6fda89c0e4e73b80e295dce6fb72f3be9d878 Mon Sep 17 00:00:00 2001
From: Lukas Eder <lukas.eder@gmail.com>
Date: Thu, 24 Mar 2022 15:06:31 +0100
Subject: [PATCH] [jOOQ/jOOQ#13335] Fix new overloads

Some new aliasing overloads must not be overridden, but delegate to the version that has ubiquitous overrides: as(Name) and as(Name, Name...). Otherwise, there might be missing parentheses and other rendering errors in derived tables, etc.
---
 jOOQ/src/main/java/org/jooq/impl/AbstractTable.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractTable.java b/jOOQ/src/main/java/org/jooq/impl/AbstractTable.java
index 7e51811885..95747aed25 100644
--- a/jOOQ/src/main/java/org/jooq/impl/AbstractTable.java
+++ b/jOOQ/src/main/java/org/jooq/impl/AbstractTable.java
@@ -367,12 +367,12 @@ abstract class AbstractTable<R extends Record> extends AbstractNamed implements
     }
 
     @Override
-    public /* non-final for covariant overriding */ Table<R> as(String alias, String... fieldAliases) {
+    public final Table<R> as(String alias, String... fieldAliases) {
         return as(DSL.name(alias), Tools.names(fieldAliases));
     }
 
     @Override
-    public /* non-final for covariant overriding */ Table<R> as(String alias, Collection<? extends String> fieldAliases) {
+    public final Table<R> as(String alias, Collection<? extends String> fieldAliases) {
         return as(DSL.name(alias), Tools.names(fieldAliases));
     }
 
@@ -397,8 +397,8 @@ abstract class AbstractTable<R extends Record> extends AbstractNamed implements
     }
 
     @Override
-    public /* non-final for covariant overriding */ Table<R> as(Name alias, Collection<? extends Name> fieldAliases) {
-        return new TableAlias<>(this, alias, fieldAliases == null ? null : fieldAliases.toArray(EMPTY_NAME));
+    public final Table<R> as(Name alias, Collection<? extends Name> fieldAliases) {
+        return as(alias, fieldAliases == null ? null : fieldAliases.toArray(EMPTY_NAME));
     }
 
     @Override