github/jooq
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[jOOQ/jOOQ#10931] LIMIT without OFFSET is emulated using window functions when value is not a bind variable

Browse Source
This commit is contained in:
Lukas Eder 2020-11-13 09:52:59 +01:00
parent 67e0d284f9
commit 574370f1ee
2 changed files with 0 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
jOOQ/src/main/java/org/jooq/impl/Limit.java
View File

@ -90,7 +90,6 @@ final class Limit extends AbstractQueryPart {
Param<?> offset;
private Param<?> offsetOrZero = ZERO;
private Param<?> offsetPlusOne = ONE;
private boolean rendersParams;
boolean withTies;
boolean percent;
@ -435,17 +434,6 @@ final class Limit extends AbstractQueryPart {
return offset != null || numberOfRows != null;
}
/**
* Whether this LIMIT clause renders {@link Param} objects. This indicates
* to the <code>SELECT</code> statement, that it may need to prefer
* <code>ROW_NUMBER()</code> filtering over a <code>TOP</code> clause to
* allow for named parameters in the query, as the <code>TOP</code> clause
* may not accept bind variables.
*/
final boolean rendersParams() {
return rendersParams;
}
final void setOffset(Number offset) {
this.offset = val(offset.longValue(), BIGINT);
this.offsetOrZero = this.offset;
@ -455,7 +443,6 @@ final class Limit extends AbstractQueryPart {
final void setOffset(Param<?> offset) {
this.offset = offset;
this.offsetOrZero = offset;
this.rendersParams = rendersParams |= offset.isInline();
}
final void setNumberOfRows(Number numberOfRows) {
@ -466,7 +453,6 @@ final class Limit extends AbstractQueryPart {
final void setNumberOfRows(Param<?> numberOfRows) {
this.numberOfRows = numberOfRows;
this.numberOfRowsOrMax = numberOfRows;
this.rendersParams |= numberOfRows.isInline();
}
final Long getNumberOfRows() {

19
jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
View File

@ -1430,14 +1430,6 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
@ -2762,17 +2754,6 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp