From 574370f1ee5632be84bd8bfd8bfd08d9b7019330 Mon Sep 17 00:00:00 2001
From: Lukas Eder <lukas.eder@gmail.com>
Date: Fri, 13 Nov 2020 09:52:59 +0100
Subject: [PATCH] [jOOQ/jOOQ#10931] LIMIT without OFFSET is emulated using
 window functions when value is not a bind variable

---
 jOOQ/src/main/java/org/jooq/impl/Limit.java   | 14 --------------
 .../java/org/jooq/impl/SelectQueryImpl.java   | 19 -------------------
 2 files changed, 33 deletions(-)

diff --git a/jOOQ/src/main/java/org/jooq/impl/Limit.java b/jOOQ/src/main/java/org/jooq/impl/Limit.java
index 77a8c0e734..5cab6ba694 100644
--- a/jOOQ/src/main/java/org/jooq/impl/Limit.java
+++ b/jOOQ/src/main/java/org/jooq/impl/Limit.java
@@ -90,7 +90,6 @@ final class Limit extends AbstractQueryPart {
     Param<?>                            offset;
     private Param<?>                    offsetOrZero      = ZERO;
     private Param<?>                    offsetPlusOne     = ONE;
-    private boolean                     rendersParams;
     boolean                             withTies;
     boolean                             percent;
 
@@ -435,17 +434,6 @@ final class Limit extends AbstractQueryPart {
         return offset != null || numberOfRows != null;
     }
 
-    /**
-     * Whether this LIMIT clause renders {@link Param} objects. This indicates
-     * to the <code>SELECT</code> statement, that it may need to prefer
-     * <code>ROW_NUMBER()</code> filtering over a <code>TOP</code> clause to
-     * allow for named parameters in the query, as the <code>TOP</code> clause
-     * may not accept bind variables.
-     */
-    final boolean rendersParams() {
-        return rendersParams;
-    }
-
     final void setOffset(Number offset) {
         this.offset = val(offset.longValue(), BIGINT);
         this.offsetOrZero = this.offset;
@@ -455,7 +443,6 @@ final class Limit extends AbstractQueryPart {
     final void setOffset(Param<?> offset) {
         this.offset = offset;
         this.offsetOrZero = offset;
-        this.rendersParams = rendersParams |= offset.isInline();
     }
 
     final void setNumberOfRows(Number numberOfRows) {
@@ -466,7 +453,6 @@ final class Limit extends AbstractQueryPart {
     final void setNumberOfRows(Param<?> numberOfRows) {
         this.numberOfRows = numberOfRows;
         this.numberOfRowsOrMax = numberOfRows;
-        this.rendersParams |= numberOfRows.isInline();
     }
 
     final Long getNumberOfRows() {
diff --git a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
index 938fe02b3d..889c943e1b 100644
--- a/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
+++ b/jOOQ/src/main/java/org/jooq/impl/SelectQueryImpl.java
@@ -1430,14 +1430,6 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
 
 
 
-
-
-
-
-
-
-
-
 
 
 
@@ -2762,17 +2754,6 @@ final class SelectQueryImpl<R extends Record> extends AbstractResultQuery<R> imp
 
 
 
-
-
-
-
-
-
-
-
-
-
-