* ignore result of function
* changelog
* Add g++5 to CI legs
* use inline config for g++ 5
* update flag
* set default values for variables
* fix format
* Stress test deployment script resiliency fixes
* Use PSModule-Helpers to install powershell-yaml
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* More logging, faster matrix
* Verbose makefile
* Add code that is expected to cause failure
* Use clang with Ubuntu 20
* Install clang-format-11 in another step
* Revert "Add code that is expected to cause failure"
This reverts commit 7ff7201e1b81e17c168b7598f0d23c489b5e6f43.
* Remove cmake args, add build args -j
* Attempt to purge all vaults, managed HSMs
Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
* Add timeout and more logging
* Pass required -Resource
* Fix log message
* Ensure the $Resource is correctly captured
Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.
* Add -ErrorAction to Receive-Job
Worked without terminating when run locally, but failed on the first error in the AzDO agent.
* Use $using:r instead of creating ScriptBlock
More idiomatic for passing ScriptBlocks to jobs.
* Resolve PR feedback
* Change default DeleteAfterHours to 120
Resolves#1917
* Use the Az cmdlets built-in -AsJob
Co-authored-by: Heath Stewart <heaths@microsoft.com>
- Fix rg.Name to rg.ResourceGroupName
- Add more verbose logging for better debugging
- Handle deleted resource groups when gathering puragable resource
- Remove coerce now that we are collecting in functions
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Deploy for stress tests at resource group scope
* Automatically compile bicep files in stress test deploy script
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Explicitly add '/*' '!/*/' to the list of paths so we include
the files in the root of the repo.
Added some extra command logging so we can easily repro locally without
needing to find the code that ran.
Update to '/eng' so that we only get paths that start with eng instead
of every path that has eng as a folder.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Support building and deploying bicep templates
* Add bicep powershell install aka link to deployment error message
* Write bicep compiled arm templates to temp directory
* Simplify bicep building code/function usage
* Use bicep location for compiled arm templates, and remove them on success
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Update change log headers based on guideline update
Updates based on https://github.com/Azure/azure-sdk/pull/3103
- Renamed "Key Bugs Fixed" to "Bugs Fixed"
- Renamed "Fixed" to "Other Changes"
Added a warning in validation if at lease one of the recommended
headers aren't used.
* Update eng/common/scripts/ChangeLog-Operations.ps1
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
* Put dependency versions
* Update version
* Core does not have any 1.1 functionality
* Core 1.1
* 1.1.0
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add dependency on LiveTest to release
* Add DependsOn to archetype-cpp-release.yml stages, conditions around LiveTest (if we don't execute live tests don't require them for release)
* Remove template conditions for LiveTest and always require it
* Revert "Remove template conditions for LiveTest and always require it"
This reverts commit dc0615ca084b7bb476cbc3806df70f92f2bf0304.
* Bring changes from JS docs metadata
* Move business logic inside Update-DocsMsMetadata.ps1
* Update with the latest changes in JS PR
* Update from latest PR feedback
* Add check for empty path to prevent crashes when creating relative paths
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
- Switch to using rest instead of cli for querying work items
as cli is limited to 1000 items only.
- Fix issues with Generated fields not being set.
- Correctly sort older workitems by version isntead of string.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Check for API review status only if release date is set in changelog
* Change property name to ReleaseStatus
Co-authored-by: Praveen Kuttappan <praveen.kuttappan@gmail.com>
* Update pipeline generation tool version
Consume latest changes from pipeline generation tool in https://github.com/Azure/azure-sdk-tools/pull/1708
* Update tool version to include fix for public ci
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* vcpkg.json -- update all links to point to "main" .. This is hardcoded and will go out in future releases.
* ci.yml -- add `- main` to trigger criteria near `- master` ... This adds forward compatilbitiy when we rename the branch in the repo
* archetype-cpp-release.yml use a script which evaluates a repo's default branch and sets that in a global variable, then use that variable instead. When vcpkg updates their branch the publishing scripts will work transparently.
* Collect-Changelogs.ps1 -- Add default hardcoded branch name for use with future releases. This can be optionally overridden with a parameter when invoking the script.
* eng/pipelines/client.yml -- Delete this file. It is no longer in use.
* Add API status check
* Revert temp change
* Update as per review comments
* Removed blank line
* Review comments to use az cli
* Changes to move az cli commands to caller script and other review comments
* Skip languages that's not supported in APIView
* Fix bug in language mapping
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
- Remove copied AzPowershell utilities
- Add latest AZ module path already on hosted agents to PSModulePath
- Rename setup-az-modules template setup-environments to reflect what is is doing
- Add support for Caching the current user PS Module folder
- Add support for install-module if not already present in module folder
- Organize the live test clean-up script to be in the standard location
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Update common engineering system for docs onboarding
* Add updates from review feedback
* Space nit
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.
Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.
> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`
CSpell: Files checked: 188, Issues found: 0 in 0 files
> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`
CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)
> `cspell lint --config .vscode/cspell.json *.md */**/*.md`
CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)
> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`
CSpell: Files checked: 44, Issues found: 0 in 0 files
> `cspell lint --config .vscode/cspell.json *.* */**/*`
CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)
Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
DevOps helper scripts were updated in azure-sdk repo
so syncing those changes into the tools repo so they
can be used prepare-release script.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
This will allow us to point our verify-link script at a raw
MD file in a github repo and have it parsed correctly for
links.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Use linux for vcpkg release
* Force lf line endings
* Set config correctly
* Better core.eol syntax and sequencing
* Try using linux host which uses LF by default
* Revert "Try using linux host which uses LF by default"
This reverts commit 160eb22b647e851a50f9d1e7b157a1e385fe946f.
* Use vcpkg.exe to format the manifest
* Spell correctly
* Move format-manfiest
- Update link checking pipeline to enable caching
- Add loading cache file from a http endpoint
- Add retry logic when hitting 429
Fix verify link renaming scenarios
- Correctly error if link format is incorrect
- Handle case where the replace regex is not passed
- Improve the error logging so it is easier to
identify the broken links
- This removes the ci.yml filtering which means all projects can be discovered
- This eliminates the need for the yml parsing module for most common scenarios
- This does introduce some potential issues with duplicate package names for
languages like java. The only known case currently is azure-storage-blobs and
if there is ever a need to explicitly pick the correct one someone can pass
in the ServiceDirectory filter similar to "storage/azure*" for new and "storage/microsoft*"
for the older sdk. By default azure usually comes first so the new one gets discovered
which is likely all we need for now. If this turns out not to be true we might
need another way to disambiguate.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update vcpkg ports to use a manifest json file instead of a CONTROL file.
* Update vcpkg ports to use a manifest json file instead of a CONTROL file
for remaining packages.
* Add the new vcpkg manifet json files and also update the template
package.
* Update paths in the cmake and eng scripts to find the right file now
that CONTROL is gone.
* Handle empty files in Test-SampleMetadata
Relates to Azure/azure-sdk-for-java#20684
* Remove condition from verify-samples
* Use forward slash in path
* Fix directory typo
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Verify samples during CIs
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
* Move exit to proper scope
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Remove passing -Mode Complete to deployment
When passing Complete it will remove any resources
already in the resource group that weren't part
of the current deployment. That removal breaks a
lot of assumptions, like multiple deployments when
testing things like smoke-tests or if you are reusing
an existing resource group. We don't want that to happen.
* Remove ServiceDirectory as required parameter for remove/update
When this was made mandatory it broke some usages which didn't
pass the value. Those usages don't need to pass it because
the pass required information in other ways so removing the
requirement for the parameter to be passed.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Initializing the BaseName with a ServiceDirectory that contains
a "/", because it is a multiple level path, causes the BaseName
initialization code to fail because it doesn't support the
validation pattern.
In all the known cases we already pass the ResourceGroupName
explicitly so don't need to set the BaseName so we can
skip the initialization in those cases.
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Use SubscriptionId throughout TestResources
Fixes#1454
* Resolve PR feedback
* Default DeleteAfterHours to 48 for SDK team
Also makes a few other adjustments for subscriptions, like restoring the previous one if available and another was specified.
* Resolve PR feedback
* Change deployment mode to Complete
Also fixes an issue where if the user opted not to deploy to the same resource group, the script would continue execution anyway.
* Use consistent aka links to satisfy link checker
Only need it for the new Update-TestResources.ps1 script, but I wanted them to look consistent.
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Fix issue where 2d index arrays with length 1 get flattened by powershell
* Pass NonSparseParameters to imported matrix generation
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Add chagelogpath to Update-ChangeLog.ps1
* Make PackageName and ServiceDirectory not mandatory, test ChangelogPath
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
* Handle null values when generating display names
* Fix issue processing matrices where the base matrix is only an import
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Fixup CHANGELOG.md, add SetPackageVersion, add calls to set-test-pipeline-version.yml
* Run set-test-pipeline-version.yml per artifact, open testpipeline as draft
* git diff to view changes in file
* Move set-test-pipeline-version.yml after Validate Clang Format
* remove second artifact loop in archetype-cpp-release.yml
* Add 'replace' support. Improve handling of dynamic parameter types.
* Support display name import and overrides
* Support regex capture groups for replace. Force fully matching regex.
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Pull only artifacts from `ci.yml` to resolve issue with conflicting package names.
Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
* Update Package Properties Logic, make prepare release require only 1 argument, make rerun of Get-PkgProperties in Update-Changelog not required
* Remove ServiceDirectory parameter from PrepareRelease.ps1
* changes to argument names
* pass service directory to Get-AllPackageInfoFromRepo
* Remove changes in Update-ChangeLog.ps1
* updates to Package-Properties.ps1
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Chidozie Ononiwu <31145988+chidozieononiwu@users.noreply.github.com>
* Create a publish-artifact.yml template step within eng/common. This template utilizes PublishPipelineArtifactV1 to upload your artifact only in the case where steps up till the invocation are succeeded(). Otherwise, the artifacts will be uploaded to an alternate artifact name.
* Validate publishing before parameter refactor
Fix release yaml syntax
Environment variable naming
Remove flag
Remove checkout step
Reset the commit
Cleanup Update-VcpkgPort.ps1, mostly git reset HEAD^. Attempt to check out branch in remote.
Try putting CHANGELOG entry into commit message
Include common.ps1 for changelog operations
Correct path for common.ps1
Include the scripts folder as well
Quotes
Refactor to use release artifacts, perform the commit in Update-VcpkgPort.ps1, set parameters and variables needed to complete PR with the commit step already finished
* Add PR body
* Add newline
* Added more logging to API view create
* Updated logs with arch board rescue email address
* Fix as per review comments
* Update logging to show API URL
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
- Remove BuildType parameter as we can default it from package properties
- Stop passing BuildType and GroupId and instead defaul them from package properties
- Enable StrictMode to help identify potential errors
- Start passing sdktype and isnewsdk properties to devops script
- Sync latest changes with devops work item to fix a couple bugs
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Add common tools for spell check
* Updates from further iteration
* Review feedback: Add check for git as well
* Review feedback * Use common approach to resolving base branch name * Eliminate default base branch "master" as this will be changed later, providing no default and using a mandatory parameter means a dev must provide the value * Check for existence of $CspellConfigPath * No need to Set-Location if run from the root of the repo (most common scenario) * -join
* Review feedback: Rename TargetRef -> TargetBranch, add SourceBranch, Add reference to spelling docs, exit 0, Rename to check-spelling-in-changed-files.ps1,
* Review feedback: Remove ValidateNotNullOrEmpty (we do more definitive validation farther down that will also catch these errors), Update comments and script name
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Change other version to all versions
* Exclude the packages which already show up in latest GA and preview
* Update main.js
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* Create package property file using artifact name
* Add option to pass config file dir
* Set default config file directory to avoid script execution failure
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Improve TestResources docs and logging
Resolves#1388Resolves#1407
Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.
* Add ADP test sub to look-up
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Hide the package which set to true instead of putting to Other page
* Hide the package not showing in csv
* Added logging message
* fix the variable
* leave an extra space
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Add azure-template2 to validate publishing multiple packages to vcpkg
* Update versions to avoid release conflict
* Add custom port naming logic
* fix changelogs
* compute path
* Add azure-core-cpp dependency back in
* package name in control file
* Add changes to support vcpkg x-add-version
* Add azure-sdk identity to commit
* Remove old conditions/comments and use -am for commit
* remove -c parameters
* Use --author
* git config local
* space
* work around HasChanges=false
* Bump versions for verification
* Bump versions, update portfile to use azure-template2-cpp ref
* Add PackageVersion
* Revert template2
* Finish reverting template2
* Revert "Finish reverting template2"
This reverts commit aa1461facbdb7ebd1e0ad2d90f8fe5a7c9db9473.
* Revert "Revert template2"
This reverts commit 3a91e82e01e2d1610da0747c2c84e24f52105625.
* Commit without setting user.name and user.email
* bump version
* git commands on same line
* Revert "Revert "Revert template2""
This reverts commit 1721a626e3c2e2b8c43dfe4a2fedf5a891c58793.
* Revert "Revert "Finish reverting template2""
This reverts commit 461a57c14aee97c9b6f83c79fe3a74122c890fb2.
* Finish reverting template2
- Sync devops helper script changes
- Fix issue in SemVer script when using strict mode with Language not set
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Support sub directory for artifact location
* Fix as per review comment to avoid artifact sub path
* Package property file is not created for track1 and management pacakges.
* Fix property name case
* Fix as per review comments
* Fix as per review comments
* Use Config File param value as is
* Change to make path joineasily readable
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Add bypass-local-dns.yml to CI and test jobs
* Remove from client builds. Use of pools does not set variables needed for this to run. The fix may belong in another change.
* release mode test for Linux with test
* Fix GCC warning when building in Release configuration
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Use a helper function to normalize the package name for readme
* Get the readme name from artifact-metadata-parsing
* Change to the readme
* Update eng/common/scripts/artifact-metadata-parsing.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Enforce API approval status for GA and include SDK type in package properties
* Fix per review comment
* Fixes as per review comments to avoid changing constructor signature
* Fixes as per review comments to handle track 1 packages
* Fix yaml format error
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Run the link verification step even previous step failed.
* Make the tab right
* Address comments
* Run default condition if no RunOnFailure set.
* Changed back to simple condition
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
* Disable dependency on azure-core until azure-core releases to vcpkg.
* Remove release artifact creation script and pipeline step
* Copy items from root cmake generate outputs (no need to do individual project preparation)
* Space
* Add VcpkgPortName (package port names may change in the future to include non v1 version numbers like azure-template-cpp-v2)
* Destination should be artifact name, not vcpkg port name
* Disable PR steps
* SHA512 1 -> SHA512 %SHA512%
* New release procedure
* Unblock publishing process
* Increment azure-template version
* Update branch strategy, uncomment final release of template
* Increment version to test release
* Fix remote branch checkout logic
* Increment version
* Exit successfully
* Increment version
* Increment Version
* Version Increment
* Add a difference in the output file to validate multiple runs against a target PR branch
* Enable existing PR branches in create-pull-request.yml
* Increment version
* Fix archetype-cpp-release.yml syntax
* Skip checkout instead
* Increment version
* Fix automated version incrementing
* Increment version
* Update CHANGELOG.md
* Update CHANGELOG.md date
* Revert CONTROL file
* Remove Build-Depends
* Increment version
* Output commands
* Check out branch in either branch scenario
* Increment version
* Fetch the .tar.gz file using convention, the REST API does not give the location of the .tar.gz
* Increment Version
* ToLower
* Increment
* Increment version
* Version updater should not append a new line to the end of the file contents (existing new line at the end of the file will remain, if present)
* Add azure-template2 to validate base case of shipping different packages instead of file replacement validation from previous runs
* Remove extra backtick
* Add template2 to root CMakeLists.txt
* Review feedback: Support main scenario with packages coming from different location (no new file conflicts)
* Remove file blocking link check step. This is ok because the whole azure-template2 folder will be removed after this verification is complete
* Version increment
* Make template2 install in different locations
* Increment version
* Remove azure-template2 that was used for validating publishing multiple packages
* Remove template2 from ci.yml
* Use "SHA512 1" syntax as proposed by vcpkg documentation and regex replacement
* Review feedback
* Increment version
* Quotes
* Review feedback and re-add New-ReleaseAsset.ps1
* Make the user agent configurable.
* Address comments
* Default to current Chrome version
* Revert the yaml file changes
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
* Update latest folder with one index.html includes the redirect links
* Update the redirect links and remove everything in latest
* Address feedback
* Have the entire copy for latest GA.
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
- Add set of helpers to work with devops work items
- Add script to create devops release package items
- Update SemVer to support version type
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
* Support alpha and azure pipeline build version formats for SemVer parsing and sorting
* Minor build number fixes
* Support zero-padding of build versions more generically in SemVer script
* Fix pre-release label conditional for HasValidPrereleaseLabel in semver script
* Set default convention for build number separator in semver script
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* reformatted parameter arguments to both update-docs scripts. added parameter requirements and renamed CIRepository to DocRepoLocation which is a lot clearer. Added additional CIConfig parameter to update-docs-metadata to support specific write locations per moniker.
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Fixed the docindex.yml and rename the files
* Reset the mutated changes
* Force checkout as the changes have already copied out
* Minor changes for parameters
* Update Generate-DocIndex.ps1
* Update Generate-DocIndex.ps1
* Update Generate-DocIndex.ps1
* Added function to common
* Update Generate-DocIndex.ps1
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* Move entire docgeneration into common tools
* Move docindex to common
* Added the package replacement logic
* Fixed on parameters
* Fixed param
* Change function to dash
* Added regex on function
* Added display name.
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Deal with js
* Add no new line args
* revert some test changes
* Need to default to the double quotes for JS regex
* Update Generate-DocIndex.ps1
* Added the appTitle
* type
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Root Cause:
Storage project generates coverage files in a different location (sdk/*/*cov_xml.xml) from where Core and Template (sdk/*/*/*cov_xml.xml). Basically one level up.
When I added the coverage for Storage, I didn’t know we were also running live tests for Core and Template pipelines. It failed on them because the xml files were not found.
In the PR, I add a new parameter to pipelines to change the default path, and also I am disabling LiveTests from Core and Template, since it only runs the same thing that we run on CI pipelines (We can enable it if we ever have some live tests)
fix: #1001
* Cache created service principal for iteration
Useful when testing changes over and over again without passing your own -TestApplicationId and -TestApplicationSecret.
* Restore initial AzContext for New-TestResources
* Make sure PSBoundParameters is correct
Fixes#1177
Co-authored-by: Heath Stewart <heaths@microsoft.com>
