Commit Graph

531 Commits

Author SHA1 Message Date
JinmingHu
c6a00a97b4
Changelog for #2428 (#2442)
* Changelog update for #2428

* Update sdk/storage/azure-storage-common/CHANGELOG.md

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2021-06-11 13:53:05 +08:00
JinmingHu
c5118efd0b
fix memory leak in xml parser (#2428)
* fix memory leak in xml parser

* fix more

* fix bug

* f
2021-06-09 15:43:39 +08:00
Azure SDK Bot
2e72df3cf7
Increment version for storage releases (#2425)
* Increment package version after release of azure-storage-common

* Increment package version after release of azure-storage-blobs

* Increment package version after release of azure-storage-files-datalake

* Increment package version after release of azure-storage-files-shares
2021-06-09 00:39:00 -07:00
JinmingHu
a0d8668c02
remove extra new line (#2435) 2021-06-09 00:22:49 -07:00
JinmingHu
8f08d9c043
update storage changelog (#2423) 2021-06-08 14:24:41 +08:00
JinmingHu
1d6458e70d
update version and changelog for GA release (#2406)
* update version and changelog for GA release

* Update sdk/storage/azure-storage-blobs/CHANGELOG.md

* Update sdk/storage/azure-storage-files-datalake/CHANGELOG.md

* Update sdk/storage/azure-storage-common/CHANGELOG.md

* Update sdk/storage/azure-storage-files-shares/CHANGELOG.md
2021-06-08 11:47:31 +08:00
JinmingHu
83c265b463
use precondition instead of runtime exception (#2421) 2021-06-08 11:46:57 +08:00
JinmingHu
686270743d
move some headers to private (#2420) 2021-06-08 11:46:46 +08:00
JinmingHu
9c5872f5e5
use ptrdiff_t instead of std::ptrdiff_t (#2419) 2021-06-08 11:46:36 +08:00
JinmingHu
15adb632a1
Fix potential overflow of casting (#2379)
* fix potential overflow during integer cast

* more

* clang-format

* fix
2021-06-07 10:50:38 +08:00
Anton Kolesnyk
e8f8a01e69
Docs: link to root Getting Started section from Storage's readme (#2388)
* Docs: link to root Getting Started section from Storage's readme

* Move section

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-03 10:58:58 -07:00
JinmingHu
1b132190ee
unify message format of exception/assertion (#2382)
* unify exception message

* unify format of assertion message
2021-06-03 10:46:28 +08:00
JinmingHu
af52a49bbe
move some headers to internal directory (#2381)
* move some headers to internal

* move some headers to internal

* fix build error

* fix more
2021-06-03 10:42:57 +08:00
JinmingHu
c8a525ec74
update storage samples (#2380)
* update storage samples

* use CreateIfNotExists
2021-06-03 09:39:22 +08:00
JinmingHu
fe7b88194a
remove IfUnmodifiedSince from SetDataLakeFileSystemMetadataOptions (#2383)
* remove IfUnmodifiedSince from SetDataLakeFileSystemMetadataOptions

* cl
2021-06-03 09:36:38 +08:00
JinmingHu
06cc8980f4
Add sample for transactional checksum (#2384) 2021-06-03 09:36:14 +08:00
JinmingHu
4b6b2a40fa
use int32_t for retry count (#2377) 2021-06-02 15:48:35 -07:00
JinmingHu
38bd273d23
fix read consistency issue (#2364) 2021-05-30 10:36:49 +08:00
Anton Kolesnyk
a742608406
Catch as const whenever possible (#2361)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-28 01:52:59 -07:00
JinmingHu
e39d189d30
Use wide-char version of CreateFile API (#2343)
* Use wide-char version of CreateFile API

* fix

* fix
2021-05-28 11:01:26 +08:00
JinmingHu
8257ce32da
Fix the grammar of storage docs (#2348) 2021-05-26 08:30:37 -07:00
JinmingHu
2787785d0f
use EXPECT_EQ(x, y) instead of EXPECT_TRUE or EXPECT_FALSE (#2347) 2021-05-26 08:29:39 -07:00
Victor Vazquez
88dc1ac8cf
adding Test file sufix to all tests (#2337)
* azure core

* perf

* identity

* keyvault

* storage
2021-05-25 11:15:30 -07:00
JinmingHu
0876ff4fd5
Add samples (#2342) 2021-05-25 11:08:17 -07:00
Victor Vazquez
fcf75f80d1
update storage download perf test - Take connection string from env (#2247)
* update storage download perf test

* format

* allow getEnv() for msvc

* Add size option

* format

* Download to buffer

* Apply suggestions from code review

* use member for the buffer

Co-authored-by: Mike Harder <mharder@microsoft.com>
2021-05-21 17:00:38 -07:00
Kan Tang
e5a589beec
Fix changelog (#2339)
# Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests).

- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
  - [x] PR is single purpose
  - [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [x] Any breaking changes?
2021-05-21 07:47:08 +00:00
Kan Tang
be29d332c2
Change ContentLength to FileSize. (#2338)
Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/2334

# Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests).

- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
  - [x] PR is single purpose
  - [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [x] Any breaking changes?
2021-05-21 07:08:23 +00:00
JinmingHu
ce30cca1cb
use size_t in storage sdk (#2320)
* use size_t instead of std::size_t

* use size_t for file write length

* fix build error

* fix build errors

* fix build error
2021-05-21 13:58:57 +08:00
Azure SDK Bot
11a36c98f6
Increment version for storage releases (#2331)
* Increment package version after release of azure-storage-common

* Increment package version after release of azure-storage-blobs

* Increment package version after release of azure-storage-files-datalake

* Increment package version after release of azure-storage-files-shares
2021-05-20 11:59:38 +08:00
JinmingHu
d99fcbc9f8
mint storage beta 11 (#2326) 2021-05-20 09:23:39 +08:00
JinmingHu
7b3f5d3c96
Changed type of CommitBlockCount to int32_t (#2318) 2021-05-18 23:36:13 -07:00
Ahson Khan
2a4dfd2f0d
Incorrect use of hashing Final/Append APIs now have an assert failure. (#2317)
Follow up from https://github.com/Azure/azure-sdk-for-cpp/pull/2189
2021-05-19 04:18:16 +00:00
Anton Kolesnyk
e5763720d4
Vcpkg fixes (#2311)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-18 19:33:59 -07:00
Ahson Khan
65821ec115
Use size_t for buffers representing data in memory rather than int64_t. (#2285)
* Use size_t for buffers representing data in memory rather than int64_t.

* add a cast from size_t to int64_t

* Address feedback - OnRead return size_t.

* Change Read and ReadToCount to return size_t instead of int64_t.

* Update curl usage and ReadFromSocket.

* Missed one signature.

* Update changelog.

* Update transport layer to use the right size_t size.

* Fix curl use of MBS.

* Cast to size_t since that's all memory stream supprts.

* Add static casts to size_t as temporary workarounds.

* update storage tests.

* More test fixes.
2021-05-18 18:51:20 -07:00
JinmingHu
d8214af143
int -> int32_t (#2290) 2021-05-17 22:32:36 -07:00
Anton Kolesnyk
00dfcc2beb
Doxygen comment updates (#2280) 2021-05-17 17:05:06 -07:00
Victor Vazquez
e4a18b5eb3
Fault injection test (#2265)
* missing line for single docs

* format

* fault injection test

* winHttp

* storage blobs client with fault injector
2021-05-17 10:34:50 -07:00
JinmingHu
af936e052f
use AZURE_ASSERT in storage code (#2262)
* use AZURE_ASSERT in storage code

* fix build

* clang-format

* fix
2021-05-17 10:06:26 +08:00
Anton Kolesnyk
efe4772acb
Update upper/lower/other casing (#2267)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:54:16 -07:00
Anton Kolesnyk
00c47e8ec3
Delete vcpkg readme (#2268)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:53:59 -07:00
JinmingHu
8cc98320d5
- BlobServiceClient::UndeleteBlobContainer doesn't support restoring a deleted container under a different name anymore. (#2263) 2021-05-14 09:31:49 +08:00
Ahson Khan
743399eca4
Disable BlobServiceClientTest::UndeleteBlobContainer to keep CI and live tests green (#2259) 2021-05-12 13:40:34 -07:00
Ahson Khan
579a58b250
Fix typo in share_responses docs (#2258) 2021-05-12 19:26:13 +00:00
Anton Kolesnyk
530e49b217
Document final/virtual destructor changes (#2256) 2021-05-12 11:38:17 -07:00
JinmingHu
b4fa6b835a
Fix stream leak issue (#2257)
* Fix stream leak issue

* cl
2021-05-12 09:05:03 +00:00
Anton Kolesnyk
ebb112f682
Add final specifier in Storage code (#2238)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-11 17:02:52 -07:00
JinmingHu
11d3a3f286
add namespace explicit qualifier for friend classes (#2236) 2021-05-08 13:49:09 +08:00
JinmingHu
273d411838
add some coments (#2235) 2021-05-08 04:02:23 +00:00
JinmingHu
2b169ca777
Removed GetBlockListResult::ContentType, moved GetPageRangesResult to detail (#2234) 2021-05-08 11:16:30 +08:00
Ahson Khan
fd9c3e5ebb
Fix true spelling errors across all source and header files within the SDK and add exceptions for false positives. (#2209)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.

Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.

> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`

CSpell: Files checked: 188, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`

CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)

> `cspell lint --config .vscode/cspell.json *.md */**/*.md`

CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)

> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`

CSpell: Files checked: 44, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.* */**/*`

CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)

Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
2021-05-07 21:04:58 +00:00