Commit Graph

111 Commits

Author SHA1 Message Date
Daniel Jurek
14aa1516d0
Add spell check exceptions and enable CI failure for spelling errors in changed files (#2865)
* Add spell check exceptions and enable spell check failures

* Add HRESULT and sort spelling list

* Add exceptions for cmake-modules
2021-09-13 14:38:49 -07:00
Anton Kolesnyk
3aee1859f0
CSpell fixes for Core and Identity (#2816)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-08-31 15:21:17 -07:00
George Arama
9ef8d5a45f
cspell fixes for keyvault (#2812)
* cspell fixes for keyvault

* formatting issues
2021-08-30 19:49:22 -07:00
JinmingHu
8cae42999e
cspell for storage (#2800)
* cspell for storage

* aaa
2021-08-27 11:55:07 +08:00
Daniel Jurek
2418581e2e
Spell Check Phase 2 (#2794)
* Formatting

* Add cpp to dictionaries, comment to words section, and opted-out paths for spell checking

* Enable blocking of PRs on spelling error
2021-08-26 14:15:22 -07:00
Ahson Khan
d90d5c761e
Consolidate keyvault and cryptography client options and model files into single headers. (#2640)
* Consolidate keyvault options and model files into single headers.

* Consolidate cryptography client model headers into a single header.

* Fix up merge conflict

* Consolidate LROs into one, and fixup PagedResponse name.

* Fix up clang formatting and match cpp file name with hpp.

* Fix clang formatting.

* Move LROs and PagedResponse types into models as well.

* Move encrypt and decrypt parameter types into cryptography model header
file.

* Fix clang format, reodering of headers.

* Update to match recent changes.

* Update CL
2021-07-22 11:48:55 -07:00
JinmingHu
cc1a7d22ce
remove unused headers from blob protocol layer (#2546)
* remove unused headers from blob protocol layer

* fix typo

* Add rehydrated to spell check exception list
2021-07-05 03:00:37 +00:00
Ahson Khan
fd9c3e5ebb
Fix true spelling errors across all source and header files within the SDK and add exceptions for false positives. (#2209)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.

Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.

> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`

CSpell: Files checked: 188, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`

CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)

> `cspell lint --config .vscode/cspell.json *.md */**/*.md`

CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)

> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`

CSpell: Files checked: 44, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.* */**/*`

CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)

Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
2021-05-07 21:04:58 +00:00
Ahson Khan
e1340dcfa8
Check for context cancellation in more places within the winhttp transport layer before each I/O call. (#2185)
* Check for context cancellation in more places within the winhttp transport layer before each I/O call.

* Update cspell to add exceptions to false positives.

* Address PR feedback.

* Do not check for context cancellation before querying the response headers.
2021-05-05 17:17:54 -07:00
Daniel Jurek
12cec8c08f
Add cspell.json to ignored paths (#2190) 2021-05-04 17:20:52 -07:00
Daniel Jurek
8cf7746b6b
Add spellcheck (#2181)
* Add spellcheck

* Add spelling error

* Format cspell.json

* Revert "Add spelling error"

This reverts commit 37446522791492e8ee2c1c54af0d2da1e162d2e4.
2021-05-03 19:13:02 +00:00