* Revert "Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where (#5406)"
This reverts commit 2d8c940f55.
* Revert "Rename the TESTING_BUILD macro to be _azure_TESTING_BUILD to highlight (#5390)"
This reverts commit 256c2df8b5.
* Revert "Use new macros in existing surface area, so that classes marked as final don't have virtual methods. (#5389)"
This reverts commit 3d7eaddb9d.
* Revert "For new surface area, classes marked as final should not have virtual methods. (#5331)"
This reverts commit ddd0f4bd07.
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Use new macros in existing surface area, so that classes marked as final don't have virtual methods.
* Update doc comments.
* Use DOXYGEN_PREDEFINED to expand only the macros we want expanded.
* Add the compile definition for more projects.
* Address PR feedback.
* Make TestableTokenCache a friend class of TokenCache.
* Classes marked as final should not have virtual methods.
(cherry picked from commit 7413384c111b73be448f78527a08a544fd1f6ec6)
* Update changelog.
* Address PR feedback and use named-macro.
* Only use the macro for testing_build final classes.
* Add a new compile definition _azure_TESTING_BUILD.
* Add test as a friend class and put the test in a Identity specific test
namespace.
* Remove the macro for final expansion since doxygen struggles with it.
* Address PR feedback, add ifdef guard around _azure_VIRTUAL_FOR_TESTS.
* AzureCliCredential to treat datetime without TZ info as local time.
* Fix spelling
* CLang-format
* Parse as local by appending TimeZoneOffsetAsString()
* Fix bad merge
* PR Feedback
* Merge
* Merge
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Make vcpkg.json comment multiline
* Update core-opentelemetry tests to be able to compile with opentelemetry-cpp version 1.12.0
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Azure Identity November Release
* Re-order and move fix to new feature.
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Incapsulate all the defaults for options values such as authority host
in a helper class and add authority host url validation.
* Address PR feedback.
* Re-use the selected credential that works for each subsequent request in
DefaultAzureCredential by caching the chosen credential per instance.
* Update test to include per-instance caching validation.
* Addresss PR feedback and fix clang error on atomic assignment.
* Fix typo in CL and drop ifdef testing_build to investigate clang build
issue.
* Add double-colon in front of friend class.
* Add a note to vcpkg manifest files that all changes made in the vcpkg repo alone might be lost.
* may => will
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Create separate lists of characters that are allowed within a tenant id vs scopes in AzureCliCredential.
* Update test to catch the particular exception we expect to be thrown for
tenant id but not for scopes.
* Address PR feedback.
* Try to see what happens without coverage exclusions
* Reset coverage limits
* Mark ThrowParseError as [[noreturn]] to ensure compiler knows that code after it is dead code
* Added tests for the Azure assert macro
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Change the default option for authority host to be read from the environment first.
* Update changelog.
* Update doc comment and refer to the env var correctly.
* Update doc comments and add unit tests.
* Azure Identity September Release
* Update release date in CHANGELOG.md
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Modify the order of the credentials used within the to be consistent with other languages.
* Update LogMessages test since the order of credentials has changed.
* Fix the order for the rest of the log messages within the test.
* Update svg and clang format.
* Add WorkloadIdentityCredential to the DefaultAzureCredential.
* Clang format and update the CL.
* Address PR feedback - update CL, and SVG
* Define the required AZURE_FEDERATED_TOKEN_FILE env variable in the test.
* Update DAC unit test to include WIC in the log messages.
* Make several params to WorkloadIdentityCredential optional and read them from the environment instead.
* Fix typo in calling the ClientCredentialCore ctor
* Add changelog entry.
* Address PR feedback, avoid creating many WIC options instances.
* Update ctor impl and add options test.
* Set locals if the options are non-empty, and void unused variable in tests.
* Fixup the sample since the customer no longer needs to explicitly pass in those params.
* Better cmake UWP detection condition (use the same definition as vcpkg)
* Update Config.cmake.in
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>