Commit Graph

705 Commits

Author SHA1 Message Date
JinmingHu
395e9a0640
Test proxy & storage tests improvements (#4241) 2023-02-22 09:37:49 +08:00
George Arama
9572608a5d
Docker comment (#4375)
* update comment

* add comment about vcpkg

* dsfs
2023-02-21 19:50:55 +00:00
George Arama
30afd1eb89
reworked docker file (#4344)
* reworked docker file

* removed unnecessary su

* update docker file

* qwq

* Update sdk/core/azure-core/test/libcurl-stress-test/Dockerfile

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

* url

---------

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
2023-02-17 11:40:54 -08:00
Anton Kolesnyk
326ec44db8
Update changelog to reflect community contribution (#4355)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-02-13 17:13:49 -08:00
Jørgen Lind
4d894adc51
Fix compilation on Visual Studio 2017 (#4352)
Co-authored-by: Jørgen Lind <jorgen.lind@bluware.com>
2023-02-13 16:00:52 -08:00
Mike Harder
fd1695ebba
[Perf] Refactor tests.yml into one file per package per language (#4270) 2023-02-09 21:18:03 -08:00
George Arama
3762c59552
Test proxy start (#4295)
* lll

* sss

* oipio

* vcvc

* enable test proxy start at test suite start for KV and storage , example created for attestation, we cannot find the base definitions for the test suites,

* Contrib

* clangs

* clangs

* test logs

* pipeline

* more clangs

* pipeline

* clang

* try try again

* try try again

* try again

* try again

* again

* update paths , moved to macro , call macro in target code

* core

* capitalization
2023-02-07 10:52:20 -08:00
Ahson Khan
1abebf9661
Fix cspell flagged typos across the repo by triggering it on all files.
* Modify files by adding an extra space to trigger spell check on all.

* Modify newer files.

* Modify new files that got added.

* Modify all markdown files to trigger spell check on those.

* Fix spelling errors and update cspell to remove out-dated exceptions.

* Add back mypgrogram exception for the readme from azure-core.

* Revert test edits to markdown files.

* Revert test changes to source and header files.

* Remove modification to leftover source files.
2023-02-06 11:30:20 -08:00
Azure SDK Bot
6a53e4122f
Increment version for core releases (#4338)
* Increment package version after release of azure-core

* Increment package version after release of azure-core-tracing-opentelemetry
2023-02-03 09:24:25 +00:00
Anton Kolesnyk
aa9cd300fe
Core February Release (#4315)
* Core February Release

* Accumulate changelog entries from previous Beta releases

* Update sdk/core/azure-core/CHANGELOG.md

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>

* Update sdk/core/azure-core/CHANGELOG.md

* Update CHANGELOG.md

* Add wil dependency

* Update sdk/core/azure-core/CHANGELOG.md

* Update sdk/core/azure-core/CHANGELOG.md

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* Undo change to the vcpkg manifest file (went in in other PR)

* Sync with main

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-02-02 23:36:12 -08:00
Anton Kolesnyk
243fb4c58d
Compilation fixes for UWP (#4335)
* Compilation fixes for UWP

* More accurate condition

* Fix warnings

* Format files as vcpkg formats them; pull one change back from vcpkg

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-02-02 20:04:21 -08:00
Ahson Khan
3b6af7534e
Remove mention of testing related changes from telemetry changelog (#4331) 2023-02-02 12:53:25 -08:00
Ahson Khan
5954c5ef26
Make sure PRs modifying markdown files within the repo get CI triggered (#4323)
* Make sure PRs modifying markdown files within the repo get CI triggered

* Update ci.yml for core to trigger on any markdown file change.

* Test to see if wildcards work as expected

* Update wildcard to include any markdown file, with a path

* Revert README.md file change.

* Modify a markdown file in a nested directory to see if core ci is triggered.

* Exclude sdk/core from the trigger to see if wildcard works correctly.

* Add back sdk/core

* Revert samples markdown change.
2023-02-02 12:06:55 -08:00
Larry Osterman
03965298be
Prepare OpenTelemetry for beta release (#4320)
* Prepare OpenTelemetry for beta release

* Update sdk/core/azure-core-tracing-opentelemetry/CHANGELOG.md

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Removed core changelog changes

* Removed core changelog changes 2

* Updated core dependency to 1.8.0

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-02-02 09:56:44 -08:00
Larry Osterman
5d6b6f72c1
Added deprecated constructors for attestation service (#4313)
* Added deprecated constructors for attestation service

* Disable deprecation warnings for clang; improved documentation to reflect deprecated functions

* Use doxygen @deprecated on deprecated functions

*
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-02-01 13:05:20 -08:00
Ahson Khan
696d138105
Move cspell exceptions in markdown file to metadata that isn't visible using html comment syntax (#4311) 2023-01-31 21:25:44 -08:00
Anton Kolesnyk
05040409d9
Policies do not overwrite HTTP headers if they are already set (#4303)
* Policies do not overwrite HTTP headers if they are already set

* Use static constant UserAgent

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-31 17:58:48 -08:00
George Arama
e1c62a2975
Missing content for testProxy.md , spellchecked stress, added /doc as triggetr for the core pipeline (#4296)
* docs for stress perf

* dotnet contrib

* missing content plus pipeline trigger

* stress tests spell checked

* one more
2023-01-30 11:06:51 -08:00
Ahson Khan
74a1ad7714
Ignore warning C4100 on Windows for unused parameter in OpenTelemetry headers. (#4252)
* Ignore warning C4100 on Windows for unused parameter in OpenTelemetry
headers.

* Disable other warnings like 4244 and 6323 as well.

* Clang format fix.
2023-01-25 17:34:39 -08:00
Ahson Khan
876a7baaa5
Add CI pipeline step and script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM (#4134)
* Add CI pipeline step and script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM

* Update platform-matrix.json to turn on CHECK_ASCII_CHARACTERS

* Fix missing comma in json.

* Update indentation in the ci.test.yml for the bash script

* Exclude the .github folder and test recording json files.

* Remove "recordings" exclusion since it doesn't exist anymore.

* Fixed UTF-8 with BOM and other non-ASCII character issues within the
files in the repo.

* Exclude nlohmann json tests from ASCII validation check.

* Log an intro to the CI console for the validation step.

* Remove codecoverage.cmake exclusion.

* Remove exclusion for docs and tools directories.
2023-01-25 17:33:26 -08:00
Larry Osterman
f757bb06e7
Clean up tracing logic - prepare for new tracing functionality. (#4263)
- Made Context immutable (including marking the static ApplicationContext as const
- Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
- Changed Az.Namespace value from being the package name to being the service name.
- Change test SpanExporter to fully capture exported values rather than keeping references to the values.


Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-01-25 19:07:25 +00:00
George Arama
e5812ec72c
Stress test (#4268)
* stressTest

* STRESS WORKS

* missing space
2023-01-24 15:43:54 -08:00
Anton Kolesnyk
136645c820
Update changelog wording (#4262)
* Update changelog for the Azurite fix

* Update changelog wording

* Update changelog wording

* Add "Fixed ..."

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* Added "courtesy of" wording

* Spell checker update

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-01-20 02:59:18 +00:00
Anton Kolesnyk
441bb13225
Update changelog for the Azurite fix (#4259)
* Update changelog for the Azurite fix

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-18 16:04:55 -08:00
Johannes Schönberger
6e6ca66c26
Reset connection pool upon failure to read response (#4208)
* Reset connection pool upon failure to read response

* cspell

* format

* format

* CR
2023-01-18 22:07:31 +00:00
George Arama
d5e2ab88a9
Okp skip tests (#4256)
* first pass

* part2

* part3

* part 5

* pre PR

* updated tests

* fix test

* clangs

* updated changelog

* skip okp test sfor non HSM test runs

* no return value

* stupid mistake

* clang

* clang

* pr comments, clang

* oops

* skipping maybe?

* Update sdk/core/azure-core-test/inc/azure/core/test/test_base.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* fir RemovePreffffffix

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2023-01-17 16:22:04 -08:00
Anton Kolesnyk
fe29302583
Revert MultipleCrlOperations test to the previous version (#4238)
* Experiment with CI and MultipleCrlOperations test

* Switch to an older, less failure-proof version of the test from yesterday

* Switch Ubuntu18 to Azure Pipelines as well

* Undo CI changes just to make sure it fails

* Apply CI machine pool changes

* Move Ubuntu20 to general pool

* Move Ubuntu20 to general pool

* Move Ubuntu20 to perf pool

* Revert all changes in platform-matrix.json

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
2023-01-12 16:53:55 -08:00
Anton Kolesnyk
ff53067dd3
Nullable::Reset() hardening (#4232)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-12 16:27:51 -08:00
Larry Osterman
a34b8d19a5
Add ApiView settings for existing packages. (#4226)
* Create ApiViewSettings for most existing packages

* Corrected name for blobs storage review name

* Added cspell settings for DCURL

* Create ApiViewSettings for most existing packages

* Corrected name for blobs storage review name

* Added cspell settings for DCURL

* ApiView settings changes for DataLake

* Renamed includeInternal to allowInternal; Added storage common; Fixed package names

* Fixed spelling error

* If there's an error accessing the site with no CRL checks, don't try it any more

* Stop checking example.com because it doesn't work

* Update sdk/attestation/azure-security-attestation/inc/ApiViewSettings.json

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* Update sdk/core/azure-core/inc/ApiViewSettings.json

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* Update sdk/keyvault/azure-security-keyvault-secrets/inc/ApiViewSettings.json

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-01-11 08:16:13 -08:00
Anton Kolesnyk
d301dfb60d
Unblock Core CI (#4236) 2023-01-10 19:13:10 -08:00
Azure SDK Bot
fb64990a87
Increment package version after release of azure-core (#4223) 2023-01-05 19:05:03 -08:00
George Arama
b372b85f5b
Core January Release (#4219)
* update changelog

* Core January Release
2023-01-05 08:40:22 -08:00
Ahson Khan
6536b0c61c
Move Request ctor impl to the request.cpp file instead of http.cpp (#4195)
* Move Request ctor impl to the request.cpp file instead of http.cpp

* Add the ctors to request.cpp

* Remove null body stream header from http.cpp

* Remove unused namespace using

* Add _internal using namespace for NullBodyStream

* Fix include path
2023-01-03 16:13:05 -08:00
Anton Kolesnyk
5304a0857d
PR follow-ups (#4201)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
2023-01-03 12:08:00 -08:00
Anton Kolesnyk
152a847dcc
noexcept adjustments (#4200)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-03 11:17:16 -08:00
Anton Kolesnyk
fd3b9a6180
More accurate argument type for the ExtendableEnumeration == and != (#4199)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-03 11:17:09 -08:00
Anton Kolesnyk
3e4a41bd4a
Remove noexcept specification from Azure::DateTime::clock::now() (#4198)
* Remove noexcept specification from Azure::DateTime::clock::now()

* Undo unnecessary change (my local clang-format is broken)

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-03 11:17:02 -08:00
Anton Kolesnyk
a70be339e7
Audit string comparisons (#4197)
* Audit string comparisons

* Mac fix

* !isxdigit()

* Rewrite condition + comment

* <3

* Clang-format

* 255

* Allow uppercase

* stoi() radix

* ShouldEncode()

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-01-03 11:16:54 -08:00
George Arama
8767e4e340
live test guard (#4188) 2022-12-13 21:46:48 +00:00
George Arama
ef4d41267f
Test proxy (#4118)
* start

* recording

* playback

* refactor, playback and record

* recordings for kv

* klklk

* open telemetry, identity

* attest

* all tests recorded except storage

* STORAGE RECORDINGDS

* some cleanup

* ignore result

* testproxy remade

* fiiine , do something with the result , goooosh

* install test proxy

* clang

* clang

* certs maybe

* cmake generate fix,

* start test proxy script

* start test proxy on env

* clang, move TP after build

* reregen

* certs

* sda

* dss

* allow insecure connections

* put back

* debug

* iuy

* try again

* ewew

* chmod

* try again

* update sanitizer

* output testproxy log

* sjhgasjgdajh

* folder

* worxy

* fix tests and log file

* format files

* clang format

* clang

* sa

* sa

* cleanup

* cspell

* oops

* remove redundant method

* tests

* put back original

* restore to 933486385a

* recordings

* remove storage values

* storage recordings

* disable non functioning tests

* remove core install of test proxy

* _LIVEONLY_ tests

* clang install when needed

* logs on condition

* skip tests

* revert cpp to original version

* quick test

* right that one

* one skip

* identity pushed

* maybe

* override

* clang

* clang

* attestetion

* keyvault

* reenable 20+ tests

* 5 tests left , lease related

* a bit of cleanup

* try now

* snitizers

* some fixes

* capitalization

* clang , cover, peakA

* WEIRD NAME THING ON WINDOWS

* storage recordings

* one more livee

* createappenddelete_liveonly

* CreateWithTags_LIVEONLY_

* try capitalization

* another onw

* maybe now

* all liveonly

* try restore before test

* typo

* condition

* clang and cc

* azure core ci

* qwqwq

* dsasdas

* cleanup1

* typo

* spaces

* cleanup2

* cleanup 3

* remove start proxy

* cleanup +1

* Update cmake-modules/TestProxyPrep.cmake

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update eng/scripts/Start-TestProxy.ps1

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update eng/scripts/Stop-TestProxy.ps1

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* PR comments

* clangs

* Update sdk/core/azure-core-test/src/test_proxy_policy.cpp

* build

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2022-12-13 10:58:19 -08:00
Anton Kolesnyk
97235cb46b
Add support for space character instead of 'T' when parsing RFC3339 DateTimes (#4184)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2022-12-12 13:16:11 -08:00
Anton Kolesnyk
c14775d5fb
Better TokenRequestContext initialization (#4169)
* Better TokenRequestContext initialization

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2022-12-07 20:25:22 -08:00
Anton Kolesnyk
405ae8cba7
Only allow BearerTokenAuthPolicy for HTTPS (#4170)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2022-12-07 20:03:17 -08:00
Larry Osterman
5737bfeb6a
Fixed #4137 - Don't close CURL connection on shutdown (#4142)
* Fixed #4137 - Don't close connection on shutdown

* clang-format
2022-12-05 13:32:50 -08:00
Anton Kolesnyk
09db139a71
AzureCliCredential (#4146)
* AzureCliCredential

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2022-12-05 13:15:19 -08:00
Ahson Khan
928c9cf6eb
Disable warning C6387 coming from wil in win_http_transport due to SAL annotation (#4132)
* Disable warning C6387 coming from wil in win_http_transport

* Disable warning C6387 coming from wil in win_http_transport header

* Clang format fix for header file

* Clang format fix for source file
2022-11-28 12:20:00 -08:00
Billy O'Neal
8934b2118f
This was first discovered by trying to update curl in vcpkg: https://github.com/microsoft/vcpkg/pull/27778 (#4127)
Curl is no longer publishing that it depends on ws2_32 when dynamically linked. Azure Core directly uses Ws2_32 things, so it needs that declared dependency. For example:

90fc46693f/sdk/core/azure-core/src/http/curl/curl.cpp (L165)
2022-11-18 16:11:55 -08:00
Azure SDK Bot
40afee9c16
Increment package version after release of azure-core (#4090) 2022-11-07 14:39:19 -08:00
Anton Kolesnyk
48e6fcf115
Core November release (#4082)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2022-11-03 15:31:01 -07:00
George Arama
1da78ce13e
Gtest timeout fix (#4078)
* PT1

* typo

* timeout

* gtest_1.12.1

* cspell isnore cmakelistst , it seem to freeze when checking these files

* timeout for cmake generate

* timeout for cmake generate p2

* timeout for cmake generate p3

* timeout for cmake generate p4

* timeout for cmake generate p5

* PR

* node 18

* nppm

* npm

* bug in cspell, freezed on txt files

* AntonComment extra space

* cspell
2022-11-02 15:46:38 -07:00