Commit Graph

26 Commits

Author SHA1 Message Date
Daniel Jurek
a91d151e79
Vcpkg Beta Automation (for real) (#3497)
* Script that automates updating vcpkg betas

* Wire up to pipeline

* Spelling, commentary

* Clone into repo name

* Remove-Item requires the path to exist, even if -Force is specified

* Bootstrap vcpkg

* Arguments to Test-ShouldReleaseToVcpkg.ps1

* More commit

* Escape quotes

* Quote git commit

* Set strict mode

* Use tags

* Actually tag

* Run git commands

* Invoke-Expression

* Onboard releasing package to vcpkg before attempting to isntall from overaly

* temporarily disable matrix generation (30s tasks sometimes runs for 20+ minutes)

* Test-ShouldReleaseToVcpkg.ps1

* Test-Path

* Test vcpkg build, also ensure we push

* Just the tags... low probabiltiy of success given that '--' if frequently treated as a separator

* Add ability to skip link verification for tighter inner loop

* Push tag separately

* Unnecessary condition and conjunction

* Base repo owner: Azure

* Specify remote name

* Tighten inner loop

* git remote -v

* workingDirectory

* Go back to two tags and a regular push

* Saving some progress

* Use original push method

* BaseRepoOwner

* Cleanup, put changes in the default branch (vcpkg does not look at refs outside of the default branch)

* Use default branch

* Revert changes used to tighten up devops inner loop

* Revert an unrelated change

* Revert unrelated changes

* Revert unrelated changes

* Add spelling
2022-04-01 06:30:03 -07:00
Victor Vazquez
835f156af9
Vcpkg manifest and binary caching (#3329)
* binary cache and manifest

* update packages

* udpate

* add cache to private pipeline

* next try

* aver

* other

* again

* aver quick

* more

* this way

* again

* one more

* print

* test

* use depend

* more deps

* dep

* Apply suggestions from code review

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* updated to use group variable

* update identity

* end line

* Update vcpkg.json

* Apply suggestions from code review

* cspell

* remove comment

* updates

* make cache mode depend on SAS env var

* map env var only for internal pipelines

* other approach

* what about this

* and this

* try

* amd

* another

* extra step

* typo

* override for internal

* use default succeded

* azure core update manifest

* a

* run cmake-generate nightly as well

* check for SAS

* check cache

* no secret

* fix is secret

* pass explicit

* use secret all the time

* char

* One more

* export

* echos

* last

* array

* remove question

* ok

* weird

* use account key

* substring

* VCPKG_BINARY_SOURCES

* Add module installation

* task:

* Correct pathing for module

* update source gen

* format

* update spelling

* IsWindoows

* Use pwsh

* Cannot clobber with PSModule-Helpers. Attempt plain install

* Attempt plain install

* Revert unnecessary change to Update-DocsMsToc.ps1

* template ready

* curl is required on Windows as well for some CI gates

* attestation

* fix format

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2022-03-24 09:11:30 -07:00
Larry Osterman
af7281ef1a
Updated and add samples for Attestation service. (#3448)
* Moved samples around to meet new recommendations; added a couple of additional tests.
* Reworked attestation to include RetrieveAttestationValidationCollateral
* Attestation sample readme updates
* TPM doesn't need to retrieve response validation collateral
* Added cautionary warning about the dangers of overriding the TearDown method from inside a test case
* Added attestation team members to codeowners for attestation SDK
* Remove CODEOWNERS from cspell checks
* Don't hold a lock across retrieving the signers over the network
* Updated snippets in readme; clang-format
2022-03-22 14:29:03 -07:00
Larry Osterman
abb6ac0c9a
Add Policy Management Certificates APIs (#3417)
* Added GetPolicyManagementCertificates

* Added Add and Remove policy certificate

* Added support for Tpm attestation

* Moved TPM to attestation service specific section

* Added support for validation callback

* Updated RequestFailedException documentation
2022-03-16 15:12:33 -07:00
Daniel Jurek
44310b635a
Log binary sizes (excl. UWP changes) (#3357)
* Output binary sizes (Get-BinarySizes.ps1 works for linux environment)

* Add better support for Windows binary output

* Update matrix to properly build Debug and Release on Windows

* Add TEAMPROJECTID to spell check

* Add extra labels

* Ensure BuildArgs doesn't get duplicated

* Log additional metrics

* Add openssl to Win32Api_curl

* SourceBranchName -> SourceBranch

* Fix matrix entries

* Document included

* Review feedback for Get-BinarySizes.ps1

* Infer many metrics from the environment

* Add issecret to cspell.json

* Extra equal signs

* Correct directory depth for $BuildDirectory

* Correct casing for mac VM image
2022-03-03 11:36:11 -08:00
Larry Osterman
d2fd862ce1
Create Attestation SDK (#3228)
* Created Attestation


Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2022-02-16 09:15:18 -08:00
JinmingHu
077d32ffff
New protocol layer for blob, datalake and queue generated by CodeGen (#3261)
* new protocol layer

* remove some [[deprecated]] to eliminate compiler warnings

* remove unused helper functions

* ut record

* revert [[deprecated]]

* fix typo
2022-02-11 11:02:51 +08:00
George Arama
88f234d976
build source identity (#3244)
* build source identity

* pipeline

* PR comments

* PR comments

* DFETCH cspell

* EOL
2022-01-21 13:13:15 -08:00
George Arama
9d1ede92ec
Prototype build from source (#3180)
* prepPR

* gitignore updates

* cspell.json

* spell

* cspell typo

* deisable option

* need to look out for this

* reenable tests

* set unset location properly

* building in docker

* format file

* final changes

* PR comments

* update git ignore

* test cmake build

* test 2

* ren steps

* test new step

* try again

* again

* oops

* try again

* put back

* test2

* test5_46

* progress

* more again

* test6_35

* test 6_55

* test_again

* move up

* test

* output params

* try try again

* one more test

* put back curl

* os

* run only on one

* try again

* typo

* switch variable

* set things back

* set things back

* prep for next step

* test source deps new

* try again

* try try again

* typo

* test rewire

* params

* typo

* fix

* get rid of vcpkg

* linux

* mac

* try brew

* try exports

* try again

* typo

* set env

* include dir

* root

* try again

* typo

* dfsfsda

* try agan

* try again

* oops

* sdfsd

* typo

* dsdsad

* hghhg

* update env

* ghhgj

* sAdsad

* try again

* fdfd

* rewrew

* dsadas

* sdasda

* ggggg

* envs2

* envs3

* typo

* order

* try again

* make sure we don't blow up other pipelines

* typo

* typo

* fsdfs

* check null

* put back
2022-01-14 13:06:00 -08:00
Daniel Jurek
fa0fa97155
Generate map files (#3181)
* Generate map files in build

* Add .map file artifact publishing

* Add Xlinker to spelling exceptions

* Remove PublishMapFiles from clang builds

* Generate the map file artifact name

* CXX_COMPILER_ID and some logging for Clang which might be linking using the GNU linker by default

* More logging

* Move logging out of conditional

* Logging up high, use OS to determine which link flags to set

* Use linker options specific to AppleClang's context, publish map files for all platforms
2022-01-03 13:56:41 -08:00
Victor Vazquez
7301f348b0
Recordings for identity (#3156)
Adding test recordings for Identity
2021-12-14 21:42:08 +00:00
Ahson Khan
e498d6a165
Update cspell.json entry for contributor names within azure core changelog. (#3049)
* Update cspell.json entry for contributor names within azure core changelog.

* Remove in-line exception
2021-11-04 15:31:04 -07:00
Daniel Jurek
413b4b7665
Add coverage enforcement (#2992)
* Add coverage enforcement

* Add spelling exception for mspremier

* Use previous build coverage data, enforce 3% variance, use Skip.CoverageEnforcement feature flag

* Use version 8 of quality checks

* Remove forceCoverageImprovement, it doesn't allow 0% improvements (e.g. doc changes, etc.)

* branch -> branches

* Configure coverage thresholds per-service

* Use fixed coverage

* Review feedback

* Per-service coverage plumbing

* Flip branch and line coverage requirements for KV to accurately reflect current baseline
2021-11-03 10:56:32 -07:00
Daniel Jurek
c534a1e160
Cognitive Matrix Consolidation (#2947)
* Refactor template to use multiple builds on the same machine resetting the machine and runtime varaibles along the way

Move template expression out of default matrix parameters

Remove extra reference to ci/jobs.yml

Remove unnecessary ci.yml, change param declaration in devops-variables-set.yml

Heredoc

Fix set/reset scripts after testing with devops outputs

-ErrorAction Ignore

Smaller matrix

OsVMImage comes from machine, not parameters

Add Ubuntu 20 to matrix

Remove checkout: self, it is implied

Move machine-setup steps outside of loop

CODE_COVERAGE handling

tab

Remove creation of CODE_COVERAGE

Use AptDependencies and add apt update to dependency install step

Remove extra preparation steps

Enable code coverage check scenario

Add MacOS 11

Disable vcpkg cache

Coverage configuration

Pass parameter properly

bool -> boolean

Install coverage tools if it's possible that coverage may run

More logging on code coverage

Show contents of Makefile

One vcpkg to build them all

Verbose

SourcesDirectory

Nesting VcpkgInstall

workingDirectory for vcpkg install

AptDependencies

complete the conditional

Enable all matrix entries

sudo

Remove extra chatter

More scrubbing post-build to help with Windows scenarios

sudo echo

Get-ChildItem

ErrorAction

sudo sh -c

More ErrorAction

output sourceListFile

Disable additional sources.list

Install coverage tools when used for coverage

COndition

Do not build testing for Windows arm64

Correct path for coverage tools

ne -> eq

Add more scenarios to the matrix

Remove libxml2

Add MacOS 10.15 to matrix

Revert "Remove libxml2"

This reverts commit 178af8b89abb21ee84dbcd25b4d54bd90ec1d44c.

Add libxml2 to MacOS 10.15 matrix entry

Display name decorator, refine the matrix

Remove OsVmImage variable

Add commentary to tests about matrix

Rebalance matrix, nest EnvVars, DisplayNameDecorator

Correct parameter access

AptDependencies

Ensure building for WindowsStore in UWP builds, Only build tests for debug builds in altered matrix entires, Linux build type specified as environment variable

Rebalance matrix for better timing

Remove all instances of libxml2 in vcpkg dependencies

Move common devops tasks to eng/common

Set eng/common paths in pipelines

Revert "Remove all instances of libxml2 in vcpkg dependencies"

This reverts commit 35ffbc7aac87f400fdf3351076346750c1c750ed.

https://github.com/Azure/azure-sdk-for-cpp/issues/2946

Permit words like iname in more pipeline .yml files

Remove libxml2 from vcpkg dependencies for Windows

Perf test matrix maxParallel: 10

Validate

apt install first

apt install first

maxParallel: 12

-j 8

-j 10

Use matrix generator

Add expected parameters

Move parameters to appropriate file, fix cloud spec

Specify correct platform matrix location

DependsOn

Platform matrix

Remove DisplayNameDecorator, try more clang information

Rapid iteration matrix

clang --version

install clang-11

Use correct pool

Use full matrix, revert additional logic in jobs/ci.yml

* Review feedback: newline

* Review feedback: Test in release, too

* Remove DisplayNameDecorator (it was useful when we were putting multiple builds into a single job, now it is redundant)

* Remove displayNames

* Matrix review feedback

* Conditions

* Rename ci.yml -> ci.tests.yml
2021-10-22 13:49:10 -07:00
George Arama
8727030623
Start create certificate (#2909)
* fix tests local

* first stab

* second

* operation

* HUzaaaah

* split header file

* updates

* error

* format, error

* clang due to certificates

* remove useless line used for debugginng

* Update .vscode/cspell.json

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update .vscode/cspell.json

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client_models.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client_operations.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR fixes

* revert wrong changes

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-09-21 12:38:41 -07:00
Daniel Jurek
14aa1516d0
Add spell check exceptions and enable CI failure for spelling errors in changed files (#2865)
* Add spell check exceptions and enable spell check failures

* Add HRESULT and sort spelling list

* Add exceptions for cmake-modules
2021-09-13 14:38:49 -07:00
Anton Kolesnyk
3aee1859f0
CSpell fixes for Core and Identity (#2816)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-08-31 15:21:17 -07:00
George Arama
9ef8d5a45f
cspell fixes for keyvault (#2812)
* cspell fixes for keyvault

* formatting issues
2021-08-30 19:49:22 -07:00
JinmingHu
8cae42999e
cspell for storage (#2800)
* cspell for storage

* aaa
2021-08-27 11:55:07 +08:00
Daniel Jurek
2418581e2e
Spell Check Phase 2 (#2794)
* Formatting

* Add cpp to dictionaries, comment to words section, and opted-out paths for spell checking

* Enable blocking of PRs on spelling error
2021-08-26 14:15:22 -07:00
Ahson Khan
d90d5c761e
Consolidate keyvault and cryptography client options and model files into single headers. (#2640)
* Consolidate keyvault options and model files into single headers.

* Consolidate cryptography client model headers into a single header.

* Fix up merge conflict

* Consolidate LROs into one, and fixup PagedResponse name.

* Fix up clang formatting and match cpp file name with hpp.

* Fix clang formatting.

* Move LROs and PagedResponse types into models as well.

* Move encrypt and decrypt parameter types into cryptography model header
file.

* Fix clang format, reodering of headers.

* Update to match recent changes.

* Update CL
2021-07-22 11:48:55 -07:00
JinmingHu
cc1a7d22ce
remove unused headers from blob protocol layer (#2546)
* remove unused headers from blob protocol layer

* fix typo

* Add rehydrated to spell check exception list
2021-07-05 03:00:37 +00:00
Ahson Khan
fd9c3e5ebb
Fix true spelling errors across all source and header files within the SDK and add exceptions for false positives. (#2209)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.

Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.

> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`

CSpell: Files checked: 188, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`

CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)

> `cspell lint --config .vscode/cspell.json *.md */**/*.md`

CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)

> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`

CSpell: Files checked: 44, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.* */**/*`

CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)

Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
2021-05-07 21:04:58 +00:00
Ahson Khan
e1340dcfa8
Check for context cancellation in more places within the winhttp transport layer before each I/O call. (#2185)
* Check for context cancellation in more places within the winhttp transport layer before each I/O call.

* Update cspell to add exceptions to false positives.

* Address PR feedback.

* Do not check for context cancellation before querying the response headers.
2021-05-05 17:17:54 -07:00
Daniel Jurek
12cec8c08f
Add cspell.json to ignored paths (#2190) 2021-05-04 17:20:52 -07:00
Daniel Jurek
8cf7746b6b
Add spellcheck (#2181)
* Add spellcheck

* Add spelling error

* Format cspell.json

* Revert "Add spelling error"

This reverts commit 37446522791492e8ee2c1c54af0d2da1e162d2e4.
2021-05-03 19:13:02 +00:00