Commit Graph

373 Commits

Author SHA1 Message Date
Wes Haggard
c2bc4736fd
Update location of big test file (#6320) 2025-01-09 14:48:50 -08:00
Ronnie Geraghty
b391d65809
Docs links coversion: docs.microsoft.com -> learn.microsoft.com (#6276)
* Docs links coversion: docs.microsoft.com -> learn.microsoft.com
Some markdown formatting

* Adding "msrc" to cspell words

* Undoing things auto formatter did

* Appling Ahson's suggestions
2024-12-16 09:32:19 -08:00
Larry Osterman
9770fb77dc
Implement mTLS support in WinHTTP transport. (#6131)
* Very preliminary mTLS implementation

* Tests for TLS client certificate

* Tested mTLS functionality

* Added changelog entry; updated PCCERT_CONTEXT using declaration to be more succinct.
2024-11-06 20:03:08 +00:00
Anton Kolesnyk
0180c8ee5c
HttpShared::GenerateUserAgent() (#6163)
* Rename UserAgentGenerator

* Update includes

* Clang-format

* Move GenerateUserAgent() to HttpShared class

* Update invocations

* Update invocations

* Clang-format

* Drop unnecessary include

* Update release dates

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-11-01 14:07:45 -07:00
Anton Kolesnyk
99e0895a5d
Move UserAgentGenerator to _internal (#6067)
* Move UserAgentGenerator to _internal

* Clang-format

* Update release date to November release (Core)

* Update release date to November release (EventHubs)

* _MSVC_LANG

* Move comment up

* Add /Zc:__cplusplus when building the SDK, and add unittest

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-10-31 10:00:12 -07:00
Ahson Khan
064fcad72f
Set token to be expired if response comes back as unauthorized, within BeareTokenAuthenticationPolicy. (#6151)
* Set token to be expired if response comes back as unauthorized.

* Add CL entry.

* Update CL.

* Use trc MinimumExpiration to invalidate the credential's token cache.

* Add test.

* Address PR feedback.

* Remove comment as it is no longer relevant.

* Use initializer list syntax to see if posix compilers are okay with that.

* Keep the bool field as non-atomic.

* Revert "Keep the bool field as non-atomic."

This reverts commit 1b8c7622d5234b010bb0a4eb5db8a436de5a2adf.
2024-10-30 14:00:42 -07:00
Ahson Khan
5a6176706d
Add basic input validation to ResourceIdentifier for ensuring the prefix match what is expected. (#6056)
* Initial verification and tests.

* Simplify validation checks to what's needed.

* Update changelog entry.

* Fix typo and disable cspell for a test line.

* Address PR feedback.
2024-10-02 06:42:01 +00:00
Ahson Khan
23729124bd
Make the HTTP transport behavior consistent between WinHTTP and libcurl by disabling automatically following redirects on Windows. (#6018)
* Make the HTTP transport behavior consistent between WinHTTP and libCurl by disabling automatically following redirects on Windows.

* Re-enable APC test.

* Fix casing in changelog.

* Add http bin based unit test and fix typo in doc comment for curl.

* Update test name to avoid 'dont'

* Fix typo.
2024-09-24 13:14:08 -07:00
Ahson Khan
c3265d3e5b
Fix input validation check for TimeFractionFormat in the DateTime ToString method (#5927)
* Fix input validation check for TimeFractionFormat in the DateTime ToString() method.

* Add changelog entry.

* Use switch-case instead of static casting the enum values.

* Address CL PR feedback.

* Fix the features added CL to put ResourceIdentifier in the right release.

* Address PR feedback - use type traits
2024-09-10 14:35:07 -07:00
Ahson Khan
ea3f1442b2
Move the ResourceIdentifier type from Azure::Identity to Azure::Core. (#5864)
* Move the ResourceIdentifier type from Identity to Azure::Core.

* Fix the namespace in the source cpp file.

* Fix managed identity credential tests.

* Fix clang format.
2024-09-05 15:22:18 -04:00
Anton Kolesnyk
6ae78faec8
Update Uuid parameter name, and improve tests (#5943)
* Update Uuid parameter name, and improve tests

* Update sdk/core/azure-core/inc/azure/core/uuid.hpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2024-08-27 18:40:54 -07:00
Anton Kolesnyk
91608bb5dc
Uuid::operator==(): self-comparison optimization, and more tests (#5939)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-08-27 14:22:21 -07:00
Anton Kolesnyk
ee0c7565df
Uuid: add default ctor and Parse() (#5935)
* Uuid: add default ctor and Parse()

* Fix merge, integrate better

* nano-optimization for IsNil()

* Changelog

* Pedantism

* GCC fix

* GCC fix (include <stdexcept>)

* PR feedback

* Update sdk/core/azure-core/test/ut/uuid_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Comments for bad tests

* Add doxygen comments

* One more constexpr, and clang-format

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2024-08-23 23:15:24 -07:00
Ahson Khan
d8b555a670
Optimize Uuid.ToString() by avoiding using sprintf to do the basic string transformation (#5925)
* Optimize Uuid.ToString() to use a cached value on multiple calls.

* Add tests which call ToString() multiple times.

* Optimize Uuid::ToString by avoiding using sprintf.

* Assert all byte values will fit into a hex character.

* Update comment in test.
2024-08-22 17:34:17 -07:00
George Arama
70dc0ebecb
Log policy extra headers (#5868)
* log policy extra headers

* failing test

* adding back WWW-Authenticate

* changelog update

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2024-08-07 17:40:37 +00:00
Anton Kolesnyk
0f62b3aa63
Add consumption-time value of __cplusplus to User-Agent (#5662)
* Add consumption-time value of __cplusplus to User-Agent

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-07-29 18:31:51 -07:00
Larry Osterman
90089ad326
Cleaned up Azure::Core::Context API surface (#5676)
* Deprecated Azure::Core::ApplicationContext because its use is confusing and inconsistent with the original design. 

---------

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2024-07-17 12:38:30 -07:00
Anton Kolesnyk
6b9e1cc691
Revert commits related to the new RetryPolicy method (#5793)
* Revert "Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)"

This reverts commit 9ccd206ff8.

* Revert "Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)"

This reverts commit f1d95520d1.

* Do not remove changelog entry from a previous beta release

* Revert "Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)"

This reverts commit ab90ef68b0.

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-07-12 12:03:43 -07:00
Ahson Khan
9ccd206ff8
Update the RetryPolicy for the GA release, keeping ShouldRetry extension point hidden. (#5771)
* Update the RetryPolicy for the GA release, keeping ShouldRetry extension
point hidden.

* Mark test helper virtual functions private, so they aren't
accessible/callable by callers.

* Update the changelog.

* Update CL.
2024-07-11 17:39:37 -07:00
George Arama
0b5b5ac951
Json library update and Xcode15 (#5681)
* Move up macos and xcode version

* first pass

* to trigger builds, some other issue

* rewrwe

* Remove MSVC compiler warning suppressions in KeyVault

The code within the `mocked_transport_adapter_test.hpp` file, specifically within the `Azure::Security::KeyVault::Keys` namespace, has been updated. The `#if defined(_MSC_VER)` preprocessor directive along with its associated `#pragma warning(push)` and `#pragma warning(disable : 4996)` directives have been removed. The corresponding `#pragma warning(pop)` directive has also been removed. The lines of code that were between these preprocessor directives remain unchanged. These changes remove specific compiler warning suppressions for MSVC compilers, but do not alter the functional behavior of the code.

* dassa

* Add UseDotNet@2 where test proxy might run on a macos agent

* test CI

* fsd

* dasdas

* gregre

* gerregr

* ffdsfsd

* fwefew

* fewfwew

* reter

* fewfew

* fwefwe

* rewrw

* rwe

* temp move build step to exec faster

* gdfgd

* fsdfd

* fdsfs

* dgdf

* Roll forward instead of installing .NET 6

* remove manual install

* rewrew

* gfdffg

* rewrwe

* gfdgd

* fdsfs

* gfdgdf

* tertre

* dasda

* try http for test proxy

* revert readmes

* rew

* rew

* fdsfsd

* ewrew

* revert storages

* KV

* opentelemetry

* remove warnbing

* anton comments

* unit tests

* clangs

* clang

* comment out some asserts

* restore originals

* updated tests

* clangs

* restore cmake

* test

* Remove manual workaround (eng/common change fixes this)

* test2

* the fix doesn't work, need to put back

* Remove DOTNET_ROLL_FORWARD

* annotate macro , put back DOTNET_ROLL_FORWARD

* remove leftover files

* reww

* update changelog

* remove left over file

* remove some doxygen comments

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2024-06-18 08:26:28 -07:00
Ahson Khan
f1d95520d1
Update the RetryPolicy and ShouldRetry customization logic to allow loosening the retry condition. (#5656)
* Update the RetryPolicy and ShouldRetry customization logic to allow
loosen the retry condition.

* Add CL entry and update doc comment.

* Move WasLastAttempt check out, and add more tests.

* Address PR feedback, remove use of void and unused params.
2024-05-30 11:08:56 +08:00
Larry Osterman
a9526d9375
Minor tweaks to HTTP tests found during Rust HTTP testing (#5658)
* Minor tweaks to HTTP tests found during Rust HTTP testing

* PR feedback
2024-05-23 04:15:05 +00:00
Anton Kolesnyk
fdb8657f41
Add HTTP request version logging, and scope the variables (#5643)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-05-20 14:06:55 -07:00
Ahson Khan
b7ae7b8987
Add retries to DisableCrlValidation test to improve reliability (#5537)
* Add retries to DisableCrlValidation test to improve reliability

* Add some test logging to CurlConnection ctor.

* Fix log level

* Revert changes to curl.cpp

* Reduce attempts to 3 and validate at least one passes.

* Remove unnecessary commented out code to reset CI.

* Remove unnecessary assert that won't fail.

* Remove unused variable.
2024-05-16 18:31:59 +00:00
Ahson Khan
d895f82ef8
Add basic tests for GetMajor/Minor HTTP versions in the response. (#5613)
* Add basic tests for GetMajor/Minor HTTP versions in the response.

* Make the tests parameterized.

* Address PR feedback - add more test cases.
2024-05-16 10:51:50 -07:00
Ahson Khan
ab90ef68b0
Add a virtual ShouldRetry method to the RetryPolicy for customization. (#5584)
* Add a virtual ShouldTry method to the RetryPolicy for customization.

* Make test hooks virtual again.

* Add unit test for ShouldRetry.

* Fix typo.

* Address PR feedback.

* Revert making the mock'd functions private for non-test builds.

* Add new line.
2024-05-14 01:09:02 +00:00
George Arama
8db62bf8da
reenable the global cleanup test (#5590) 2024-05-01 14:02:09 -07:00
Anton Kolesnyk
145f6dbdb6
Fixed libcurl connection pool to use Connection response header values (#5473)
* Fixed libcurl connection pool to use `Connection` response header values

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-04-10 08:01:29 -07:00
George Arama
84e4a81947
Api view comments (#5408)
* mroe quotes

* dssf

* listTables -> queryTables

* move create/delete to the tableservice

* one more batch

* small refactor, added default data types

* oops

* clangs

* table sas builder

* sas test

* cspell

* add more test

* cspell

* hjhjh

* clang

* rename table-> tables

* clang

* partition and row key

* clang why?

* constructors, update tests

* IT WORKSSSSS

* PR comments

* wqe

* ewr

* enum operator

* clang

* dsaada

* sada

* assets.json

* clang

* Update sdk/tables/azure-data-tables/inc/azure/data/tables/enum_operators.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/core/azure-core/test/ut/string_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* the = enums

* assert and remove empty

* compact string tests

* clangs

* complement

* azureSasCredentials

* PR cpmments

* some extra

* clang 11

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-03-15 14:30:45 -07:00
Anton Kolesnyk
aad2299dcd
Revert commits related to _azure_BUILD_FOR_TESTING and _azure_*_FOR_TESTS (#5416)
* Revert "Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where (#5406)"

This reverts commit 2d8c940f55.

* Revert "Rename the TESTING_BUILD macro to be _azure_TESTING_BUILD to highlight (#5390)"

This reverts commit 256c2df8b5.

* Revert "Use new macros in existing surface area, so that classes marked as final don't have virtual methods. (#5389)"

This reverts commit 3d7eaddb9d.

* Revert "For new surface area, classes marked as final should not have virtual methods. (#5331)"

This reverts commit ddd0f4bd07.

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2024-03-07 04:03:35 +00:00
Ahson Khan
3d7eaddb9d
Use new macros in existing surface area, so that classes marked as final don't have virtual methods. (#5389)
* Use new macros in existing surface area, so that classes marked as final don't have virtual methods.

* Update doc comments.

* Use DOXYGEN_PREDEFINED to expand only the macros we want expanded.

* Add the compile definition for more projects.

* Address PR feedback.

* Make TestableTokenCache a friend class of TokenCache.
2024-02-29 20:48:12 -08:00
George Arama
2a9934a596
Core perf tests consolidation (#5363)
* mroe quotes

* dssf

* compact the tests in the proper folder

* 2 more tests

* eqwq

* enabled all except http

* endline
2024-02-16 15:15:36 -08:00
George Arama
73bb6c63c1
Winhttp flaky test (#5356)
* mroe quotes

* dssf

* attempt 2

* updated test and logs

* clang

* update PR

* changelog update

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>

* Update sdk/core/azure-core/CHANGELOG.md

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

---------

Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-02-15 15:55:03 -08:00
George Arama
50cc742865
Json test (#5324)
* mroe quotes

* dssf

* sqa

* Json test p1

* qw

* re

* pr build

* cast part 2

* ew

* jj
2024-02-07 12:20:52 -08:00
George Arama
1689a00df9
Pipeline tests (#5310)
* mroe quotes

* dssf

* sqa

* pipeline and policies

* PR comments

* cast int
2024-02-02 13:03:38 -08:00
George Arama
4f6cc88004
Http Transport perf test (#5309)
* mroe quotes

* dssf

* sqa

* first identity test no caching

* cache no cache

* cleanup cache shortcircuit

* some cleanup

* http test 1

* Update sdk/core/perf/src/base_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR comments

* remove cache option

* wqq

* dsd

* saa

* wqq

* dfs

* clang

* http get post curl winhttp

* Update sdk/core/perf/inc/azure/perf/dynamic_test_options.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* rtter

* PR comments

* PT comments

* clang

* http transport test

* Update sdk/core/perf/src/base_test.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR comments

* remove cache option

* wqq

* dsd

* saa

* wqq

* dfs

* clang

* http get post curl winhttp

* rtter

* PR comments

* PT comments

* clang

* http transport test

* PR comments

* clangs

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2024-02-02 11:28:26 -08:00
George Arama
e69559f45e
Options UT (#5249)
* Options Http Enum add

* spaces

* options UT

* remove Options

* Revert "remove Options"

This reverts commit 0da5d2c1f57133c22723208d6feb2c925e7f8103.
2024-01-11 10:11:01 -08:00
Ahson Khan
88242f3cf1
Make the CAPath option available on all OSes and change to throw on runtime on non-linux. (#5207)
* Make the CAPath option available on all OSes and change to throw on
runtime on non-linux.

* Address PR feedback, update test, and let curl fail on unsupported
platforms.
2024-01-10 17:16:50 -08:00
George Arama
7eeb60960c
Options Http Enum add to Core (#5246)
* Options Http Enum add

* spaces
2024-01-10 12:26:37 -08:00
Ben Broderick Phillips
e5e675440b
Move squid image to registry mirror (#5218)
* Move squid image to registry mirror

* Add comments regarding private registry
2023-12-19 18:32:01 +00:00
Anton Kolesnyk
e328665588
Update cspell words and exclusions (#5231)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-12-15 17:41:11 -08:00
Anton Kolesnyk
15716714a4
Fix spelling errors (#5230)
* Fix spelling errors

* Exclusion list

* More updates for the exclusion list

* Even more updates for the exclusion list

* And even more updates for the exclusion list

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-12-15 14:17:59 -08:00
Anton Kolesnyk
24ecd16308
Fix some spelling errors (for some PRs that are currently in review) (#5202)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 10:49:58 -08:00
Anton Kolesnyk
fbf58139f7
Nullable::Emplace() to set HasValue() (#5178)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-28 08:10:52 +00:00
Anton Kolesnyk
ee4be19b3f
URL: avoid double slash at the start of the path (#5187)
* URL: avoid double slash at the start of the path

* Remove unnecessary change

* More test coverage

* Changelog

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-27 23:03:27 -08:00
Anton Kolesnyk
6da4d9649d
FIx typos (#5185)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-11-27 13:55:27 -08:00
Ahson Khan
f2bd22794d
Incapsulate all the defaults for options values such as authority host in a helper class and add authority host url validation. (#5155)
* Incapsulate all the defaults for options values such as authority host
in a helper class and add authority host url validation.

* Address PR feedback.
2023-11-11 05:00:14 +00:00
Anton Kolesnyk
50c18516df
Ensure CMakeLists don't miss any files (#5065)
* Ensure CMakeLists don't miss any files

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2023-10-26 18:15:03 -07:00
Larry Osterman
a6de66df02
Remove code coverage exclusions from Azure SDK for C++ (#5055)
* Try to see what happens without coverage exclusions

* Reset coverage limits

* Mark ThrowParseError as [[noreturn]] to ensure compiler knows that code after it is dead code

* Added tests for the Azure assert macro

---------

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2023-10-25 10:30:02 -07:00
Ahson Khan
9a2c2e1257
Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in libcurl (#5009)
* Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in
libcurl.

* Revert unit test change that caused an intentional error.

* Remove the openssl header.
2023-10-05 20:30:46 +00:00