github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add retries to DisableCrlValidation test to improve reliability (#5537)

Browse Source 
* Add retries to DisableCrlValidation test to improve reliability

* Add some test logging to CurlConnection ctor.

* Fix log level

* Revert changes to curl.cpp

* Reduce attempts to 3 and validate at least one passes.

* Remove unnecessary commented out code to reset CI.

* Remove unnecessary assert that won't fail.

* Remove unused variable.
This commit is contained in:
Ahson Khan 2024-05-16 11:31:59 -07:00 committed by GitHub
parent c95f74a88b
commit b7ae7b8987
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 27 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
sdk/core/azure-core/test/ut/transport_policy_options.cpp
View File

@ -430,19 +430,37 @@ namespace Azure { namespace Core { namespace Test {
TEST_F(TransportAdapterOptions, DisableCrlValidation)
{
Azure::Core::Url testUrl(AzureSdkHttpbinServer::Get());
// Azure::Core::Url testUrl("https://www.microsoft.com/");
// HTTP Connections.
auto failedCounter = 0;
for (auto i = 0; i < 3; i++)
{
Azure::Core::Http::Policies::TransportOptions transportOptions;
GTEST_LOG_(INFO) << "DisableCrlValidation test iteration " << i << ".";
try
{
Azure::Core::Http::Policies::TransportOptions transportOptions;
// Note that the default is to *disable* CRL checks, because they are disabled
// by default. So we test *enabling* CRL validation checks.
transportOptions.EnableCertificateRevocationListCheck = true;
HttpPipeline pipeline(CreateHttpPipeline(transportOptions));
// Note that the default is to *disable* CRL checks, because they are disabled
// by default. So we test *enabling* CRL validation checks.
transportOptions.EnableCertificateRevocationListCheck = true;
HttpPipeline pipeline(CreateHttpPipeline(transportOptions));
auto request = Azure::Core::Http::Request(Azure::Core::Http::HttpMethod::Get, testUrl);
auto response = pipeline.Send(request, Azure::Core::Context::ApplicationContext);
EXPECT_EQ(response->GetStatusCode(), Azure::Core::Http::HttpStatusCode::Ok);
auto request = Azure::Core::Http::Request(Azure::Core::Http::HttpMethod::Get, testUrl);
auto response = pipeline.Send(request, Azure::Core::Context::ApplicationContext);
EXPECT_EQ(response->GetStatusCode(), Azure::Core::Http::HttpStatusCode::Ok);
}
catch (Azure::Core::Http::TransportException const&)
{
// CURL returns a connection error which triggers a transport exception.
GTEST_LOG_(INFO) << "DisableCrlValidation test iteration " << i
<< " failed with a TransportException.";
failedCounter++;
// We allow 1 intermittent failure, due to networking issues.
if (failedCounter > 1)
{
throw;
}
}
}
#if defined(ENABLE_PROXY_TESTS)
if (IsSquidProxyRunning)