It is generally useful for PR authors to go through their own PR first to make sure that commonly occurring feedback and issues have already been addressed. This checklist should help remind contributors what to look out for and is a living doc that we can modify and add to.
I ask these questions to myself before submitting a PR, when looking through my changes in the "pre-PR-submit-view".
Where possible leverage linter tools and CI gates to help address some of these. For example, for spell-check, here are some solutions to make things easier within the developer inner-loop:
- VS Code extension: [Code Spell Checker](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker)
- VS Code extension: [Markdown linter](https://github.com/DavidAnson/vscode-markdownlint)
- Browser extension: [Site Spell](https://www.site-spell.com/)
Adding CMake module to enable/disable transport adapters
TRANSPORT ADAPTER BUILD
Default: If no option is explicitly added, curl will be used for POSIX and WIN HTTP for WIndows
Windows: Both CURL and WIN_HTTP can be build to be used.
POSIX: Only CURL is acceptable. If WIN_HTTP is set, generate step will fail for user
Defines `BUILD_WIN_HTTP_TRANSPORT_ADAPTER` and `BUILD_CURL_HTTP_TRANSPORT_ADAPTER` for source code
Fixes#350
* Simplify Net-TestResources usage
* docs and windows check
* Update eng/common/TestResources/New-TestResources.ps1
Co-authored-by: Heath Stewart <heaths@outlook.com>
* update markdown
* make service directory the default parameter
* Fix links
* Doc change
Co-authored-by: Pavel Krymets <pavel@krymets.com>
Co-authored-by: Heath Stewart <heaths@outlook.com>
* Update cache-control for newly created blobs
* remove extra
* remove extra space
* Added the cache control for existing blobs as well
* Update copy-docs-to-blobstorage.ps1
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* Update location of patch files
* Add some changes in eng/common to test things
* Switch to pushing to upstream
* Change workflow to use upstream branches
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Added build arguments to pass to cmake for running tests. If these
options are not passed during cmake build and someone tries to run test,
it will throw error "No tests were found!!!"
* SetExpiry protocol layer
* add test
* last access time
* upgrade blob sas to 2020-02-10
* datalake sas
* fix build error
* tag count
* enable tag test
* fix build error
* enable container soft delete test
* Response<T> stores Nullable<T>
Drive-by: Replace `Nullable(const T&)` with `Nullable(T)` to avoid extra copy when initialized with an rvalue.
* Update sdk/core/azure-core/inc/azure/core/response.hpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Standardize header includes
Update sources to match guidelines
- `#include ""` when file is relative to the project
- `#include <>` when file is external to the project
Updated tests to mirror how a customer will include the header
- `#include <>`
