George Arama
34fe4dcfb9
[GEARAMA]: Final set of updates from archboard review of KeyVault certificates ( #3050 )
...
* investigateTestFail
* undo stuffs
* couple more comments
* key_usage fix
* put back stuff
* remove name
* bb
* undo stuffs
* couple more comments
* key_usage fix
* put back stuff
* remove name
* bb
* bbfix
* merge issues
2021-11-04 17:54:28 -07:00
George Arama
79eda8d184
[GEARAMA]: Updates from archboard review of KeyVault certificates ( #3029 )
...
* some more udpates
* Url suffix
* remove unused constructor
* name in issuer get props
* policy no policy
* for pr
* investigateTestFail
* undo stuffs
* build issues
* fixes for PR
* put back the names
* samples and readmes
* last changes, regned the recordings
2021-11-04 15:20:47 -07:00
Victor Vazquez
46f6c21124
Revert "Changelog ( #3044 )" ( #3054 )
...
This reverts commit 8148444413
2021-11-04 14:05:48 -07:00
George Arama
8148444413
Changelog ( #3044 )
...
* investigateTestFail
* undo stuffs
* couple more comments
* changelog
2021-11-04 13:59:31 -07:00
George Arama
35e6706f73
Tests again ( #3030 )
...
* investigateTestFail
* undo stuffs
* repro
* az log level
* =vv
* remove deletes at end of tests
* oh boy
* timeout increase
* make test to 20s for retry
* revert global changes
* final changes
* revert yml changes
2021-11-04 11:22:39 -07:00
George Arama
dc8c6b2dcc
Vcpkg ( #3041 )
...
* investigateTestFail
* undo stuffs
* fix vcpkg file
2021-11-04 11:22:28 -07:00
Victor Vazquez
2ce1b65601
use relative instead of source as the source can change ( #3034 )
2021-11-04 00:37:43 +00:00
George Arama
8792280695
Lro ( #3018 )
...
* LRO
* qfe
* investigateTestFail
* undo stuffs
* PR feedback
* one more issue
2021-11-03 16:56:33 -07:00
Daniel Jurek
413b4b7665
Add coverage enforcement ( #2992 )
...
* Add coverage enforcement
* Add spelling exception for mspremier
* Use previous build coverage data, enforce 3% variance, use Skip.CoverageEnforcement feature flag
* Use version 8 of quality checks
* Remove forceCoverageImprovement, it doesn't allow 0% improvements (e.g. doc changes, etc.)
* branch -> branches
* Configure coverage thresholds per-service
* Use fixed coverage
* Review feedback
* Per-service coverage plumbing
* Flip branch and line coverage requirements for KV to accurately reflect current baseline
2021-11-03 10:56:32 -07:00
George Arama
333891c972
param <-> options ( #3014 )
...
* param <-> options
* quick typo
2021-11-02 11:55:57 -07:00
George Arama
19fd7e5f32
dedupe names in test also ensure for live we get new names ( #3013 )
...
* dedupe names in test also ensure for live we get new names
* Victor comments, name certs based on test name
* oops
2021-11-02 11:10:14 -07:00
George Arama
ca7b2a0e98
add certificates to ci.yml ( #3015 )
2021-11-01 16:14:05 -07:00
Ahson Khan
041feefd67
Testing KeyVault live test runs to reproduce errors and disable test to unblock CI ( #3007 )
...
* Temporary change to trigger a PR run
* Disable GetCertificate and GetCertificateVersion unit tests
* Revert readme change
2021-11-01 11:39:19 -07:00
George Arama
08947edfc8
Api review ( #3004 )
...
* operator !=
* moved download , make protected private
* structs and classes
* comments
* change std::vector into struct
* optional structs
* get version
* api signature changes
* remove the options structs where not necessary , they are extremelly ugly
* fix issue
* small sample readme update
* simplify certificate creation
2021-10-28 11:21:20 -07:00
Victor Vazquez
1bdc478dcb
fixes for linux gcc ( #3003 )
2021-10-27 20:49:01 +00:00
George Arama
30f62eb3aa
Api review changes ( #2994 )
...
* operator !=
* moved download , make protected private
* structs and classes
* comments
* change std::vector into struct
* optional structs
* get version
* api signature changes
* remove the options structs where not necessary , they are extremelly ugly
* fix issue
* small sample readme update
2021-10-27 10:26:30 -07:00
George Arama
c7f8e02c6a
Readme ( #2995 )
...
* rtet
* readme
* yte
2021-10-26 12:05:58 -07:00
George Arama
a9094d0933
Samples ( #2986 )
...
* two samples
* samples
* typas, types, typis .... typos
* PR comments
2021-10-25 18:30:43 -07:00
George Arama
5ad55ecb6e
Download import merge ( #2976 )
...
* functioning, tests updated
* download import merge
* latest and greatest
* build issues
* spellcheck
* PR comments
* PR comments
* one last PR comment
2021-10-20 21:32:38 -07:00
Anton Kolesnyk
e0dcc20a82
Remove incorrect scope comments ( #2983 )
...
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-10-19 18:22:03 -07:00
Anton Kolesnyk
b477373a9c
Remove extra semicolons ( #2979 )
...
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-10-19 16:08:42 -07:00
George Arama
60ba5599f8
Rework create ( #2967 )
...
* functioning, tests updated
* PR build
* PR comments
2021-10-18 19:25:38 -07:00
Victor Vazquez
f4e6390dff
Enable no-rtti ( #2963 )
...
* Enable no-rtti
2021-10-14 18:12:03 -07:00
George Arama
27747b1898
Get Paged responses ( #2964 )
...
* props and versions
* some more clients
* cmake
* cmake
* eweq
* comments
* tests
* formating and build issues
* Certicate-> Certificate
* remove uneeded comment
2021-10-13 12:24:13 -07:00
George Arama
11b6fc8d3a
backup & restore ( #2959 )
...
* backup & restore
* build errors
* fixes from merging
2021-10-12 18:10:50 -07:00
George Arama
239c3c9f54
Get and update certificate policy ( #2958 )
...
* Get and update certificate policy
* build issue
2021-10-12 17:30:53 -07:00
George Arama
a2e5262d6f
Delete/getDeleted/Purge/recover ( #2914 )
...
* functionality, next tests
* Updates for tests, and bug fix found in test
* PR comments
* missed comment
* PR comments
* catch by value
2021-10-12 14:55:05 -07:00
Victor Vazquez
4eb33a0015
Update Key Vault packages to use Shared-code ( #2905 )
...
* Use key vault shared code strategy for code-reuse between packages
* use a class instead of function only
* unwanted change
* unwanted change
* remove the install interface
* typo
2021-10-11 14:17:55 -07:00
George Arama
bcfbe44a73
rework the polling method ( #2949 )
...
* rework th polling method
* fix typo for clang
* typo 2
* moved method to private
* expose properties
* Update to use Properties instead of redirecting to internal member
* formar files
2021-10-06 15:48:33 -07:00
George Arama
e5a01a29bd
Certificate Contacts API ( #2912 )
...
* Certificate Contacts API
* PR issues
* spell
* revert cspell , set disables in code
* set disables in code
* PR comments
* PR comments
* pr issue
* pr comments
* oops
* missed replace
2021-10-06 12:12:18 -07:00
Azure SDK Bot
5aa13f541d
Increment package version after release of azure-security-keyvault-keys ( #2951 )
2021-10-06 10:53:14 -07:00
Victor Vazquez
6044c63ad1
update changelog to release verion ( #2937 )
2021-10-05 11:38:02 -07:00
George Arama
613972c4c4
Certificates Issuers API ( #2911 )
...
* issuers
* PR issues
* PR comments
2021-10-04 12:08:43 -07:00
Victor Vazquez
fc01933f28
disable cert tests for now ( #2939 )
2021-09-29 13:45:00 -07:00
Victor Vazquez
8a12a64629
Adding GetCryptographyClient to KeyClient ( #2917 )
...
* Adding GetCryptographyClient to KeyClient
* update arg name
2021-09-27 15:36:37 -07:00
George Arama
8727030623
Start create certificate ( #2909 )
...
* fix tests local
* first stab
* second
* operation
* HUzaaaah
* split header file
* updates
* error
* format, error
* clang due to certificates
* remove useless line used for debugginng
* Update .vscode/cspell.json
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update .vscode/cspell.json
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client_models.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client_operations.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* PR fixes
* revert wrong changes
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-09-21 12:38:41 -07:00
Azure SDK Bot
c21718f838
Increment version for keyvault releases ( #2855 )
...
* Increment package version after release of azure-security-keyvault-keys
* Increment package version after release of azure-security-keyvault-secrets
2021-09-08 17:21:42 -07:00
Victor Vazquez
f752663d35
diable cert live tests ( #2851 )
2021-09-08 13:10:52 -07:00
Victor Vazquez
41138dcc8a
cl ( #2840 )
2021-09-08 10:08:33 -07:00
George Arama
6f8236287e
first pass ( #2841 )
2021-09-08 10:07:56 -07:00
Victor Vazquez
4ec0a34247
update links ( #2842 )
2021-09-07 14:45:08 -07:00
Victor Vazquez
8f0d6728c3
Adding Key Vault Certificates - GetCertificateWithPolicy API ( #2818 )
...
* certs one api checkpoint
2021-09-07 13:44:15 -07:00
George Arama
2b205d95f7
Kyle feedback ( #2822 )
...
* rename readmes for samples to show up in repo by default
* moved files around per kyle's comment
* update cmake file
* update links to samples
2021-09-02 10:28:50 -07:00
George Arama
9ef8d5a45f
cspell fixes for keyvault ( #2812 )
...
* cspell fixes for keyvault
* formatting issues
2021-08-30 19:49:22 -07:00
Victor Vazquez
ddee45759f
Add support for non public scope for secret client credential on Key Vault ( #2763 )
...
* add support for non public scope for secret client credential
* improve function comments
* update tests with good url
* update secret url tests
* update logic to no-throw
* use class
* Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* format
* fix
* remove default scope
* move patch out of Core to use package-per-client patch
* update includes
* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* update patch
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-08-30 16:39:54 -07:00
George Arama
9bcfc247b1
Secrets test ( #2764 )
...
* playback tests
* two running tests
* more tests and some redaction
* formatting
* formatting
* fix bb and remove unused includes
* macos
* annoying issues
* offline client
* format
* pr comment
* reset the env to original after the client is gone.
* oops
* testing
* formats
* remove default resource for secrets, not needed
* code coverage
* build issue
2021-08-26 11:19:37 -07:00
George Arama
04f4d3a5cf
Api review feedback ( #2795 )
...
* first set of changes
* another set
* add new constructor
* format files, remove pedantinc ;
* factory
* format
* expect_death not behaving as expected
2021-08-26 10:45:36 -07:00
Victor Vazquez
3ddd7f65f8
update test config for keyvault ( #2793 )
2021-08-25 14:58:31 -07:00
Anton Kolesnyk
7332432efd
Re-add vcpkg version constraints ( #2781 )
...
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-08-24 16:10:07 -07:00
Victor Vazquez
d66081c01f
use package version for telemetry ( #2780 )
2021-08-23 11:04:14 -07:00
